Add some regression tests #68236

JohnTitor · 2020-01-14T23:44:33Z

Closes #64848 (fixed by #67631)
Closes #65918 (ICE is hidden by #67000, no longer ICE)
Closes #66473 (fixed by #68084)
Closes #67550 (set mir-opt-level to 3)

r? @Centril

Centril

r=me with comment addressed.

src/test/ui/const-generics/issue-62879.rs

Centril · 2020-01-15T13:52:13Z

@bors r+

bors · 2020-01-15T13:52:15Z

📌 Commit 9ca066e2b98aa33bf063443c3de4ba760c542c75 has been approved by Centril

rust-highfive · 2020-01-15T14:33:34Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-15T13:24:45.8369733Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-15T13:24:45.8474392Z ##[command]git config gc.auto 0
2020-01-15T13:24:45.8563891Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-15T13:24:45.8634909Z ##[command]git config --get-all http.proxy
2020-01-15T13:24:45.8785914Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68236/merge:refs/remotes/pull/68236/merge
---
2020-01-15T14:21:36.4236209Z .................................................................................................... 1700/9523
2020-01-15T14:21:45.1487453Z .................................................................................................... 1800/9523
2020-01-15T14:21:55.0587935Z ..........i......................................................................................... 1900/9523
2020-01-15T14:22:02.3405949Z .................................................................................................... 2000/9523
2020-01-15T14:22:18.9285761Z iiiii............................................................................................... 2100/9523
2020-01-15T14:22:27.6820082Z .................................................................................................... 2300/9523
2020-01-15T14:22:30.3705847Z .................................................................................................... 2400/9523
2020-01-15T14:22:36.2944174Z .................................................................................................... 2500/9523
2020-01-15T14:22:57.2526480Z .................................................................................................... 2600/9523
---
2020-01-15T14:25:41.8752030Z ...........................................i...............i........................................ 4900/9523
2020-01-15T14:25:51.4065221Z .................................................................................................... 5000/9523
2020-01-15T14:25:58.3155144Z ......................................................................................i............. 5100/9523
2020-01-15T14:26:03.8965175Z .................................................................................................... 5200/9523
2020-01-15T14:26:14.9530331Z ..........................................................ii.ii...........i......................... 5300/9523
2020-01-15T14:26:24.8215204Z .................................................................................................... 5500/9523
2020-01-15T14:26:35.5500700Z .................................................................................................... 5600/9523
2020-01-15T14:26:42.4568380Z ...........................................i........................................................ 5700/9523
2020-01-15T14:26:49.7728143Z .................................................................................................... 5800/9523
2020-01-15T14:26:49.7728143Z .................................................................................................... 5800/9523
2020-01-15T14:27:00.8988556Z .................................................................................................... 5900/9523
2020-01-15T14:27:10.5892550Z ..................................ii...i..ii...........i............................................ 6000/9523
2020-01-15T14:27:30.6431352Z .................................................................................................... 6200/9523
2020-01-15T14:27:39.3090069Z .................................................................................................... 6300/9523
2020-01-15T14:27:39.3090069Z .................................................................................................... 6300/9523
2020-01-15T14:27:46.8229218Z ..............................................................i..ii................................. 6400/9523
2020-01-15T14:28:16.2391284Z .................................................................................................... 6600/9523
2020-01-15T14:28:18.6865014Z ......................................i............................................................. 6700/9523
2020-01-15T14:28:21.0120734Z .................................................................................................... 6800/9523
2020-01-15T14:28:23.7880240Z ......................................i............................................................. 6900/9523
---
2020-01-15T14:30:05.7140388Z .................................................................................................... 7500/9523
2020-01-15T14:30:10.4524652Z .................................................................................................... 7600/9523
2020-01-15T14:30:16.8050619Z .................................................................................................... 7700/9523
2020-01-15T14:30:23.9858874Z .................................................................................................... 7800/9523
2020-01-15T14:30:34.5077795Z .......................................................................................iiii......... 7900/9523
2020-01-15T14:30:51.8428079Z .....................i......i....................................................................... 8100/9523
2020-01-15T14:30:57.0762657Z .................................................................................................... 8200/9523
2020-01-15T14:31:10.7889855Z .................................................................................................... 8300/9523
2020-01-15T14:31:21.6666734Z .................................................................................................... 8400/9523
---
2020-01-15T14:33:27.5700298Z failures:
2020-01-15T14:33:27.5700491Z 
2020-01-15T14:33:27.5700993Z ---- [ui] ui/const-generics/issue-62879.rs stdout ----
2020-01-15T14:33:27.5701160Z 
2020-01-15T14:33:27.5701310Z error: Error: expected failure status (Some(1)) but received status Some(101).
2020-01-15T14:33:27.5701479Z status: exit code: 101
2020-01-15T14:33:27.5702464Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/const-generics/issue-62879.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-generics/issue-62879" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-generics/issue-62879/auxiliary" "-A" "unused"
2020-01-15T14:33:27.5703311Z ------------------------------------------
2020-01-15T14:33:27.5703667Z 
2020-01-15T14:33:27.5704076Z ------------------------------------------
2020-01-15T14:33:27.5704252Z stderr:
---
2020-01-15T14:33:27.5705690Z    |            ^^^^^^^^^^^^^^
2020-01-15T14:33:27.5705846Z    |
2020-01-15T14:33:27.5705984Z    = note: `#[warn(incomplete_features)]` on by default
2020-01-15T14:33:27.5706106Z 
2020-01-15T14:33:27.5706281Z error: internal compiler error: src/librustc/ty/subst.rs:605: const parameter `N/#0` (Const { ty: usize, val: Param(N/#0) }/0) out of range when substituting substs=[]
2020-01-15T14:33:27.5706833Z thread 'rustc' panicked at 'Box<Any>', <::std::macros::panic macros>:2:4
2020-01-15T14:33:27.5707032Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-15T14:33:27.5707153Z 
2020-01-15T14:33:27.5707312Z note: the compiler unexpectedly panicked. this is a bug.
2020-01-15T14:33:27.5707312Z note: the compiler unexpectedly panicked. this is a bug.
2020-01-15T14:33:27.5707432Z 
2020-01-15T14:33:27.5707965Z note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
2020-01-15T14:33:27.5708156Z 
2020-01-15T14:33:27.5708576Z note: rustc 1.42.0-nightly (01c0794ff 2020-01-15) running on x86_64-unknown-linux-gnu
2020-01-15T14:33:27.5708730Z 
2020-01-15T14:33:27.5709260Z note: compiler flags: -Z threads=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z unstable-options -C prefer-dynamic -C rpath -C debuginfo=0
2020-01-15T14:33:27.5710480Z error: aborting due to previous error
2020-01-15T14:33:27.5710537Z 
2020-01-15T14:33:27.5710892Z 
2020-01-15T14:33:27.5711223Z ------------------------------------------
---
2020-01-15T14:33:27.5780626Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:387:22
2020-01-15T14:33:27.5780745Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-15T14:33:27.5796770Z 
2020-01-15T14:33:27.5796860Z 
2020-01-15T14:33:27.5802192Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-15T14:33:28.5292321Z 
2020-01-15T14:33:28.5292488Z 
2020-01-15T14:33:28.5292746Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-15T14:33:28.5292903Z Build completed unsuccessfully in 1:02:37
2020-01-15T14:33:28.5292903Z Build completed unsuccessfully in 1:02:37
2020-01-15T14:33:28.5293047Z == clock drift check ==
2020-01-15T14:33:28.5293210Z   local time: Wed Jan 15 14:33:27 UTC 2020
2020-01-15T14:33:28.5293595Z   network time: Wed, 15 Jan 2020 14:33:27 GMT
2020-01-15T14:33:28.5293761Z == end clock drift check ==
2020-01-15T14:33:28.5293904Z 
2020-01-15T14:33:28.5354064Z ##[error]Bash exited with code '1'.
2020-01-15T14:33:28.5390195Z ##[section]Starting: Checkout
2020-01-15T14:33:28.5391822Z ==============================================================================
2020-01-15T14:33:28.5391878Z Task         : Get sources
2020-01-15T14:33:28.5391927Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

JohnTitor · 2020-01-15T14:39:21Z

Uhm, the ICE revives in latest rustc... I'll drop that test.
@bors r-

JohnTitor · 2020-01-15T14:43:42Z

Dropped.
@bors r=Centril

bors · 2020-01-15T14:43:44Z

📌 Commit 3ba15bd has been approved by Centril

@Centril

Add some regression tests Closes rust-lang#64848 (fixed by rust-lang#67631) Closes rust-lang#65918 (ICE is hidden by rust-lang#67000, no longer ICE) Closes rust-lang#66473 (fixed by rust-lang#68084) Closes rust-lang#67550 (set mir-opt-level to 3) r? @Centril

@ghost

Rollup of 6 pull requests Successful merges: - #68123 (Implement Cursor for linked lists. (RFC 2570).) - #68212 (Suggest to shorten temporary lifetime during method call inside generator) - #68232 (Optimize size/speed of Unicode datasets) - #68236 (Add some regression tests) - #68237 (Account for `Path`s in `is_suggestable_infer_ty`) - #68252 (remove redundant clones, found by clippy) Failed merges: r? @ghost

rust-highfive assigned Centril Jan 14, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2020

Centril added F-const_generics `#![feature(const_generics)]` F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` labels Jan 15, 2020

Centril reviewed Jan 15, 2020

View reviewed changes

src/test/ui/const-generics/issue-62879.rs Outdated Show resolved Hide resolved

JohnTitor mentioned this pull request Jan 15, 2020

const generics: cycle error due to a lack of lazy normalization #68249

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 15, 2020

JohnTitor added 4 commits January 15, 2020 23:41

Add test for issue-64848

406049d

Add test for issue-65918

ce8fed6

Add test for issue-66473

27a810c

Set mir-opt-level to 3 to prevent regressions

3ba15bd

JohnTitor force-pushed the ice-tests branch from 9ca066e to 3ba15bd Compare January 15, 2020 14:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 15, 2020

JohnTitor removed the F-const_generics `#![feature(const_generics)]` label Jan 15, 2020

Dylan-DPC-zz mentioned this pull request Jan 15, 2020

Rollup of 6 pull requests #68254

Merged

bors merged commit 3ba15bd into rust-lang:master Jan 15, 2020

JohnTitor deleted the ice-tests branch January 15, 2020 22:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add some regression tests #68236

Add some regression tests #68236

JohnTitor commented Jan 14, 2020 •

edited

Loading

Centril left a comment

Centril commented Jan 15, 2020

bors commented Jan 15, 2020

rust-highfive commented Jan 15, 2020

JohnTitor commented Jan 15, 2020

JohnTitor commented Jan 15, 2020

bors commented Jan 15, 2020

Add some regression tests #68236

Add some regression tests #68236

Conversation

JohnTitor commented Jan 14, 2020 • edited Loading

Centril left a comment

Choose a reason for hiding this comment

Centril commented Jan 15, 2020

bors commented Jan 15, 2020

rust-highfive commented Jan 15, 2020

JohnTitor commented Jan 15, 2020

JohnTitor commented Jan 15, 2020

bors commented Jan 15, 2020

JohnTitor commented Jan 14, 2020 •

edited

Loading