Clean up err codes #68176
Merged
Clean up err codes #68176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
| @@ -10,8 +11,9 @@ type Foo = Trait; // error: the value of the associated type `Bar` (from | |||
| // the trait `Trait`) must be specified | |||
| ``` | |||
|
|
|||
| Please verify you specified all associated types of the trait and that you | |||
| used the right trait. Example: | |||
| Trait objects need to have all associated types specified. Please verify you | |||
There was a problem hiding this comment.
Suggested change
| Trait objects need to have all associated types specified. Please verify you | |
| Trait objects need to have all associated types specified. Please verify that |
| Please verify you specified all associated types of the trait and that you | ||
| used the right trait. Example: | ||
| Trait objects need to have all associated types specified. Please verify you | ||
| specified all associated types of the trait and that you used the right trait. |
There was a problem hiding this comment.
Suggested change
| specified all associated types of the trait and that you used the right trait. | |
| all associated types of the trait were specified and the correct trait was used. |
| @@ -1,5 +1,6 @@ | |||
| Trait objects need to have all associated types specified. Erroneous code | |||
| example: | |||
| A trait object's associated type wasn't specified. | |||
There was a problem hiding this comment.
Suggested change
| A trait object's associated type wasn't specified. | |
| An associated type wasn't specified for a trait object |
GuillaumeGomez
force-pushed
the
clean-up-err-codes
branch
from
1781325 to
3ec0a84
Compare
|
Updated. |
|
@bors r+ rollup |
|
📌 Commit 3ec0a84 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 14, 2020
…r=Dylan-DPC Clean up err codes r? @Dylan-DPC
bors
added a commit
that referenced
this pull request
Jan 14, 2020
Rollup of 10 pull requests Successful merges: - #67854 (Use `report_in_external_macro` for internal lints) - #67989 (rustdoc: Don't allow `#![feature(...)]` on stable or beta) - #68036 (libterm: parse extended terminfo format) - #68127 (Clarify the relationship between `extended` and `tools` in `config.toml`) - #68143 (Forbid elided lifetimes within const generic parameter types) - #68150 (Document behavior of set_nonblocking on UnixListener) - #68166 (rustdoc: HTML escape arrows on help popup) - #68176 (Clean up err codes) - #68179 (Remove unneeded scope) - #68188 (Tweak assertion note in format check) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Dylan-DPC