rustc_ast_lowering: misc cleanup & rustc dep reductions #67922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
lowering-cleanup
branch
from
cddb4f0 to
1301574
Compare
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
lowering-cleanup
branch
from
1301574 to
2dc8b52
Compare
petrochenkov
reviewed
Jan 8, 2020
|
r=me with the comments addressed, unless you want to wait for Oli. |
petrochenkov
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
lowering-cleanup
branch
from
2dc8b52 to
dbb29a8
Compare
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 8, 2020
Move `intravisit` => `rustc_hir` + misc cleanup Working towards rust-lang#65031. This should eventually enable getting rid of rustc as a dependency in various passes (e.g. lints). cc rust-lang#67806 (this also facilitates liberating lints from tcx) cc rust-lang#67922 (some other dep reductions) r? @Zoxc
Centril
force-pushed
the
lowering-cleanup
branch
from
f0451c2 to
b743af6
Compare
Centril
force-pushed
the
lowering-cleanup
branch
from
8bdbf5a to
5dafa6a
Compare
|
@bors r=petrochenkov |
|
📌 Commit 5dafa6a has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 10, 2020
…enkov rustc_ast_lowering: misc cleanup & rustc dep reductions - The first two commits do some code simplification. - The next three do some file splitting (getting `lib.rs` below the 3kloc tidy lint). - The remaining commits reduce the number of `rustc::` imports. This works towards making lowering independent of the `rustc` crate. r? @oli-obk cc @Zoxc
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 10, 2020
…enkov rustc_ast_lowering: misc cleanup & rustc dep reductions - The first two commits do some code simplification. - The next three do some file splitting (getting `lib.rs` below the 3kloc tidy lint). - The remaining commits reduce the number of `rustc::` imports. This works towards making lowering independent of the `rustc` crate. r? @oli-obk cc @Zoxc
bors
added a commit
that referenced
this pull request
Jan 10, 2020
Rollup of 6 pull requests Successful merges: - #66463 (Point at opaque and closure type definitions in type errors) - #67501 (Reduce special treatment for zsts) - #67820 (Parse the syntax described in RFC 2632) - #67922 (rustc_ast_lowering: misc cleanup & rustc dep reductions) - #68071 (Extend support of `_` in type parameters) - #68073 (expect `fn` after `const unsafe` / `const extern`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib.rsbelow the 3kloc tidy lint).rustc::imports. This works towards making lowering independent of therustccrate.r? @oli-obk cc @Zoxc