Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option::{expect,unwrap} and Result::{expect, expect_err, unwrap, unwrap_err} have #[track_caller] #67887

Merged
merged 4 commits into from
Jan 8, 2020
Merged

Option::{expect,unwrap} and Result::{expect, expect_err, unwrap, unwrap_err} have #[track_caller] #67887

merged 4 commits into from
Jan 8, 2020

Commits on Jan 5, 2020

  1. Option's panics are all #[track_caller]. 

    Also includes a simple test with a custom panic hook to ensure we don't regress.
    @anp
    anp committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    2e9d573 View commit details
    Browse the repository at this point in the history

  2. Result's panics have #[track_caller].

    @anp
    anp committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    7a6af7e View commit details
    Browse the repository at this point in the history

  3. Fix typo 

    Co-Authored-By: lzutao <taolzu@gmail.com>
    @anp @tesuji
    anp and tesuji committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    b97ee0f View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Skip caller location test in wasm32.

    @anp
    anp committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    3acd346 View commit details
    Browse the repository at this point in the history