Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change remove to have a PartialEq bound #67873

Merged
merged 5 commits into from
Jan 6, 2020
Merged

change remove to have a PartialEq bound #67873

merged 5 commits into from
Jan 6, 2020

Conversation

Dylan-DPC-zz
Copy link

Addresses comment.

References #40062

r? @Amanieu

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 4, 2020
Merged
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-01-04T18:31:40.6650137Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-04T18:31:41.2017394Z ##[command]git config gc.auto 0
2020-01-04T18:31:41.2020303Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-04T18:31:41.2022952Z ##[command]git config --get-all http.proxy
2020-01-04T18:31:41.2027021Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67873/merge:refs/remotes/pull/67873/merge
---
2020-01-04T19:26:19.3141893Z .................................................................................................... 1500/9472
2020-01-04T19:26:25.1737456Z .................................................................................................... 1600/9472
2020-01-04T19:26:30.1055018Z .................................................................................................... 1700/9472
2020-01-04T19:26:39.5051725Z .................................................................................................... 1800/9472
2020-01-04T19:26:47.6591402Z i................................................................................................... 1900/9472
2020-01-04T19:26:54.3950103Z ......................................................................................iiiii......... 2000/9472
2020-01-04T19:27:16.2902292Z .................................................................................................... 2200/9472
2020-01-04T19:27:18.7593632Z .................................................................................................... 2300/9472
2020-01-04T19:27:21.2598293Z .................................................................................................... 2400/9472
2020-01-04T19:27:27.5541362Z .................................................................................................... 2500/9472
---
2020-01-04T19:30:26.8339235Z ..................i...............i................................................................. 4900/9472
2020-01-04T19:30:36.6910942Z .................................................................................................... 5000/9472
2020-01-04T19:30:42.6218013Z ...............................................................i.................................... 5100/9472
2020-01-04T19:30:50.7353270Z .................................................................................................... 5200/9472
2020-01-04T19:30:58.1670277Z ..............................ii.ii...........i..................................................... 5300/9472
2020-01-04T19:31:07.5486808Z .................................................................................................... 5500/9472
2020-01-04T19:31:17.7571432Z .................................................................................................... 5600/9472
2020-01-04T19:31:24.6444477Z ..............i..................................................................................... 5700/9472
2020-01-04T19:31:30.9163997Z .................................................................................................... 5800/9472
2020-01-04T19:31:30.9163997Z .................................................................................................... 5800/9472
2020-01-04T19:31:42.2144076Z .................................................................................................... 5900/9472
2020-01-04T19:31:53.7537972Z ...ii...i..ii...........i........................................................................... 6000/9472
2020-01-04T19:32:11.1981644Z .................................................................................................... 6200/9472
2020-01-04T19:32:19.0809386Z .................................................................................................... 6300/9472
2020-01-04T19:32:19.0809386Z .................................................................................................... 6300/9472
2020-01-04T19:32:35.7573081Z ..............................i..ii................................................................. 6400/9472
2020-01-04T19:32:56.2471919Z .................................................................................................... 6600/9472
2020-01-04T19:32:58.5024540Z .....i.............................................................................................. 6700/9472
2020-01-04T19:33:00.9161095Z .................................................................................................... 6800/9472
2020-01-04T19:33:03.6088583Z .....i.............................................................................................. 6900/9472
---
2020-01-04T19:34:42.2348975Z .................................................................................................... 7500/9472
2020-01-04T19:34:46.7809241Z .................................................................................................... 7600/9472
2020-01-04T19:34:51.8019473Z .................................................................................................... 7700/9472
2020-01-04T19:35:02.6960777Z .................................................................................................... 7800/9472
2020-01-04T19:35:10.3874467Z ........................................iiii........................................................ 7900/9472
2020-01-04T19:35:25.3036813Z .................................................................................................... 8100/9472
2020-01-04T19:35:33.7831959Z .................................................................................................... 8200/9472
2020-01-04T19:35:47.6211543Z .................................................................................................... 8300/9472
2020-01-04T19:35:55.5583728Z .................................................................................................... 8400/9472
---
2020-01-04T19:38:17.7054991Z  finished in 6.776
2020-01-04T19:38:17.7234275Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-04T19:38:17.9028852Z 
2020-01-04T19:38:17.9029061Z running 166 tests
2020-01-04T19:38:20.9204876Z iiii......i........ii..iiii...i....i...........i............i..i..................i....i............ 100/166
2020-01-04T19:38:23.3034778Z i.i.i...iii..iiiiiii.......................iii............ii......
2020-01-04T19:38:23.3036514Z 
2020-01-04T19:38:23.3038463Z  finished in 5.580
2020-01-04T19:38:23.3227619Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-04T19:38:23.4839487Z 
---
2020-01-04T19:38:25.4551429Z  finished in 2.132
2020-01-04T19:38:25.4736209Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-04T19:38:25.6333336Z 
2020-01-04T19:38:25.6333570Z running 9 tests
2020-01-04T19:38:25.6334337Z iiiiiiiii
2020-01-04T19:38:25.6334722Z 
2020-01-04T19:38:25.6334765Z  finished in 0.159
2020-01-04T19:38:25.6509737Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-04T19:38:25.8335855Z 
---
2020-01-04T19:38:45.7205643Z  finished in 20.069
2020-01-04T19:38:45.7426784Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-04T19:38:45.9251505Z 
2020-01-04T19:38:45.9252055Z running 124 tests
2020-01-04T19:39:10.7122058Z .iiiii..ii.....i..i...i..i.i.i..i..i..iii....ii.ii....ii..........iiii..........i.....i..ii.......ii 100/124
2020-01-04T19:39:14.7957088Z .i.iii.....iiiiii.....ii
2020-01-04T19:39:14.7957679Z 
2020-01-04T19:39:14.7964016Z  finished in 29.053
2020-01-04T19:39:14.7969348Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-04T19:39:14.7972662Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-01-04T19:49:33.5978333Z    Compiling c2-chacha v0.2.2
2020-01-04T19:49:34.2578251Z    Compiling rand_chacha v0.2.1
2020-01-04T19:49:34.4964613Z    Compiling rand v0.7.0
2020-01-04T19:49:37.5966174Z    Compiling alloc v0.0.0 (/checkout/src/liballoc)
2020-01-04T19:49:43.2193956Z error[E0658]: use of unstable library feature 'vec_remove_item': recently added
2020-01-04T19:49:43.2195695Z     |
2020-01-04T19:49:43.2195695Z     |
2020-01-04T19:49:43.2196466Z 137 |     v.remove_item(&1);
2020-01-04T19:49:43.2197442Z     |
2020-01-04T19:49:43.2197442Z     |
2020-01-04T19:49:43.2198081Z     = note: for more information, see ***/issues/40062
2020-01-04T19:49:43.2198598Z     = help: add `#![feature(vec_remove_item)]` to the crate attributes to enable
2020-01-04T19:49:43.2202257Z 
2020-01-04T19:49:43.2239625Z error[E0658]: use of unstable library feature 'vec_remove_item': recently added
2020-01-04T19:49:43.2241530Z     |
2020-01-04T19:49:43.2241530Z     |
2020-01-04T19:49:43.2242126Z 143 |     w.remove_item(&4);
2020-01-04T19:49:43.2243722Z     |
2020-01-04T19:49:43.2243722Z     |
2020-01-04T19:49:43.2244118Z     = note: for more information, see ***/issues/40062
2020-01-04T19:49:43.2244450Z     = help: add `#![feature(vec_remove_item)]` to the crate attributes to enable
2020-01-04T19:49:43.2247926Z 
2020-01-04T19:49:43.2273407Z error[E0658]: use of unstable library feature 'vec_remove_item': recently added
2020-01-04T19:49:43.2274009Z     |
2020-01-04T19:49:43.2274009Z     |
2020-01-04T19:49:43.2274276Z 146 |     w.remove_item(&4);
2020-01-04T19:49:43.2274898Z     |
2020-01-04T19:49:43.2274898Z     |
2020-01-04T19:49:43.2275260Z     = note: for more information, see ***/issues/40062
2020-01-04T19:49:43.2275601Z     = help: add `#![feature(vec_remove_item)]` to the crate attributes to enable
2020-01-04T19:49:44.1568100Z error: aborting due to 3 previous errors
2020-01-04T19:49:44.1568487Z 
2020-01-04T19:49:44.1568975Z For more information about this error, try `rustc --explain E0658`.
2020-01-04T19:49:44.1714914Z error: could not compile `alloc`.
---
2020-01-04T19:49:47.9364703Z   local time: Sat Jan  4 19:49:47 UTC 2020
2020-01-04T19:49:48.0360014Z   network time: Sat, 04 Jan 2020 19:49:48 GMT
2020-01-04T19:49:48.0362534Z == end clock drift check ==
2020-01-04T19:49:49.5290087Z 
2020-01-04T19:49:49.5409243Z ##[error]Bash exited with code '1'.
2020-01-04T19:49:49.5447593Z ##[section]Starting: Checkout
2020-01-04T19:49:49.5450028Z ==============================================================================
2020-01-04T19:49:49.5450093Z Task         : Get sources
2020-01-04T19:49:49.5450136Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Amanieu
Copy link
Member

Amanieu commented Jan 5, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jan 5, 2020

📌 Commit e03d1c4 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 6, 2020
@Dylan-DPC
Rollup merge of rust-lang#67873 - Dylan-DPC:feature/change-remove-to-…
005d9d5 
…partial, r=Amanieu

change remove to have a PartialEq bound

Addresses [comment](rust-lang#67727 (comment)).

References rust-lang#40062

r? @Amanieu
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 6, 2020
Merged
bors added a commit that referenced this pull request Jan 6, 2020
@bors
Auto merge of #67917 - Dylan-DPC:rollup-id05y91, r=Dylan-DPC
a80e63f 
Rollup of 6 pull requests

Successful merges:

 - #67800 (Fix ICE involving calling `Instance.ty` during const evaluation)
 - #67873 (change remove to have a PartialEq bound)
 - #67897 (Use `as_deref()` to replace `as_ref().map(...)`)
 - #67906 (Silence `TooGeneric` error)
 - #67912 (macros: typo fix)
 - #67915 (Use Self instead of $type)

Failed merges:

r? @ghost
@bors bors merged commit e03d1c4 into rust-lang:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Dylan-DPC-zz @rust-highfive @Amanieu @bors @Dylan-DPC