Cleanup formatting code #67795

Mark-Simulacrum · 2020-01-02T01:59:07Z

This removes a few leftover positional enum variants that were no longer used.

All details that are changed are unstable (and #[doc(hidden)]), so this should
not impact downstream code.

rust-highfive · 2020-01-02T01:59:10Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2020-01-02T03:13:06Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-02T01:59:42.0631927Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-02T01:59:42.0845512Z ##[command]git config gc.auto 0
2020-01-02T01:59:42.0904100Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-02T01:59:42.0961654Z ##[command]git config --get-all http.proxy
2020-01-02T01:59:42.1118549Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67795/merge:refs/remotes/pull/67795/merge
---
2020-01-02T03:01:33.0907056Z .................................................................................................... 1500/9468
2020-01-02T03:01:38.9258258Z .................................................................................................... 1600/9468
2020-01-02T03:01:44.0078936Z .................................................................................................... 1700/9468
2020-01-02T03:01:53.3979291Z .................................................................................................... 1800/9468
2020-01-02T03:02:01.5778217Z .i.................................................................................................. 1900/9468
2020-01-02T03:02:08.2827269Z .......................................................................................iiiii........ 2000/9468
2020-01-02T03:02:30.2380006Z .................................................................................................... 2200/9468
2020-01-02T03:02:32.6297092Z .................................................................................................... 2300/9468
2020-01-02T03:02:35.1313273Z .................................................................................................... 2400/9468
2020-01-02T03:02:41.4866882Z .................................................................................................... 2500/9468
---
2020-01-02T03:05:41.1955241Z ..................i...............i................................................................. 4900/9468
2020-01-02T03:05:50.9250414Z .................................................................................................... 5000/9468
2020-01-02T03:05:56.5022807Z ...............................................................i.................................... 5100/9468
2020-01-02T03:06:04.7100095Z .................................................................................................... 5200/9468
2020-01-02T03:06:12.1047677Z ..............................ii.ii...........i..................................................... 5300/9468
2020-01-02T03:06:21.4614903Z .................................................................................................... 5500/9468
2020-01-02T03:06:31.7083055Z .................................................................................................... 5600/9468
2020-01-02T03:06:38.6485851Z .............i...................................................................................... 5700/9468
2020-01-02T03:06:44.7909093Z .................................................................................................... 5800/9468
2020-01-02T03:06:44.7909093Z .................................................................................................... 5800/9468
2020-01-02T03:06:55.5877759Z .................................................................................................... 5900/9468
2020-01-02T03:07:07.3682908Z .ii...i..ii...........i............................................................................. 6000/9468
2020-01-02T03:07:25.2393534Z .................................................................................................... 6200/9468
2020-01-02T03:07:30.4876708Z .................................................................................................... 6300/9468
2020-01-02T03:07:30.4876708Z .................................................................................................... 6300/9468
2020-01-02T03:07:43.8141685Z ............................i..ii................................................................... 6400/9468
2020-01-02T03:08:03.9998691Z .................................................................................................... 6600/9468
2020-01-02T03:08:06.8759067Z ...i................................................................................................ 6700/9468
2020-01-02T03:08:08.5069931Z .................................................................................................... 6800/9468
2020-01-02T03:08:11.1136334Z ...i................................................................................................ 6900/9468
---
2020-01-02T03:09:50.2620231Z .................................................................................................... 7500/9468
2020-01-02T03:09:55.1872762Z .................................................................................................... 7600/9468
2020-01-02T03:10:00.7332311Z .................................................................................................... 7700/9468
2020-01-02T03:10:10.9116001Z .................................................................................................... 7800/9468
2020-01-02T03:10:18.4973745Z .....................................iiii........................................................... 7900/9468
2020-01-02T03:10:33.2954499Z .................................................................................................... 8100/9468
2020-01-02T03:10:41.9447549Z .................................................................................................... 8200/9468
2020-01-02T03:10:56.1415487Z .................................................................................................... 8300/9468
2020-01-02T03:11:04.0019015Z .................................................................................................... 8400/9468
---
2020-01-02T03:12:59.3218507Z 64 
2020-01-02T03:12:59.3219954Z - error: future cannot be sent between threads safely
2020-01-02T03:12:59.3220583Z -   --> $DIR/async-fn-nonsend.rs:54:5
2020-01-02T03:12:59.3221035Z -    |
2020-01-02T03:12:59.3221496Z - LL | fn assert_send(_: impl Send) {}
2020-01-02T03:12:59.3222472Z - ...
2020-01-02T03:12:59.3222472Z - ...
2020-01-02T03:12:59.3222927Z - LL |     assert_send(non_sync_with_method_call());
2020-01-02T03:12:59.3223426Z -    |     ^^^^^^^^^^^ future returned by `non_sync_with_method_call` is not `Send`
2020-01-02T03:12:59.3223828Z -    |
2020-01-02T03:12:59.3224432Z -    = help: within `std::fmt::ArgumentV1<'_>`, the trait `std::marker::Sync` is not implemented for `*mut (dyn std::ops::Fn() + 'static)`
2020-01-02T03:12:59.3224912Z - note: future is not `Send` as this value is used across an await
2020-01-02T03:12:59.3225784Z -    |
2020-01-02T03:12:59.3226219Z - LL |     let f: &mut std::fmt::Formatter = panic!();
2020-01-02T03:12:59.3227211Z -    |         - has type `&mut std::fmt::Formatter<'_>`
2020-01-02T03:12:59.3227211Z -    |         - has type `&mut std::fmt::Formatter<'_>`
2020-01-02T03:12:59.3227716Z - LL |     if non_sync().fmt(f).unwrap() == () {
2020-01-02T03:12:59.3228143Z - LL |         fut().await;
2020-01-02T03:12:59.3229033Z -    |         ^^^^^^^^^^^ await occurs here, with `f` maybe used later
2020-01-02T03:12:59.3229459Z - LL |     }
2020-01-02T03:12:59.3229884Z - LL | }
2020-01-02T03:12:59.3230344Z -    | - `f` is later dropped here
2020-01-02T03:12:59.3231178Z - error: aborting due to 4 previous errors
2020-01-02T03:12:59.3231385Z + error: aborting due to 3 previous errors
2020-01-02T03:12:59.3231561Z 88 
2020-01-02T03:12:59.3231708Z 89 
2020-01-02T03:12:59.3231708Z 89 
2020-01-02T03:12:59.3231840Z 
2020-01-02T03:12:59.3231971Z 
2020-01-02T03:12:59.3232732Z The actual stderr differed from the expected stderr.
2020-01-02T03:12:59.3233389Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/async-fn-nonsend/async-fn-nonsend.stderr
2020-01-02T03:12:59.3234210Z To update references, rerun the tests and pass the `--bless` flag
2020-01-02T03:12:59.3234767Z To only update this specific test, also pass `--test-args async-await/async-fn-nonsend.rs`
2020-01-02T03:12:59.3235295Z error: 1 errors occurred comparing output.
2020-01-02T03:12:59.3235535Z status: exit code: 1
2020-01-02T03:12:59.3235535Z status: exit code: 1
2020-01-02T03:12:59.3236797Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/async-await/async-fn-nonsend.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/async-fn-nonsend" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "--crate-type" "lib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/async-fn-nonsend/auxiliary" "-A" "unused"
2020-01-02T03:12:59.3237555Z ------------------------------------------
2020-01-02T03:12:59.3237765Z 
2020-01-02T03:12:59.3238206Z ------------------------------------------
2020-01-02T03:12:59.3238813Z stderr:
2020-01-02T03:12:59.3238813Z stderr:
2020-01-02T03:12:59.3239303Z ------------------------------------------
2020-01-02T03:12:59.3239517Z error: future cannot be sent between threads safely
2020-01-02T03:12:59.3239980Z   --> /checkout/src/test/ui/async-await/async-fn-nonsend.rs:50:5
2020-01-02T03:12:59.3240188Z    |
2020-01-02T03:12:59.3240373Z LL | fn assert_send(_: impl Send) {}
2020-01-02T03:12:59.3241014Z ...
2020-01-02T03:12:59.3241014Z ...
2020-01-02T03:12:59.3241198Z LL |     assert_send(local_dropped_before_await());
2020-01-02T03:12:59.3241359Z    |     ^^^^^^^^^^^ future returned by `local_dropped_before_await` is not `Send`
2020-01-02T03:12:59.3241714Z    = help: within `impl std::future::Future`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`
2020-01-02T03:12:59.3241923Z note: future is not `Send` as this value is used across an await
2020-01-02T03:12:59.3242382Z   --> /checkout/src/test/ui/async-await/async-fn-nonsend.rs:25:5
2020-01-02T03:12:59.3242588Z    |
2020-01-02T03:12:59.3242588Z    |
2020-01-02T03:12:59.3242742Z LL |     let x = non_send();
2020-01-02T03:12:59.3243173Z    |         - has type `impl std::fmt::Debug`
2020-01-02T03:12:59.3243372Z LL |     drop(x);
2020-01-02T03:12:59.3243549Z LL |     fut().await;
2020-01-02T03:12:59.3243864Z LL | }
2020-01-02T03:12:59.3244246Z    | - `x` is later dropped here
2020-01-02T03:12:59.3244450Z 
2020-01-02T03:12:59.3244609Z error: future cannot be sent between threads safely
2020-01-02T03:12:59.3244609Z error: future cannot be sent between threads safely
2020-01-02T03:12:59.3245076Z   --> /checkout/src/test/ui/async-await/async-fn-nonsend.rs:52:5
2020-01-02T03:12:59.3245276Z    |
2020-01-02T03:12:59.3245427Z LL | fn assert_send(_: impl Send) {}
2020-01-02T03:12:59.3246075Z ...
2020-01-02T03:12:59.3246075Z ...
2020-01-02T03:12:59.3246259Z LL |     assert_send(non_send_temporary_in_match());
2020-01-02T03:12:59.3246425Z    |     ^^^^^^^^^^^ future returned by `non_send_temporary_in_match` is not `Send`
2020-01-02T03:12:59.3246748Z    = help: within `impl std::future::Future`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`
2020-01-02T03:12:59.3246938Z note: future is not `Send` as this value is used across an await
2020-01-02T03:12:59.3247378Z   --> /checkout/src/test/ui/async-await/async-fn-nonsend.rs:34:20
2020-01-02T03:12:59.3247573Z    |
2020-01-02T03:12:59.3247573Z    |
2020-01-02T03:12:59.3247749Z LL |     match Some(non_send()) {
2020-01-02T03:12:59.3248546Z    |                ---------- has type `impl std::fmt::Debug`
2020-01-02T03:12:59.3248975Z LL |         Some(_) => fut().await,
2020-01-02T03:12:59.3249443Z ...
2020-01-02T03:12:59.3249592Z LL | }
2020-01-02T03:12:59.3250178Z    | - `non_send()` is later dropped here
2020-01-02T03:12:59.3250397Z 
2020-01-02T03:12:59.3250397Z 
2020-01-02T03:12:59.3250585Z error: future cannot be sent between threads safely
2020-01-02T03:12:59.3251040Z   --> /checkout/src/test/ui/async-await/async-fn-nonsend.rs:54:5
2020-01-02T03:12:59.3251245Z    |
2020-01-02T03:12:59.3251398Z LL | fn assert_send(_: impl Send) {}
2020-01-02T03:12:59.3252064Z ...
2020-01-02T03:12:59.3252242Z LL |     assert_send(non_sync_with_method_call());
2020-01-02T03:12:59.3252242Z LL |     assert_send(non_sync_with_method_call());
2020-01-02T03:12:59.3252401Z    |     ^^^^^^^^^^^ future returned by `non_sync_with_method_call` is not `Send`
2020-01-02T03:12:59.3252752Z    = help: the trait `std::marker::Send` is not implemented for `dyn std::fmt::Write`
2020-01-02T03:12:59.3252914Z note: future is not `Send` as this value is used across an await
2020-01-02T03:12:59.3253378Z   --> /checkout/src/test/ui/async-await/async-fn-nonsend.rs:43:9
2020-01-02T03:12:59.3253576Z    |
2020-01-02T03:12:59.3253576Z    |
2020-01-02T03:12:59.3253740Z LL |     let f: &mut std::fmt::Formatter = panic!();
2020-01-02T03:12:59.3254159Z    |         - has type `&mut std::fmt::Formatter<'_>`
2020-01-02T03:12:59.3254385Z LL |     if non_sync().fmt(f).unwrap() == () {
2020-01-02T03:12:59.3254560Z LL |         fut().await;
2020-01-02T03:12:59.3254722Z    |         ^^^^^^^^^^^ await occurs here, with `f` maybe used later
2020-01-02T03:12:59.3255018Z LL | }
2020-01-02T03:12:59.3255427Z    | - `f` is later dropped here
2020-01-02T03:12:59.3255603Z 
2020-01-02T03:12:59.3255758Z error: aborting due to 3 previous errors
---
2020-01-02T03:12:59.3281357Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2020-01-02T03:12:59.3281778Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-02T03:12:59.3315690Z 
2020-01-02T03:12:59.3315779Z 
2020-01-02T03:12:59.3320175Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-02T03:12:59.3320699Z 
2020-01-02T03:12:59.3320751Z 
2020-01-02T03:12:59.3320838Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-02T03:12:59.3320981Z Build completed unsuccessfully in 1:05:50
2020-01-02T03:12:59.3320981Z Build completed unsuccessfully in 1:05:50
2020-01-02T03:12:59.3373318Z == clock drift check ==
2020-01-02T03:12:59.3399245Z   local time: Thu Jan  2 03:12:59 UTC 2020
2020-01-02T03:12:59.6318262Z   network time: Thu, 02 Jan 2020 03:12:59 GMT
2020-01-02T03:12:59.6321347Z == end clock drift check ==
2020-01-02T03:13:00.5954281Z 
2020-01-02T03:13:00.6065918Z ##[error]Bash exited with code '1'.
2020-01-02T03:13:00.6104985Z ##[section]Starting: Checkout
2020-01-02T03:13:00.6107668Z ==============================================================================
2020-01-02T03:13:00.6107753Z Task         : Get sources
2020-01-02T03:13:00.6107825Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum · 2020-01-02T15:00:38Z

Test failure here looks expected -- it looks like fmt::Formatter is now Send (and maybe Sync?). I'm not sure if it makes sense to drop that requirement by adding in a PhantomData or not.

Mark-Simulacrum · 2020-01-19T03:43:48Z

(This is indeed waiting for review; we need to decide whether the test failure is acceptable. I think it is).

@Amanieu also redirected a different formatting-related PR to @dtolnay, so r? @dtolnay on this one as well.

dtolnay

The code change looks good to me. Thanks! This is great.

Regarding the test failure -- the expected failure that is no longer failing is:

rust/src/test/ui/async-await/async-fn-nonsend.rs

Lines 39 to 45 in 6250d56

    
           async fn non_sync_with_method_call() { 
        
               // FIXME: it'd be nice for this to work. 
        
               let f: &mut std::fmt::Formatter = panic!(); 
        
               if non_sync().fmt(f).unwrap() == () { 
        
                   fut().await; 
        
               } 
        
           }

I don't think your assessment that fmt::Formatter is now Send and maybe Sync is accurate, since it still contains a &mut dyn Write which is neither; https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=e02471e6cddb6a31241f2089e714a8da. Could you dig a bit deeper to find out what change in this PR is affecting the test? I would prefer not to have an autotrait impl appear unintentionally that we might have trouble preserving down the line.

If the same error from the test case just got bumped to a later "phase" of errors from rustc for some reason, then that's fine and we can move forward.

Mark-Simulacrum · 2020-01-20T16:25:38Z

I will try to bisect or something like that (at least run the test locally and play around with it). I agree with your assessment that Send/Sync should not have been affected due to the continued presence of &mut dyn Write.

The formatting infrastructure stopped emitting these a while back, and in removing them we can simplify related code.

These are only called from one place and don't generally support being called from other places; furthermore, they're the only formatter functions that look at the `args` field (which a future commit will remove).

These are no longer used by Formatter methods.

fmt::Formatter is still not Send/Sync, but the UI test emitted two errors, for the dyn Write and the Void inside Formatter. As of this PR, the Void is now gone, but the dyn Write remains.

Mark-Simulacrum · 2020-01-20T17:20:18Z

Pushed up one more commit (as well as rebasing, though there were no conflicts) which fixes the test in question. Turns out there was just a "duplicate" error (both for Void and the dyn Write), with the first of those being gone.

This is ready for review again (I'm not sure if you meant to say r=me in your comment). r? @dtolnay

dtolnay · 2020-01-20T21:51:34Z

Nice, I'm glad it turned out to be something simple. @Mark-Simulacrum it could be worth adding impl !Send for Formatter so that user-facing error messages stop referring to its internals.

@bors r+

bors · 2020-01-20T21:51:36Z

📌 Commit a804a45 has been approved by dtolnay

Mark-Simulacrum · 2020-01-20T21:53:11Z

(I wonder if it makes sense to change the async/await error messages to not "look into" external types by default -- I think there are cases where you'd want to, but generally speaking it seems like "Formatter is not Send" would be a better error message than "dyn Write is not Send".)

…lnay Cleanup formatting code This removes a few leftover positional enum variants that were no longer used. All details that are changed are unstable (and `#[doc(hidden)]`), so this should not impact downstream code.

@ghost

Rollup of 8 pull requests Successful merges: - #67734 (Remove appendix from Apache license) - #67795 (Cleanup formatting code) - #68290 (Fix some tests failing in `--pass check` mode) - #68297 ( Filter and test predicates using `normalize_and_test_predicates` for const-prop) - #68302 (Fix #[track_caller] and function pointers) - #68339 (Add `riscv64gc-unknown-linux-gnu` into target list in build-manifest) - #68381 (Added minor clarification to specification of GlobalAlloc::realloc.) - #68397 (rustdoc: Correct order of `async` and `unsafe` in `async unsafe fn`s) Failed merges: r? @ghost

bors · 2020-01-21T03:06:23Z

⌛ Testing commit a804a45 with merge 06b9450...

rust-highfive assigned withoutboats Jan 2, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2020

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2020

Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2020

rust-highfive assigned dtolnay and unassigned withoutboats Jan 19, 2020

dtolnay reviewed Jan 19, 2020

View reviewed changes

Mark-Simulacrum added 4 commits January 20, 2020 11:57

Delete unused "next" variants from formatting infrastructure

fdef4f1

The formatting infrastructure stopped emitting these a while back, and in removing them we can simplify related code.

Move run/getcount to functions

4919b96

These are only called from one place and don't generally support being called from other places; furthermore, they're the only formatter functions that look at the `args` field (which a future commit will remove).

Drop args from Formatter

9ae32c9

These are no longer used by Formatter methods.

Fix UI test

a804a45

fmt::Formatter is still not Send/Sync, but the UI test emitted two errors, for the dyn Write and the Void inside Formatter. As of this PR, the Void is now gone, but the dyn Write remains.

Mark-Simulacrum force-pushed the fmt-argument branch from 8de4b81 to a804a45 Compare January 20, 2020 17:19

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2020

JohnTitor mentioned this pull request Jan 20, 2020

Rollup of 8 pull requests #68405

Merged

bors merged commit a804a45 into rust-lang:master Jan 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup formatting code #67795

Cleanup formatting code #67795

Mark-Simulacrum commented Jan 2, 2020

rust-highfive commented Jan 2, 2020

rust-highfive commented Jan 2, 2020

Mark-Simulacrum commented Jan 2, 2020

Mark-Simulacrum commented Jan 19, 2020

dtolnay left a comment

Mark-Simulacrum commented Jan 20, 2020

Mark-Simulacrum commented Jan 20, 2020

dtolnay commented Jan 20, 2020

bors commented Jan 20, 2020

Mark-Simulacrum commented Jan 20, 2020

bors commented Jan 21, 2020

	async fn non_sync_with_method_call() {
	// FIXME: it'd be nice for this to work.
	let f: &mut std::fmt::Formatter = panic!();
	if non_sync().fmt(f).unwrap() == () {
	fut().await;
	}
	}

Cleanup formatting code #67795

Cleanup formatting code #67795

Conversation

Mark-Simulacrum commented Jan 2, 2020

rust-highfive commented Jan 2, 2020

rust-highfive commented Jan 2, 2020

Mark-Simulacrum commented Jan 2, 2020

Mark-Simulacrum commented Jan 19, 2020

dtolnay left a comment

Choose a reason for hiding this comment

Mark-Simulacrum commented Jan 20, 2020

Mark-Simulacrum commented Jan 20, 2020

dtolnay commented Jan 20, 2020

bors commented Jan 20, 2020

Mark-Simulacrum commented Jan 20, 2020

bors commented Jan 21, 2020