Constify Result #67685
Merged
Constify Result #67685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
So... while this is very const eval related, it's also T-libs. I'm not sure how to take these PRs. @rust-lang/libs are you ok with me r+ing PRs that make functions Some of these even use features that prevent the |
|
@oli-obk, yes I think you should feel free to r+ PRs that add unstable constness to the standard library. |
|
ok cool, thx @bors r+ |
|
📌 Commit ccaad2e5bce79a87178d5b8ba442bc666f99cc65 has been approved by |
bors
added
S-waiting-on-bors
lukaslueg
force-pushed
the
const_result
branch
from
ccaad2e to
a145b80
Compare
|
huh? Why did you force push? |
|
also ccing #67520 here so the issue knows about this PR |
|
Sorry, post coming late. Tidy fixes
Oliver Scherer <notifications@github.com> schrieb am So., 29. Dez. 2019,
15:35:
… also ccing #67520 <#67520> here
so the issue knows about this PR
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#67685?email_source=notifications&email_token=AAYAXIFUDSALYYZ6QR3NS73Q3CYUDA5CNFSM4KAR3H6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZAZZA#issuecomment-569511140>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYAXIE4KISCKA272VHBT2DQ3CYUDANCNFSM4KAR3H6A>
.
|
|
@bors r+ |
|
📌 Commit a145b80 has been approved by |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 31, 2019
Constify Result r? @oli-obk This is just the `Result`-part of rust-lang#67494 which I'll resubmit once rust-lang#66254 has landed.
bors
added
S-waiting-on-author
lukaslueg
force-pushed
the
const_result
branch
from
a145b80 to
954c432
Compare
|
rebased |
|
@bors r=oli-obk |
|
📌 Commit 954c432 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 31, 2019
Constify Result r? @oli-obk This is just the `Result`-part of rust-lang#67494 which I'll resubmit once rust-lang#66254 has landed.
bors
added a commit
that referenced
this pull request
Dec 31, 2019
Rollup of 6 pull requests Successful merges: - #67574 (Extract `rustc_ast_lowering` crate from `rustc`) - #67685 (Constify Result) - #67702 (Add symbol normalization for proc_macro_server.) - #67730 (Cleanup pattern type checking, fix diagnostics bugs (+ improvements)) - #67744 (parser: reduce diversity in error handling mechanisms) - #67748 (Use function attribute "frame-pointer" instead of "no-frame-pointer-elim") Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk
This is just the
Result-part of #67494 which I'll resubmit once #66254 has landed.