Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer regions for opaque types in borrowck #67681

Merged
merged 25 commits into from
Feb 15, 2020
Merged

Infer regions for opaque types in borrowck #67681

merged 25 commits into from
Feb 15, 2020

Commits on Feb 14, 2020

  1. Explain a test

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    033bd8c View commit details
    Browse the repository at this point in the history

  2. Check associated opaque types don't use unconstrained lifetimes

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    7f41cf4 View commit details
    Browse the repository at this point in the history

  3. Call is_freeze less in unsafety-checking 

    This is to avoid cycles when calling `is_freeze` on an opaque type.
    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    4af0952 View commit details
    Browse the repository at this point in the history

  4. Distinguish RPIT from other impl trait

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    60970be View commit details
    Browse the repository at this point in the history

  5. Give some more queries descriptions

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    43dae91 View commit details
    Browse the repository at this point in the history

  6. Simplify function signature in opaque_types

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    9664122 View commit details
    Browse the repository at this point in the history

  7. Generate more accurate MIR in construct_error

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    378b5b4 View commit details
    Browse the repository at this point in the history

  8. Arena allocate the result of mir_borrowck

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    43a3348 View commit details
    Browse the repository at this point in the history

  9. Prepare to use borrowck to resolve opaque types

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    75ac0cc View commit details
    Browse the repository at this point in the history

  10. Infer opaque type regions in borrow checking 

    We want type checking for function bodies to ignore/erase regions. As
such, we need to infer the regions in opaque types in borrow check
instead.
    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    d9b9f00 View commit details
    Browse the repository at this point in the history

  11. Avoid unnecessary opaque type errors in borrowck

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    edee23e View commit details
    Browse the repository at this point in the history

  12. Ensure RPIT types get recorded in borrowck

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    2fb0254 View commit details
    Browse the repository at this point in the history

  13. Erase regions in opaque types in typeck

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    bb8c991 View commit details
    Browse the repository at this point in the history

  14. Update tests

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    93ac5bc View commit details
    Browse the repository at this point in the history

  15. Address review comments

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    f23bca7 View commit details
    Browse the repository at this point in the history

  16. Show inferred opaque types with #[rustc_regions]

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    728224d View commit details
    Browse the repository at this point in the history

  17. Handle equal regions in opaque type inference

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    5cfa7d1 View commit details
    Browse the repository at this point in the history

  18. Improve opaque type lifetime errors 

    * Use better span for member constraint errors
* Avoid a bad suggestion
* Don't report member constraint errors if we have other universal
  region errors.
    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    2bd16f3 View commit details
    Browse the repository at this point in the history

  19. Always check upper bounds when choosing member regions 

    Also correctly calculate what the upper bounds are.
    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    dd1687e View commit details
    Browse the repository at this point in the history

  20. Use member constraint for most opaque types in NLL 

    This ensures that NLL will infer suitable values for regions in opaque
types when it's possible.
    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    e3e5d27 View commit details
    Browse the repository at this point in the history

  21. Update tests

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    78e0ab5 View commit details
    Browse the repository at this point in the history

  22. Fix and test nested impl Trait

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    6d9e270 View commit details
    Browse the repository at this point in the history

  23. Add fast path to eq_opaque_type_and_type

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    223a2ee View commit details
    Browse the repository at this point in the history

  24. Split type_of out of collect.rs

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    edddb62 View commit details
    Browse the repository at this point in the history

  25. Fix tests after rebase

    @matthewjasper
    matthewjasper committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    d863978 View commit details
    Browse the repository at this point in the history