Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mem::uninitalized from tests #67507

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Remove mem::uninitalized from tests #67507

merged 1 commit into from
Dec 23, 2019

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Dec 22, 2019 •
edited
Loading

This purges uses of uninitialized where possible from test cases. Some
are merely moved over to the equally bad pattern of
MaybeUninit::uninit().assume_init() but with an annotation that this is
"the best we can do".

Fixes #62397

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 22, 2019
@Mark-Simulacrum
Copy link
Member Author

cc @RalfJung

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Dec 22, 2019
Closed
6 tasks
@Centril
Copy link
Contributor

Centril commented Dec 22, 2019

r? @RalfJung

@rust-highfive rust-highfive assigned RalfJung and unassigned Centril Dec 22, 2019
@Mark-Simulacrum
Copy link
Member Author

I would personally prefer that we don't block on @RalfJung here, given that this is a relatively simple replacement operation, and they don't have much review time. I personally think you are likely knowledgeable enough to at least do a review before saying "these bits I'm not sure about" if such bits exist? If that's an incorrect impression though I'm fine with waiting (or trying to find another reviewer).

@RalfJung
Copy link
Member

Yeah I feel like I am drowning in requests for review and other requests for comments, leaving less than 0 time for my own Rust projects, which is quite the motivation killer. I need some way to reduce that incoming flood.^^

@Mark-Simulacrum Mark-Simulacrum force-pushed the purge-uninit branch 4 times, most recently from 10205cd to 28a1319 Compare December 22, 2019 13:05
Centril
Centril reviewed Dec 22, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with these comments below addressed :)

src/test/ui/issues/issue-58212.rs Outdated Show resolved Hide resolved
src/test/ui/uninhabited/uninhabited-matches-feature-gated.rs Outdated Show resolved Hide resolved
src/test/ui/uninhabited/uninhabited-matches-feature-gated.rs Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Dec 22, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned RalfJung Dec 22, 2019
@Mark-Simulacrum
Copy link
Member Author

@bors r=Centril

Thanks!

@bors
Copy link
Contributor

bors commented Dec 22, 2019

📌 Commit cb599cc has been approved by Centril

@bors
Copy link
Contributor

bors commented Dec 22, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 22, 2019
@Centril
Rollup merge of rust-lang#67507 - Mark-Simulacrum:purge-uninit, r=Cen…
dd1f3ca 
…tril

Remove mem::uninitalized from tests

This purges uses of uninitialized where possible from test cases. Some
are merely moved over to the equally bad pattern of
MaybeUninit::uninit().assume_init() but with an annotation that this is
"the best we can do".

Fixes rust-lang#67507
@Centril Centril mentioned this pull request Dec 22, 2019
Closed
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-12-22T13:10:58.5095431Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-22T13:10:59.1332505Z ##[command]git config gc.auto 0
2019-12-22T13:10:59.1338786Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-22T13:10:59.1344259Z ##[command]git config --get-all http.proxy
2019-12-22T13:10:59.1348368Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67507/merge:refs/remotes/pull/67507/merge
---
2019-12-22T14:05:07.6377841Z .................................................................................................... 1600/9427
2019-12-22T14:05:11.8293329Z .................................................................................................... 1700/9427
2019-12-22T14:05:21.2224361Z .....................................................................................i.............. 1800/9427
2019-12-22T14:05:28.0807060Z .................................................................................................... 1900/9427
2019-12-22T14:05:34.4542036Z ......................................................................iiiii......................... 2000/9427
2019-12-22T14:05:53.1772398Z .................................................................................................... 2200/9427
2019-12-22T14:05:55.3279458Z .................................................................................................... 2300/9427
2019-12-22T14:05:57.6987817Z .................................................................................................... 2400/9427
2019-12-22T14:06:09.6616360Z .................................................................................................... 2500/9427
---
2019-12-22T14:08:42.7506178Z .i...............i.................................................................................. 4900/9427
2019-12-22T14:08:51.6959511Z .................................................................................................... 5000/9427
2019-12-22T14:08:56.0263559Z .............................................i...................................................... 5100/9427
2019-12-22T14:09:04.6994738Z .................................................................................................... 5200/9427
2019-12-22T14:09:09.9370063Z ............ii.ii...........i....................................................................... 5300/9427
2019-12-22T14:09:17.9795418Z .................................................................................................... 5500/9427
2019-12-22T14:09:28.4849282Z ..............................................................................................i..... 5600/9427
2019-12-22T14:09:35.6756303Z .................................................................................................... 5700/9427
2019-12-22T14:09:40.2471499Z .................................................................................................... 5800/9427
2019-12-22T14:09:40.2471499Z .................................................................................................... 5800/9427
2019-12-22T14:09:49.0780015Z ..................................................................................ii...i..ii........ 5900/9427
2019-12-22T14:10:09.6859328Z .................................................................................................... 6100/9427
2019-12-22T14:10:16.4583581Z .................................................................................................... 6200/9427
2019-12-22T14:10:23.5218369Z .................................................................................................... 6300/9427
2019-12-22T14:10:23.5218369Z .................................................................................................... 6300/9427
2019-12-22T14:10:38.7214290Z .........i..ii...................................................................................... 6400/9427
2019-12-22T14:10:56.1255439Z .....................................................................................i.............. 6600/9427
2019-12-22T14:10:57.9834345Z .................................................................................................... 6700/9427
2019-12-22T14:10:59.9150189Z .....................................................................................i.............. 6800/9427
2019-12-22T14:11:02.3660994Z .................................................................................................... 6900/9427
---
2019-12-22T14:15:18.0678707Z diff of stderr:
2019-12-22T14:15:18.0679097Z 
2019-12-22T14:15:18.0679345Z 7    = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
2019-12-22T14:15:18.0679577Z 8 
2019-12-22T14:15:18.0680096Z 9 error[E0004]: non-exhaustive patterns: type `&Void` is non-empty
2019-12-22T14:15:18.0681503Z +   --> $DIR/uninhabited-matches-feature-gated.rs:16:19
2019-12-22T14:15:18.0681793Z 11    |
2019-12-22T14:15:18.0682705Z 12 LL | enum Void {}
2019-12-22T14:15:18.0682705Z 12 LL | enum Void {}
2019-12-22T14:15:18.0683262Z 13    | ------------ `Void` defined here
2019-12-22T14:15:18.0683794Z 18    = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
2019-12-22T14:15:18.0684053Z 19 
2019-12-22T14:15:18.0684053Z 19 
2019-12-22T14:15:18.0684580Z 20 error[E0004]: non-exhaustive patterns: type `(Void,)` is non-empty
2019-12-22T14:15:18.0685734Z +   --> $DIR/uninhabited-matches-feature-gated.rs:19:19
2019-12-22T14:15:18.0686026Z 22    |
2019-12-22T14:15:18.0686263Z 23 LL |     let _ = match x {};
2019-12-22T14:15:18.0686663Z 24    |                   ^
2019-12-22T14:15:18.0686663Z 24    |                   ^
2019-12-22T14:15:18.0686891Z 
2019-12-22T14:15:18.0687273Z 26    = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
2019-12-22T14:15:18.0687687Z 27 
2019-12-22T14:15:18.0688502Z 28 error[E0004]: non-exhaustive patterns: type `[Void; 1]` is non-empty
2019-12-22T14:15:18.0689566Z +   --> $DIR/uninhabited-matches-feature-gated.rs:22:19
2019-12-22T14:15:18.0689837Z 30    |
2019-12-22T14:15:18.0690057Z 31 LL |     let _ = match x {};
2019-12-22T14:15:18.0690258Z 32    |                   ^
2019-12-22T14:15:18.0690258Z 32    |                   ^
2019-12-22T14:15:18.0690432Z 
2019-12-22T14:15:18.0690659Z 34    = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
2019-12-22T14:15:18.0690861Z 35 
2019-12-22T14:15:18.0691489Z 36 error[E0004]: non-exhaustive patterns: `&[_, ..]` not covered
2019-12-22T14:15:18.0694732Z +   --> $DIR/uninhabited-matches-feature-gated.rs:25:19
2019-12-22T14:15:18.0695098Z 38    |
2019-12-22T14:15:18.0695360Z 39 LL |     let _ = match x {
2019-12-22T14:15:18.0695360Z 39 LL |     let _ = match x {
2019-12-22T14:15:18.0695741Z 40    |                   ^ pattern `&[_, ..]` not covered
2019-12-22T14:15:18.0697500Z 42    = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
2019-12-22T14:15:18.0697693Z 43 
2019-12-22T14:15:18.0698190Z 44 error[E0004]: non-exhaustive patterns: `Err(_)` not covered
2019-12-22T14:15:18.0698692Z -   --> $DIR/uninhabited-matches-feature-gated.rs:32:19
---
2019-12-22T14:15:18.0703720Z 56    |         ^^^^^ pattern `Err(_)` not covered
2019-12-22T14:15:18.0703864Z 
2019-12-22T14:15:18.0703991Z 
2019-12-22T14:15:18.0704164Z The actual stderr differed from the expected stderr.
2019-12-22T14:15:18.0704766Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/uninhabited/uninhabited-matches-feature-gated/uninhabited-matches-feature-gated.stderr
2019-12-22T14:15:18.0705278Z To update references, rerun the tests and pass the `--bless` flag
2019-12-22T14:15:18.0705906Z To only update this specific test, also pass `--test-args uninhabited/uninhabited-matches-feature-gated.rs`
2019-12-22T14:15:18.0706392Z error: 1 errors occurred comparing output.
2019-12-22T14:15:18.0706513Z status: exit code: 1
2019-12-22T14:15:18.0706513Z status: exit code: 1
2019-12-22T14:15:18.0707670Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/uninhabited/uninhabited-matches-feature-gated.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/uninhabited/uninhabited-matches-feature-gated" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/uninhabited/uninhabited-matches-feature-gated/auxiliary" "-A" "unused"
2019-12-22T14:15:18.0708252Z ------------------------------------------
2019-12-22T14:15:18.0708414Z 
2019-12-22T14:15:18.0708748Z ------------------------------------------
2019-12-22T14:15:18.0709086Z stderr:
---
2019-12-22T14:15:18.0710884Z    |                   ^ pattern `Err(_)` not covered
2019-12-22T14:15:18.0711006Z    |
2019-12-22T14:15:18.0711309Z    = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
2019-12-22T14:15:18.0711574Z 
2019-12-22T14:15:18.0713980Z error[E0004]: non-exhaustive patterns: type `&Void` is non-empty
2019-12-22T14:15:18.0715158Z    |
2019-12-22T14:15:18.0715309Z LL | enum Void {}
2019-12-22T14:15:18.0715309Z LL | enum Void {}
2019-12-22T14:15:18.0715873Z    | ------------ `Void` defined here
2019-12-22T14:15:18.0716029Z ...
2019-12-22T14:15:18.0716361Z LL |     let _ = match x {}; //~ ERROR non-exhaustive
2019-12-22T14:15:18.0716631Z    |
2019-12-22T14:15:18.0716772Z    = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
2019-12-22T14:15:18.0716878Z 
2019-12-22T14:15:18.0716878Z 
2019-12-22T14:15:18.0717202Z error[E0004]: non-exhaustive patterns: type `(Void,)` is non-empty
2019-12-22T14:15:18.0717750Z    |
2019-12-22T14:15:18.0717750Z    |
2019-12-22T14:15:18.0718057Z LL |     let _ = match x {}; //~ ERROR non-exhaustive
2019-12-22T14:15:18.0718519Z    |
2019-12-22T14:15:18.0718641Z    = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
2019-12-22T14:15:18.0718774Z 
2019-12-22T14:15:18.0718774Z 
2019-12-22T14:15:18.0719779Z error[E0004]: non-exhaustive patterns: type `[Void; 1]` is non-empty
2019-12-22T14:15:18.0720417Z    |
2019-12-22T14:15:18.0720417Z    |
2019-12-22T14:15:18.0720730Z LL |     let _ = match x {}; //~ ERROR non-exhaustive
2019-12-22T14:15:18.0721014Z    |
2019-12-22T14:15:18.0721134Z    = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
2019-12-22T14:15:18.0721238Z 
2019-12-22T14:15:18.0721238Z 
2019-12-22T14:15:18.0721576Z error[E0004]: non-exhaustive patterns: `&[_, ..]` not covered
2019-12-22T14:15:18.0722570Z    |
2019-12-22T14:15:18.0723056Z LL |     let _ = match x {   //~ ERROR non-exhaustive
2019-12-22T14:15:18.0723056Z LL |     let _ = match x {   //~ ERROR non-exhaustive
2019-12-22T14:15:18.0723425Z    |                   ^ pattern `&[_, ..]` not covered
2019-12-22T14:15:18.0723750Z    = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
2019-12-22T14:15:18.0723883Z 
2019-12-22T14:15:18.0724330Z error[E0004]: non-exhaustive patterns: `Err(_)` not covered
2019-12-22T14:15:18.0724809Z   --> /checkout/src/test/ui/uninhabited/uninhabited-matches-feature-gated.rs:33:19
---
2019-12-22T14:15:18.0727022Z    |
2019-12-22T14:15:18.0727142Z LL |     let Ok(x) = x;
2019-12-22T14:15:18.0727263Z    |         ^^^^^ pattern `Err(_)` not covered
2019-12-22T14:15:18.0727381Z    |
2019-12-22T14:15:18.0727528Z    = note: `let` bindings require an "irrefutable pattern", like a `struct` or an `enum` with only one variant
2019-12-22T14:15:18.0728328Z help: you might want to use `if let` to ignore the variant that isn't matched
2019-12-22T14:15:18.0728487Z    |
2019-12-22T14:15:18.0728607Z LL |     if let Ok(x) = x { /* */ }
2019-12-22T14:15:18.0728742Z    |
---
2019-12-22T14:15:18.0732434Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-22T14:15:18.0732702Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-22T14:15:18.0732925Z 
2019-12-22T14:15:18.0733058Z 
2019-12-22T14:15:18.0735037Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-22T14:15:18.0736079Z 
2019-12-22T14:15:18.0736172Z 
2019-12-22T14:15:18.0736307Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-22T14:15:18.0736419Z Build completed unsuccessfully in 0:58:49
2019-12-22T14:15:18.0736419Z Build completed unsuccessfully in 0:58:49
2019-12-22T14:15:18.0768181Z == clock drift check ==
2019-12-22T14:15:18.0781477Z   local time: Sun Dec 22 14:15:18 UTC 2019
2019-12-22T14:15:18.6187949Z   network time: Sun, 22 Dec 2019 14:15:18 GMT
2019-12-22T14:15:18.6192395Z == end clock drift check ==
2019-12-22T14:15:19.5538142Z 
2019-12-22T14:15:19.5638706Z ##[error]Bash exited with code '1'.
2019-12-22T14:15:19.5714938Z ##[section]Starting: Checkout
2019-12-22T14:15:19.5717068Z ==============================================================================
2019-12-22T14:15:19.5717142Z Task         : Get sources
2019-12-22T14:15:19.5717191Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril
Copy link
Contributor

Centril commented Dec 22, 2019

@bors r- ^--

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 22, 2019
@Mark-Simulacrum
Copy link
Member Author

Forgot to run tests after review nits were fixed :/

I think we should probably wait for CI here to pass and then reapprove

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-12-22T16:15:11.6729117Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-22T16:15:11.6742793Z ##[command]git config gc.auto 0
2019-12-22T16:15:11.6746543Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-22T16:15:11.6750972Z ##[command]git config --get-all http.proxy
2019-12-22T16:15:11.6757343Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67507/merge:refs/remotes/pull/67507/merge
---
2019-12-22T17:13:56.6163527Z .................................................................................................... 1600/9427
2019-12-22T17:14:01.0782061Z .................................................................................................... 1700/9427
2019-12-22T17:14:11.1574358Z .....................................................................................i.............. 1800/9427
2019-12-22T17:14:18.6305619Z .................................................................................................... 1900/9427
2019-12-22T17:14:25.5052175Z ......................................................................iiiii......................... 2000/9427
2019-12-22T17:14:45.8177910Z .................................................................................................... 2200/9427
2019-12-22T17:14:48.1363418Z .................................................................................................... 2300/9427
2019-12-22T17:14:50.8390293Z .................................................................................................... 2400/9427
2019-12-22T17:15:03.6422211Z .................................................................................................... 2500/9427
---
2019-12-22T17:17:52.1679705Z .i...............i.................................................................................. 4900/9427
2019-12-22T17:18:01.9063730Z .................................................................................................... 5000/9427
2019-12-22T17:18:06.6410208Z .............................................i...................................................... 5100/9427
2019-12-22T17:18:16.4534849Z .................................................................................................... 5200/9427
2019-12-22T17:18:22.4523558Z ............ii.ii...........i....................................................................... 5300/9427
2019-12-22T17:18:31.6553435Z .................................................................................................... 5500/9427
2019-12-22T17:18:42.6511888Z ..............................................................................................i..... 5600/9427
2019-12-22T17:18:50.6170738Z .................................................................................................... 5700/9427
2019-12-22T17:18:55.7329202Z .................................................................................................... 5800/9427
2019-12-22T17:18:55.7329202Z .................................................................................................... 5800/9427
2019-12-22T17:19:05.2331236Z ..................................................................................ii...i..ii........ 5900/9427
2019-12-22T17:19:27.2441946Z .................................................................................................... 6100/9427
2019-12-22T17:19:34.9166400Z .................................................................................................... 6200/9427
2019-12-22T17:19:42.7980334Z .................................................................................................... 6300/9427
2019-12-22T17:19:42.7980334Z .................................................................................................... 6300/9427
2019-12-22T17:19:58.4252729Z .........i..ii...................................................................................... 6400/9427
2019-12-22T17:20:17.2622750Z .....................................................................................i.............. 6600/9427
2019-12-22T17:20:19.3793439Z .................................................................................................... 6700/9427
2019-12-22T17:20:21.6153141Z .....................................................................................i.............. 6800/9427
2019-12-22T17:20:24.2929028Z .................................................................................................... 6900/9427
---
2019-12-22T17:21:56.3576247Z .................................................................................................... 7400/9427
2019-12-22T17:22:01.3089886Z .................................................................................................... 7500/9427
2019-12-22T17:22:06.4047503Z .................................................................................................... 7600/9427
2019-12-22T17:22:13.2460758Z .................................................................................................... 7700/9427
2019-12-22T17:22:23.7012942Z ...................................................................................................i 7800/9427
2019-12-22T17:22:30.3884009Z iii................................................................................................. 7900/9427
2019-12-22T17:22:44.2226595Z .................................................................................................... 8100/9427
2019-12-22T17:22:55.6411769Z .................................................................................................... 8200/9427
2019-12-22T17:23:07.4255498Z .................................................................................................... 8300/9427
2019-12-22T17:23:12.9963255Z .................................................................................................... 8400/9427
---
2019-12-22T17:25:05.4184542Z 8 
2019-12-22T17:25:05.4185355Z + warning: use of deprecated item 'std::mem::uninitialized': use `mem::MaybeUninit` instead
2019-12-22T17:25:05.4186191Z +   --> $DIR/issue-61422.rs:14:33
2019-12-22T17:25:05.4186419Z +    |
2019-12-22T17:25:05.4186620Z + LL |         let array: [u8; SIZE] = mem::uninitialized();
2019-12-22T17:25:05.4186972Z +    |
2019-12-22T17:25:05.4187156Z +    = note: `#[warn(deprecated)]` on by default
2019-12-22T17:25:05.4187324Z + 
2019-12-22T17:25:05.4187484Z 9 
2019-12-22T17:25:05.4187484Z 9 
2019-12-22T17:25:05.4187645Z 
2019-12-22T17:25:05.4187795Z 
2019-12-22T17:25:05.4187963Z The actual stderr differed from the expected stderr.
2019-12-22T17:25:05.4188396Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-generics/issues/issue-61422/issue-61422.stderr
2019-12-22T17:25:05.4188842Z To update references, rerun the tests and pass the `--bless` flag
2019-12-22T17:25:05.4189335Z To only update this specific test, also pass `--test-args const-generics/issues/issue-61422.rs`
2019-12-22T17:25:05.4189792Z error: 1 errors occurred comparing output.
2019-12-22T17:25:05.4190137Z status: exit code: 0
2019-12-22T17:25:05.4190137Z status: exit code: 0
2019-12-22T17:25:05.4191006Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/const-generics/issues/issue-61422.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-generics/issues/issue-61422" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-generics/issues/issue-61422/auxiliary" "-A" "unused"
2019-12-22T17:25:05.4192927Z ------------------------------------------
2019-12-22T17:25:05.4192978Z 
2019-12-22T17:25:05.4193201Z ------------------------------------------
2019-12-22T17:25:05.4193266Z stderr:
---
2019-12-22T17:25:05.4194105Z 
2019-12-22T17:25:05.4194392Z warning: use of deprecated item 'std::mem::uninitialized': use `mem::MaybeUninit` instead
2019-12-22T17:25:05.4194802Z   --> /checkout/src/test/ui/const-generics/issues/issue-61422.rs:14:33
2019-12-22T17:25:05.4194842Z    |
2019-12-22T17:25:05.4194895Z LL |         let array: [u8; SIZE] = mem::uninitialized();
2019-12-22T17:25:05.4194977Z    |
2019-12-22T17:25:05.4195030Z    = note: `#[warn(deprecated)]` on by default
2019-12-22T17:25:05.4195054Z 
2019-12-22T17:25:05.4195075Z 
---
2019-12-22T17:25:05.4205323Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-22T17:25:05.4205412Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-22T17:25:05.4220548Z 
2019-12-22T17:25:05.4220781Z 
2019-12-22T17:25:05.4223348Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-22T17:25:05.4223635Z 
2019-12-22T17:25:05.4223688Z 
2019-12-22T17:25:05.4228470Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-22T17:25:05.4228533Z Build completed unsuccessfully in 1:03:47
2019-12-22T17:25:05.4228533Z Build completed unsuccessfully in 1:03:47
2019-12-22T17:25:05.4285160Z == clock drift check ==
2019-12-22T17:25:05.4307959Z   local time: Sun Dec 22 17:25:05 UTC 2019
2019-12-22T17:25:05.7208124Z   network time: Sun, 22 Dec 2019 17:25:05 GMT
2019-12-22T17:25:05.7208733Z == end clock drift check ==
2019-12-22T17:25:06.9289111Z 
2019-12-22T17:25:06.9414006Z ##[error]Bash exited with code '1'.
2019-12-22T17:25:06.9457257Z ##[section]Starting: Checkout
2019-12-22T17:25:06.9458888Z ==============================================================================
2019-12-22T17:25:06.9458953Z Task         : Get sources
2019-12-22T17:25:06.9458990Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-12-22T17:31:51.2277302Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-22T17:31:51.2509778Z ##[command]git config gc.auto 0
2019-12-22T17:31:51.2550549Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-22T17:31:51.2604869Z ##[command]git config --get-all http.proxy
2019-12-22T17:31:51.8289976Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67507/merge:refs/remotes/pull/67507/merge
---
2019-12-22T17:38:06.0946887Z    Compiling serde_json v1.0.40
2019-12-22T17:38:07.8050787Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-12-22T17:38:18.7797954Z     Finished release [optimized] target(s) in 1m 27s
2019-12-22T17:38:18.7902241Z tidy check
2019-12-22T17:38:19.3195693Z tidy error: /checkout/src/test/ui/structs-enums/enum-non-c-like-repr-c-and-int.rs:73: line longer than 100 chars
2019-12-22T17:38:21.5652511Z Found 485 error codes
2019-12-22T17:38:21.5653381Z Found 0 error codes with no tests
2019-12-22T17:38:21.5653658Z Done!
2019-12-22T17:38:21.5654038Z some tidy checks failed
2019-12-22T17:38:21.5654038Z some tidy checks failed
2019-12-22T17:38:21.5657920Z 
2019-12-22T17:38:21.5658250Z 
2019-12-22T17:38:21.5659520Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-12-22T17:38:21.5660212Z 
2019-12-22T17:38:21.5660570Z 
2019-12-22T17:38:21.5686662Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-12-22T17:38:21.5687018Z Build completed unsuccessfully in 0:01:32
2019-12-22T17:38:21.5687018Z Build completed unsuccessfully in 0:01:32
2019-12-22T17:38:21.5738602Z == clock drift check ==
2019-12-22T17:38:21.5749197Z   local time: Sun Dec 22 17:38:21 UTC 2019
2019-12-22T17:38:21.8538112Z   network time: Sun, 22 Dec 2019 17:38:21 GMT
2019-12-22T17:38:21.8540578Z == end clock drift check ==
2019-12-22T17:38:23.1835186Z 
2019-12-22T17:38:23.1904542Z ##[error]Bash exited with code '1'.
2019-12-22T17:38:23.1947214Z ##[section]Starting: Checkout
2019-12-22T17:38:23.1949136Z ==============================================================================
2019-12-22T17:38:23.1949216Z Task         : Get sources
2019-12-22T17:38:23.1949287Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@goffrie
Copy link
Contributor

goffrie commented Dec 22, 2019

Fixes #67507

I think you pasted the wrong number :P

@Mark-Simulacrum Mark-Simulacrum force-pushed the purge-uninit branch 3 times, most recently from b199de8 to 85d30ec Compare December 23, 2019 00:15
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-12-23T00:16:31.8502936Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-23T00:16:31.8519373Z ##[command]git config gc.auto 0
2019-12-23T00:16:31.8521993Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-23T00:16:31.8523883Z ##[command]git config --get-all http.proxy
2019-12-23T00:16:31.8526868Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67507/merge:refs/remotes/pull/67507/merge
---
2019-12-23T01:13:13.9199897Z .................................................................................................... 1600/9427
2019-12-23T01:13:18.3898379Z .................................................................................................... 1700/9427
2019-12-23T01:13:28.4297830Z .....................................................................................i.............. 1800/9427
2019-12-23T01:13:35.6128548Z .................................................................................................... 1900/9427
2019-12-23T01:13:42.1935179Z ......................................................................iiiii......................... 2000/9427
2019-12-23T01:14:01.5776232Z .................................................................................................... 2200/9427
2019-12-23T01:14:03.8522864Z .................................................................................................... 2300/9427
2019-12-23T01:14:06.4447942Z .................................................................................................... 2400/9427
2019-12-23T01:14:18.8139193Z .................................................................................................... 2500/9427
---
2019-12-23T01:17:06.2998991Z .i...............i.................................................................................. 4900/9427
2019-12-23T01:17:16.1227793Z .................................................................................................... 5000/9427
2019-12-23T01:17:20.8208322Z .............................................i...................................................... 5100/9427
2019-12-23T01:17:30.1064741Z .................................................................................................... 5200/9427
2019-12-23T01:17:35.7482295Z ............ii.ii...........i....................................................................... 5300/9427
2019-12-23T01:17:44.5307318Z .................................................................................................... 5500/9427
2019-12-23T01:17:55.2174499Z ..............................................................................................i..... 5600/9427
2019-12-23T01:18:03.0362637Z .................................................................................................... 5700/9427
2019-12-23T01:18:08.0379005Z .................................................................................................... 5800/9427
2019-12-23T01:18:08.0379005Z .................................................................................................... 5800/9427
2019-12-23T01:18:17.5271823Z ..................................................................................ii...i...ii....... 5900/9427
2019-12-23T01:18:39.4272627Z .................................................................................................... 6100/9427
2019-12-23T01:18:46.8627491Z .................................................................................................... 6200/9427
2019-12-23T01:18:54.6000628Z .................................................................................................... 6300/9427
2019-12-23T01:18:54.6000628Z .................................................................................................... 6300/9427
2019-12-23T01:19:09.9886624Z .........i..ii...................................................................................... 6400/9427
2019-12-23T01:19:28.8417875Z .....................................................................................i.............. 6600/9427
2019-12-23T01:19:31.0351837Z .................................................................................................... 6700/9427
2019-12-23T01:19:33.3372571Z .....................................................................................i.............. 6800/9427
2019-12-23T01:19:36.1336188Z .................................................................................................... 6900/9427
---
2019-12-23T01:21:06.5780446Z .................................................................................................... 7400/9427
2019-12-23T01:21:11.3240464Z .................................................................................................... 7500/9427
2019-12-23T01:21:16.4095020Z .................................................................................................... 7600/9427
2019-12-23T01:21:23.2540474Z .................................................................................................... 7700/9427
2019-12-23T01:21:33.5174575Z ...................................................................................................i 7800/9427
2019-12-23T01:21:40.0005167Z iii................................................................................................. 7900/9427
2019-12-23T01:21:53.5928138Z .................................................................................................... 8100/9427
2019-12-23T01:22:04.9106297Z .................................................................................................... 8200/9427
2019-12-23T01:22:16.4218888Z .................................................................................................... 8300/9427
2019-12-23T01:22:22.1104955Z .................................................................................................... 8400/9427
---
2019-12-23T01:24:13.0245166Z ---- [ui] ui/abi/stack-probes-lto.rs stdout ----
2019-12-23T01:24:13.0245207Z 
2019-12-23T01:24:13.0245991Z error: test compilation failed although it shouldn't!
2019-12-23T01:24:13.0246225Z status: exit code: 1
2019-12-23T01:24:13.0247120Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/abi/stack-probes-lto.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/stack-probes-lto/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-C" "lto" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/stack-probes-lto/auxiliary"
2019-12-23T01:24:13.0247744Z ------------------------------------------
2019-12-23T01:24:13.0247928Z 
2019-12-23T01:24:13.0248244Z ------------------------------------------
2019-12-23T01:24:13.0248294Z stderr:
2019-12-23T01:24:13.0248294Z stderr:
2019-12-23T01:24:13.0248665Z ------------------------------------------
2019-12-23T01:24:13.0249097Z error[E0433]: failed to resolve: use of undeclared type or module `MaybeUninit`
2019-12-23T01:24:13.0249426Z   --> /checkout/src/test/ui/abi/stack-probes.rs:55:43
2019-12-23T01:24:13.0249502Z    |
2019-12-23T01:24:13.0249549Z LL |     let local: MaybeUninit<[u64; 1024]> = MaybeUninit::uninit();
2019-12-23T01:24:13.0249834Z 
2019-12-23T01:24:13.0250089Z error[E0412]: cannot find type `MaybeUninit` in this scope
2019-12-23T01:24:13.0250394Z   --> /checkout/src/test/ui/abi/stack-probes.rs:51:20
2019-12-23T01:24:13.0250610Z    |
2019-12-23T01:24:13.0250610Z    |
2019-12-23T01:24:13.0250683Z LL | fn recurse(array: &MaybeUninit<[u64; 1024]>) {
2019-12-23T01:24:13.0250834Z    |
2019-12-23T01:24:13.0250902Z help: possible candidate is found in another module, you can import it into scope
2019-12-23T01:24:13.0250966Z    |
2019-12-23T01:24:13.0251049Z LL | use std::mem::MaybeUninit;
2019-12-23T01:24:13.0251049Z LL | use std::mem::MaybeUninit;
2019-12-23T01:24:13.0251090Z    |
2019-12-23T01:24:13.0251138Z 
2019-12-23T01:24:13.0251224Z error[E0412]: cannot find type `MaybeUninit` in this scope
2019-12-23T01:24:13.0251642Z   --> /checkout/src/test/ui/abi/stack-probes.rs:55:16
2019-12-23T01:24:13.0251830Z    |
2019-12-23T01:24:13.0251926Z LL |     let local: MaybeUninit<[u64; 1024]> = MaybeUninit::uninit();
2019-12-23T01:24:13.0252052Z    |
2019-12-23T01:24:13.0252140Z help: possible candidate is found in another module, you can import it into scope
2019-12-23T01:24:13.0252205Z    |
2019-12-23T01:24:13.0252265Z LL | use std::mem::MaybeUninit;
---
2019-12-23T01:24:13.0253932Z ---- [ui] ui/abi/stack-probes.rs stdout ----
2019-12-23T01:24:13.0253967Z 
2019-12-23T01:24:13.0254176Z error: test compilation failed although it shouldn't!
2019-12-23T01:24:13.0254222Z status: exit code: 1
2019-12-23T01:24:13.0255161Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/abi/stack-probes.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/stack-probes/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/stack-probes/auxiliary"
2019-12-23T01:24:13.0255485Z ------------------------------------------
2019-12-23T01:24:13.0255848Z 
2019-12-23T01:24:13.0256204Z ------------------------------------------
2019-12-23T01:24:13.0256267Z stderr:
2019-12-23T01:24:13.0256267Z stderr:
2019-12-23T01:24:13.0256488Z ------------------------------------------
2019-12-23T01:24:13.0256700Z error[E0433]: failed to resolve: use of undeclared type or module `MaybeUninit`
2019-12-23T01:24:13.0257270Z   --> /checkout/src/test/ui/abi/stack-probes.rs:55:43
2019-12-23T01:24:13.0257348Z    |
2019-12-23T01:24:13.0297376Z LL |     let local: MaybeUninit<[u64; 1024]> = MaybeUninit::uninit();
2019-12-23T01:24:13.0302626Z 
2019-12-23T01:24:13.0302821Z error[E0412]: cannot find type `MaybeUninit` in this scope
2019-12-23T01:24:13.0303388Z   --> /checkout/src/test/ui/abi/stack-probes.rs:51:20
2019-12-23T01:24:13.0303503Z    |
2019-12-23T01:24:13.0303503Z    |
2019-12-23T01:24:13.0303553Z LL | fn recurse(array: &MaybeUninit<[u64; 1024]>) {
2019-12-23T01:24:13.0303666Z    |
2019-12-23T01:24:13.0303734Z help: possible candidate is found in another module, you can import it into scope
2019-12-23T01:24:13.0303781Z    |
2019-12-23T01:24:13.0303824Z LL | use std::mem::MaybeUninit;
2019-12-23T01:24:13.0303824Z LL | use std::mem::MaybeUninit;
2019-12-23T01:24:13.0303884Z    |
2019-12-23T01:24:13.0304057Z 
2019-12-23T01:24:13.0304115Z error[E0412]: cannot find type `MaybeUninit` in this scope
2019-12-23T01:24:13.0304412Z   --> /checkout/src/test/ui/abi/stack-probes.rs:55:16
2019-12-23T01:24:13.0304481Z    |
2019-12-23T01:24:13.0304528Z LL |     let local: MaybeUninit<[u64; 1024]> = MaybeUninit::uninit();
2019-12-23T01:24:13.0304641Z    |
2019-12-23T01:24:13.0304689Z help: possible candidate is found in another module, you can import it into scope
2019-12-23T01:24:13.0304734Z    |
2019-12-23T01:24:13.0304793Z LL | use std::mem::MaybeUninit;
---
2019-12-23T01:24:13.0307032Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-23T01:24:13.0307092Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-23T01:24:13.0307175Z 
2019-12-23T01:24:13.0307203Z 
2019-12-23T01:24:13.0309256Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-23T01:24:13.0309519Z 
2019-12-23T01:24:13.0309550Z 
2019-12-23T01:24:13.0314095Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-23T01:24:13.0314341Z Build completed unsuccessfully in 1:01:49
2019-12-23T01:24:13.0314341Z Build completed unsuccessfully in 1:01:49
2019-12-23T01:24:13.0365892Z == clock drift check ==
2019-12-23T01:24:13.0387705Z   local time: Mon Dec 23 01:24:13 UTC 2019
2019-12-23T01:24:13.3096898Z   network time: Mon, 23 Dec 2019 01:24:13 GMT
2019-12-23T01:24:13.3100595Z == end clock drift check ==
2019-12-23T01:24:14.5684697Z 
2019-12-23T01:24:14.5752647Z ##[error]Bash exited with code '1'.
2019-12-23T01:24:14.5796689Z ##[section]Starting: Checkout
2019-12-23T01:24:14.5798587Z ==============================================================================
2019-12-23T01:24:14.5798632Z Task         : Get sources
2019-12-23T01:24:14.5798670Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-12-23T01:37:53.4512783Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-23T01:37:53.4742811Z ##[command]git config gc.auto 0
2019-12-23T01:37:53.4819907Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-23T01:37:53.4876320Z ##[command]git config --get-all http.proxy
2019-12-23T01:37:53.5047889Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67507/merge:refs/remotes/pull/67507/merge
---
2019-12-23T02:37:38.1822748Z .................................................................................................... 1600/9427
2019-12-23T02:37:43.1451121Z .................................................................................................... 1700/9427
2019-12-23T02:37:54.5800466Z .....................................................................................i.............. 1800/9427
2019-12-23T02:38:02.6097654Z .................................................................................................... 1900/9427
2019-12-23T02:38:10.2988000Z .......................................................................iiiii........................ 2000/9427
2019-12-23T02:38:31.6674168Z .................................................................................................... 2200/9427
2019-12-23T02:38:34.2537730Z .................................................................................................... 2300/9427
2019-12-23T02:38:37.2050263Z .................................................................................................... 2400/9427
2019-12-23T02:38:50.9881185Z .................................................................................................... 2500/9427
---
2019-12-23T02:41:44.3018887Z .i...............i.................................................................................. 4900/9427
2019-12-23T02:41:54.5081129Z .................................................................................................... 5000/9427
2019-12-23T02:41:59.5578432Z .............................................i...................................................... 5100/9427
2019-12-23T02:42:09.7381531Z .................................................................................................... 5200/9427
2019-12-23T02:42:15.7650714Z ............ii.ii...........i....................................................................... 5300/9427
2019-12-23T02:42:25.6827879Z .................................................................................................... 5500/9427
2019-12-23T02:42:37.3812198Z ..............................................................................................i..... 5600/9427
2019-12-23T02:42:46.0319811Z .................................................................................................... 5700/9427
2019-12-23T02:42:51.5242802Z .................................................................................................... 5800/9427
2019-12-23T02:42:51.5242802Z .................................................................................................... 5800/9427
2019-12-23T02:43:01.4071115Z ..................................................................................ii...i..ii........ 5900/9427
2019-12-23T02:43:24.2077429Z .................................................................................................... 6100/9427
2019-12-23T02:43:31.9974737Z .................................................................................................... 6200/9427
2019-12-23T02:43:40.0896999Z .................................................................................................... 6300/9427
2019-12-23T02:43:40.0896999Z .................................................................................................... 6300/9427
2019-12-23T02:43:57.3560855Z .........i..ii...................................................................................... 6400/9427
2019-12-23T02:44:17.8503854Z .....................................................................................i.............. 6600/9427
2019-12-23T02:44:20.0572087Z .................................................................................................... 6700/9427
2019-12-23T02:44:22.2737333Z .....................................................................................i.............. 6800/9427
2019-12-23T02:44:25.0262773Z .................................................................................................... 6900/9427
---
2019-12-23T02:49:10.2203578Z ---- [ui] ui/abi/stack-probes-lto.rs stdout ----
2019-12-23T02:49:10.2203881Z 
2019-12-23T02:49:10.2204418Z error: test compilation failed although it shouldn't!
2019-12-23T02:49:10.2204721Z status: exit code: 1
2019-12-23T02:49:10.2205792Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/abi/stack-probes-lto.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/stack-probes-lto/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-C" "lto" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/stack-probes-lto/auxiliary"
2019-12-23T02:49:10.2206657Z ------------------------------------------
2019-12-23T02:49:10.2206928Z 
2019-12-23T02:49:10.2207409Z ------------------------------------------
2019-12-23T02:49:10.2207724Z stderr:
2019-12-23T02:49:10.2207724Z stderr:
2019-12-23T02:49:10.2208185Z ------------------------------------------
2019-12-23T02:49:10.2208472Z error[E0308]: mismatched types
2019-12-23T02:49:10.2208962Z   --> /checkout/src/test/ui/abi/stack-probes.rs:31:38
2019-12-23T02:49:10.2209247Z    |
2019-12-23T02:49:10.2209721Z LL |             "main-thread" => recurse(&[]),
2019-12-23T02:49:10.2210043Z    |                                      ^^^ expected union `std::mem::MaybeUninit`, found array of 0 elements 
2019-12-23T02:49:10.2210575Z    = note: expected reference `&std::mem::MaybeUninit<[u64; 1024]>`
2019-12-23T02:49:10.2210804Z               found reference `&[_; 0]`
2019-12-23T02:49:10.2210997Z 
2019-12-23T02:49:10.2211211Z error[E0308]: mismatched types
2019-12-23T02:49:10.2211211Z error[E0308]: mismatched types
2019-12-23T02:49:10.2211711Z   --> /checkout/src/test/ui/abi/stack-probes.rs:32:56
2019-12-23T02:49:10.2211998Z    |
2019-12-23T02:49:10.2212526Z LL |             "child-thread" => thread::spawn(|| recurse(&[])).join().unwrap(),
2019-12-23T02:49:10.2212834Z    |                                                        ^^^ expected union `std::mem::MaybeUninit`, found array of 0 elements 
2019-12-23T02:49:10.2213751Z    = note: expected reference `&std::mem::MaybeUninit<[u64; 1024]>`
2019-12-23T02:49:10.2213977Z               found reference `&[_; 0]`
2019-12-23T02:49:10.2214167Z 
2019-12-23T02:49:10.2214402Z error: aborting due to 2 previous errors
---
2019-12-23T02:49:10.2217168Z ---- [ui] ui/abi/stack-probes.rs stdout ----
2019-12-23T02:49:10.2217431Z 
2019-12-23T02:49:10.2217900Z error: test compilation failed although it shouldn't!
2019-12-23T02:49:10.2218211Z status: exit code: 1
2019-12-23T02:49:10.2219221Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/abi/stack-probes.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/stack-probes/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/stack-probes/auxiliary"
2019-12-23T02:49:10.2220252Z ------------------------------------------
2019-12-23T02:49:10.2220516Z 
2019-12-23T02:49:10.2221013Z ------------------------------------------
2019-12-23T02:49:10.2221293Z stderr:
2019-12-23T02:49:10.2221293Z stderr:
2019-12-23T02:49:10.2221740Z ------------------------------------------
2019-12-23T02:49:10.2222647Z error[E0308]: mismatched types
2019-12-23T02:49:10.2223209Z   --> /checkout/src/test/ui/abi/stack-probes.rs:31:38
2019-12-23T02:49:10.2223421Z    |
2019-12-23T02:49:10.2223790Z LL |             "main-thread" => recurse(&[]),
2019-12-23T02:49:10.2224010Z    |                                      ^^^ expected union `std::mem::MaybeUninit`, found array of 0 elements 
2019-12-23T02:49:10.2224319Z    = note: expected reference `&std::mem::MaybeUninit<[u64; 1024]>`
2019-12-23T02:49:10.2224462Z               found reference `&[_; 0]`
2019-12-23T02:49:10.2224594Z 
2019-12-23T02:49:10.2224748Z error[E0308]: mismatched types
2019-12-23T02:49:10.2224748Z error[E0308]: mismatched types
2019-12-23T02:49:10.2225141Z   --> /checkout/src/test/ui/abi/stack-probes.rs:32:56
2019-12-23T02:49:10.2225325Z    |
2019-12-23T02:49:10.2226134Z LL |             "child-thread" => thread::spawn(|| recurse(&[])).join().unwrap(),
2019-12-23T02:49:10.2226396Z    |                                                        ^^^ expected union `std::mem::MaybeUninit`, found array of 0 elements 
2019-12-23T02:49:10.2226699Z    = note: expected reference `&std::mem::MaybeUninit<[u64; 1024]>`
2019-12-23T02:49:10.2226839Z               found reference `&[_; 0]`
2019-12-23T02:49:10.2226955Z 
2019-12-23T02:49:10.2227190Z error: aborting due to 2 previous errors
---
2019-12-23T02:49:10.2258622Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-23T02:49:10.2259021Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-23T02:49:10.2277553Z 
2019-12-23T02:49:10.2277939Z 
2019-12-23T02:49:10.2280378Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-23T02:49:10.2281786Z 
2019-12-23T02:49:10.2281981Z 
2019-12-23T02:49:10.2342176Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-23T02:49:10.2342312Z Build completed unsuccessfully in 1:04:49
2019-12-23T02:49:10.2342312Z Build completed unsuccessfully in 1:04:49
2019-12-23T02:49:10.2349864Z == clock drift check ==
2019-12-23T02:49:10.2376269Z   local time: Mon Dec 23 02:49:10 UTC 2019
2019-12-23T02:49:10.7747278Z   network time: Mon, 23 Dec 2019 02:49:10 GMT
2019-12-23T02:49:10.7753330Z == end clock drift check ==
2019-12-23T02:49:11.8271186Z 
2019-12-23T02:49:11.8462766Z ##[error]Bash exited with code '1'.
2019-12-23T02:49:11.8549692Z ##[section]Starting: Checkout
2019-12-23T02:49:11.8551784Z ==============================================================================
2019-12-23T02:49:11.8551841Z Task         : Get sources
2019-12-23T02:49:11.8551927Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum
Remove mem::uninitalized from tests
c205f6a 
This purges uses of uninitialized where possible from test cases. Some
are merely moved over to the equally bad pattern of
MaybeUninit::uninit().assume_init() but with an annotation that this is
"the best we can do".
@Mark-Simulacrum
Copy link
Member Author

@bors r=Centril

@bors
Copy link
Contributor

bors commented Dec 23, 2019

📌 Commit c205f6a has been approved by Centril

@bors
Copy link
Contributor

bors commented Dec 23, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 23, 2019
@Centril
Rollup merge of rust-lang#67507 - Mark-Simulacrum:purge-uninit, r=Cen…
67c0f4e 
…tril

Remove mem::uninitalized from tests

This purges uses of uninitialized where possible from test cases. Some
are merely moved over to the equally bad pattern of
MaybeUninit::uninit().assume_init() but with an annotation that this is
"the best we can do".

Fixes rust-lang#62397
@Centril Centril mentioned this pull request Dec 23, 2019
Merged
bors added a commit that referenced this pull request Dec 23, 2019
@bors
Auto merge of #67560 - Centril:rollup-fzdpu9c, r=Centril
9ae6ced 
Rollup of 8 pull requests

Successful merges:

 - #67233 (Add PartialEq and Eq to Cursor)
 - #67466 (Require const stability attributes on intrinsics to be able to use them in constant contexts)
 - #67507 (Remove mem::uninitalized from tests)
 - #67527 (Results show too much)
 - #67536 (Move `{hir::lowering -> hir}::is_range_literal`)
 - #67538 (Improve diagnostics for invalid assignment)
 - #67546 (Fix ICE in mir interpretation)
 - #67559 (Document that calling Drop, even after it panics, is UB)

Failed merges:

r? @ghost
@bors bors merged commit c205f6a into rust-lang:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goffrie goffrie goffrie left review comments

@Centril Centril Centril left review comments

@RalfJung RalfJung RalfJung left review comments

@petertodd petertodd petertodd left review comments

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of uses of mem::uninitialized
7 participants
@Mark-Simulacrum @Centril @RalfJung @bors @rust-highfive @goffrie @petertodd