Add more delegations to the fmt docs and add doctests #67253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
elichai
force-pushed
the
2019-12-fmt
branch
2 times, most recently
from
840fb71 to
4ebcb9d
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
| /// } | ||
| /// } | ||
| /// | ||
| /// let origin = Point { x: 0, y: 0 }; | ||
| /// | ||
| /// println!("The origin is: {:?}", origin); | ||
| /// ``` |
There was a problem hiding this comment.
This line shouldn't have been deleted. The code block is continuing into the prose.
There was a problem hiding this comment.
Thank you!
I guess I need to make my IDE highlight these stuff.
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
And after I thought I ran all the tests locally even |
|
Finally :) |
|
@bors r+ rollup |
|
📌 Commit a9d6889 has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 19, 2019
Add more delegations to the fmt docs and add doctests HI, this is a continuation to rust-lang#67021 I replaced the `Debug` example with one that use the `Debug*` helpers so that padding etc will work too. I also added asserts for the doctests as @RalfJung asked :) The only thing I left with the `write!` macro is the `Display` example as I didn't know if there's a better way to do that. r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Dec 19, 2019
Rollup of 6 pull requests Successful merges: - #67253 (Add more delegations to the fmt docs and add doctests) - #67281 (add string.insert benchmarks) - #67351 (Set release channel on non-dist builders) - #67421 (Fix internal documentation typo) - #67432 (Fix toolstate history format) - #67436 (Correct the todo! stabilization version) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI,
this is a continuation to #67021
I replaced the
Debugexample with one that use theDebug*helpers so that padding etc will work too.I also added asserts for the doctests as @RalfJung asked :)
The only thing I left with the
write!macro is theDisplayexample as I didn't know if there's a better way to do that.r? @QuietMisdreavus