Don't suggest wrong snippet in closure #67247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
estebank
reviewed
Dec 12, 2019
| LL | move || { | ||
| | ^^^^^^^ move out of `var` occurs here | ||
| LL | | ||
| LL | var = Some(NotCopyable); |
There was a problem hiding this comment.
Interestingly, suggesting var = Some(NotCopyable).as_ref(); or var= Some(&NotCopyable); could be reasonable, but I wouldn't go out of my way to emit either. The as_ref() suggestion is meant for people still getting their bearings with the language, and the kind of code that this PR protects against is unlikely to be written by that kind of user.
|
r=me once CI is green |
|
@bors r=estebank |
|
📌 Commit fa199c5 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 12, 2019
Don't suggest wrong snippet in closure Fixes rust-lang#67190 r? @estebank
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 13, 2019
Don't suggest wrong snippet in closure Fixes rust-lang#67190 r? @estebank
bors
added a commit
that referenced
this pull request
Dec 13, 2019
Rollup of 6 pull requests Successful merges: - #66341 (Match `VecDeque::extend` to `Vec::extend_desugared`) - #67243 (LinkedList: drop remaining items when drop panics) - #67247 (Don't suggest wrong snippet in closure) - #67250 (Remove the `DelimSpan` from `NamedMatch::MatchedSeq`.) - #67251 (Require `allow_internal_unstable` for stable min_const_fn using unsta…) - #67269 (parser: recover on `&'lifetime mut? $pat`.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67190
r? @estebank