-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RLS and Rustfmt #67198
Update RLS and Rustfmt #67198
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@Xanewok Sorry about that, published the source code (https://github.com/rust-lang/rustfmt/tree/rustfmt-1.4.11). |
Thanks for such a quick response! Just bumped the rustfmt to 1.4.11 in this PR |
@@ -2081,12 +2047,6 @@ dependencies = [ | |||
"winapi 0.3.8", | |||
] | |||
|
|||
[[package]] | |||
name = "memoffset" | |||
version = "0.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RalfJung I'm sure you'll be happy 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I am. :-)
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r+ |
📌 Commit 5b09130 has been approved by |
@bors p=1 |
Update RLS and Rustfmt Fixes #66885 Rustfmt is bumped here to version 1.4.11 ~For now we pull two versions of rustfmt in Cargo.toml (RLS uses 1.4.11, rustfmt source only has 1.4.10), so~ 1. ~it'd be great to upload the source used to publish rustfmt 1.4.11 @topecongiro~ 2. ~I can downgrade the rustfmt used in RLS (it was an oversight on my part when merging rust-lang/rls#1598
☀️ Test successful - checks-azure |
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Fixes #66885
Rustfmt is bumped here to version 1.4.11
For now we pull two versions of rustfmt in Cargo.toml (RLS uses 1.4.11, rustfmt source only has 1.4.10), soit'd be great to upload the source used to publish rustfmt 1.4.11 @topecongiroI can downgrade the rustfmt used in RLS (it was an oversight on my part when merging Update rustfmt to 1.4.11 rls#1598)