Allow Unreachable terminators through min_const_fn checks
#66788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
ecstatic-morse
changed the title
Unreachable terminators through min_const_fn checks
Home come? Seems good to me for that PR to land. |
Centril
approved these changes
Nov 26, 2019
|
Oh I meant #66758 (I use keyword completion to reference github issues). I didn't see someone was trying to work on it. In a perfect world these tests would live together, but it's not terribly important. I'll remove the test from this one? |
Sure, why not; you could also wait and rebase -- up to you :) |
|
📌 Commit a626bf6 has been approved by |
bors
added
S-waiting-on-bors
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Nov 26, 2019
…, r=Centril Allow `Unreachable` terminators through `min_const_fn` checks Resolves rust-lang#66756. This allows `Unreachable` terminators through the `min_const_fn` checks if `#![feature(const_if_match)]` is enabled. We could probably just allow them with no feature flag, but it seems okay to be conservative here. r? @oli-obk
bors
added a commit
that referenced
this pull request
Nov 27, 2019
Rollup of 14 pull requests Successful merges: - #66128 (alloc: Add new_zeroed() versions like new_uninit().) - #66661 (Add riscv64gc-unknown-linux-gnu target) - #66663 (Miri: print leak report even without tracing) - #66711 (Add hardware floating point features to aarch64-pc-windows-msvc) - #66713 (introduce a target to build the kernel of the unikernel HermitCore) - #66717 (tidy: Accommodate rustfmt's preferred layout of stability attributes) - #66719 (Store pointer width as u32 on Config) - #66720 (Move ErrorReported to rustc_errors) - #66737 (Error codes cleanup) - #66754 (Various tweaks to diagnostic output) - #66763 (Minor edit for documentation-tests.md that increases clarity) - #66779 (follow the same function order in the trait) - #66786 (Add wildcard test for const_if_match) - #66788 (Allow `Unreachable` terminators through `min_const_fn` checks) Failed merges: r? @ghost
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Nov 27, 2019
See rust-lang#66788 (comment) for context.
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Nov 27, 2019
…=Dylan-DPC Combine similar tests for const match See rust-lang#66788 (comment) for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #66756.
This allows
Unreachableterminators through themin_const_fnchecks if#![feature(const_if_match)]is enabled. We could probably just allow them with no feature flag, but it seems okay to be conservative here.r? @oli-obk