Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl TrustedLen for vec::Drain #66759

Merged
merged 1 commit into from
Dec 1, 2019
Merged

impl TrustedLen for vec::Drain #66759

merged 1 commit into from
Dec 1, 2019

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Nov 25, 2019

The iterator methods just forward to slice::Iter, which is TrustedLen.

This can probably be applied to other Drain structs as well.

@rust-highfive
Copy link
Collaborator

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 25, 2019
@joshtriplett
Copy link
Member

Seems entirely reasonable to me.

@Centril Centril added needs-fcp This change is insta-stable, so needs a completed FCP to proceed. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Nov 25, 2019
@Centril Centril added this to the 1.41 milestone Nov 25, 2019
@KodrAus
Copy link
Contributor

KodrAus commented Nov 30, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Nov 30, 2019

📌 Commit f8a4b6d has been approved by KodrAus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2019
@bors
Copy link
Contributor

bors commented Nov 30, 2019

⌛ Testing commit f8a4b6d with merge dc9a63fe5970e8ebb830bd4d283f8a508263f8c7...

@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-11-30T07:20:37.7502116Z do so (now or later) by using -b with the checkout command again. Example:
2019-11-30T07:20:37.7503077Z 
2019-11-30T07:20:37.7503582Z   git checkout -b <new-branch-name>
2019-11-30T07:20:37.7504015Z 
2019-11-30T07:20:37.7504388Z HEAD is now at dc9a63fe5 Auto merge of #66759 - CAD97:patch-3, r=KodrAus
2019-11-30T07:20:37.7899904Z ##[section]Starting: Setup environment
2019-11-30T07:20:37.8013148Z ==============================================================================
2019-11-30T07:20:37.8013459Z Task         : Bash
2019-11-30T07:20:37.8013567Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-11-30T07:20:39.5325243Z BUILD_SOURCEBRANCHNAME=auto
2019-11-30T07:20:39.5325319Z BUILD_SOURCESDIRECTORY=D:\a\1\s
2019-11-30T07:20:39.5325429Z BUILD_SOURCEVERSION=dc9a63fe5970e8ebb830bd4d283f8a508263f8c7
2019-11-30T07:20:39.5325530Z BUILD_SOURCEVERSIONAUTHOR=bors
2019-11-30T07:20:39.5325647Z BUILD_SOURCEVERSIONMESSAGE=Auto merge of #66759 - CAD97:patch-3, r=KodrAus
2019-11-30T07:20:39.5325831Z CI_JOB_NAME=dist-x86_64-msvc
2019-11-30T07:20:39.5326094Z COBERTURA_HOME=C:\cobertura-2.1.1
2019-11-30T07:20:39.5326165Z COMMONPROGRAMFILES=C:\Program Files\Common Files
2019-11-30T07:20:39.5326421Z COMMON_TESTRESULTSDIRECTORY=D:\a\1\TestResults
---
2019-11-30T07:20:39.5338657Z TMP=/tmp
2019-11-30T07:20:39.5338901Z TOOLSTATE_ISSUES_API_URL=https://api.github.com/repos/rust-lang/rust/issues
2019-11-30T07:20:39.5338989Z TOOLSTATE_PUBLISH=1
2019-11-30T07:20:39.5339062Z TOOLSTATE_REPO=https://github.com/rust-lang-nursery/rust-toolstate
2019-11-30T07:20:39.5339163Z The iterator methods just forward to `slice::Iter`, which is `TrustedLen`.
2019-11-30T07:20:39.5339247Z This can probably be applied to other `Drain` structs as well.
2019-11-30T07:20:39.5339418Z USERDOMAIN=fv-az433
2019-11-30T07:20:39.5339479Z USERDOMAIN_ROAMINGPROFILE=fv-az433
2019-11-30T07:20:39.5339558Z USERNAME=VssAdministrator
2019-11-30T07:20:39.5339621Z USERPROFILE=C:\Users\VssAdministrator
---
2019-11-30T07:22:10.8294810Z Chocolatey installed 0/1 packages. 1 packages failed.
2019-11-30T07:22:10.8295171Z  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
2019-11-30T07:22:10.8298927Z 
2019-11-30T07:22:10.8304161Z Failures
2019-11-30T07:22:10.8310582Z  - msys2 (exited 1) - msys2 not installed. An error occurred during installation:
2019-11-30T07:22:10.8311217Z  The remote server returned an error: (503) Server Unavailable. Service Unavailable
2019-11-30T07:22:11.3432238Z 
2019-11-30T07:22:11.3517881Z ##[error]Bash exited with code '1'.
2019-11-30T07:22:11.3685255Z ##[section]Starting: Checkout
2019-11-30T07:22:11.3798276Z ==============================================================================
2019-11-30T07:22:11.3798395Z Task         : Get sources
2019-11-30T07:22:11.3798493Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Nov 30, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2019
@Centril
Copy link
Contributor

Centril commented Nov 30, 2019

@bors retry spurious

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 30, 2019
@Centril
Rollup merge of rust-lang#66759 - CAD97:patch-3, r=KodrAus
9ae7fb3 
impl TrustedLen for vec::Drain

The iterator methods just forward to `slice::Iter`, which is `TrustedLen`.

This can probably be applied to other `Drain` structs as well.
@Centril Centril mentioned this pull request Nov 30, 2019
Merged
bors added a commit that referenced this pull request Dec 1, 2019
@bors
Auto merge of #66908 - Centril:rollup-26givp6, r=Centril
135ccba 
Rollup of 9 pull requests

Successful merges:

 - #66612 (Initial implementation of or-pattern usefulness checking)
 - #66705 (Atomic as_mut_ptr)
 - #66759 (impl TrustedLen for vec::Drain)
 - #66858 (Use LLVMAddAnalysisPasses instead of Rust's wrapper)
 - #66870 (SimplifyArmIdentity only for locals with the same type)
 - #66883 (rustc_typeck: gate AnonConst's generics on feature(const_generics).)
 - #66889 (Make python-generated source files compatible with rustfmt)
 - #66894 (Remove unneeded prelude imports in libcore tests)
 - #66895 (Feature gating *declarations* => new crate `rustc_feature`)

Failed merges:

 - #66905 (rustc_plugin: Remove some remaining plugin features)

r? @ghost
@bors bors merged commit f8a4b6d into rust-lang:master Dec 1, 2019
@CAD97 CAD97 deleted the patch-3 branch February 25, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KodrAus KodrAus KodrAus left review comments

Assignees

@KodrAus KodrAus

Labels
needs-fcp This change is insta-stable, so needs a completed FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.41
Development

Successfully merging this pull request may close these issues.
6 participants
@CAD97 @rust-highfive @joshtriplett @KodrAus @bors @Centril