Fix some issues with attributes on unnamed fields #66669

petrochenkov · 2019-11-23T14:40:58Z

rust-highfive · 2019-11-23T14:41:09Z

(rust_highfive has picked a reviewer for you, use r? to override)

bors · 2019-11-24T01:40:57Z

☔ The latest upstream changes (presumably #66680) made this pull request unmergeable. Please resolve the merge conflicts.

…attributes

petrochenkov · 2019-11-24T08:59:31Z

r? @matthewjasper

matthewjasper · 2019-11-24T15:07:35Z

@bors r+

bors · 2019-11-24T15:07:36Z

📌 Commit f1359c6 has been approved by matthewjasper

bors · 2019-11-25T01:12:45Z

⌛ Testing commit f1359c6 with merge e35f2ada430b6f0fd928529cd0ece66d18588a56...

rust-highfive · 2019-11-25T01:20:29Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-25T01:14:03.8286760Z do so (now or later) by using -b with the checkout command again. Example:
2019-11-25T01:14:03.8286879Z 
2019-11-25T01:14:03.8287168Z   git checkout -b <new-branch-name>
2019-11-25T01:14:03.8287239Z 
2019-11-25T01:14:03.8287916Z HEAD is now at e35f2ada4 Auto merge of #66669 - petrochenkov:tup2attr, r=matthewjasper
2019-11-25T01:14:03.8663701Z ##[section]Starting: Decide whether to run this job
2019-11-25T01:14:03.8784626Z ==============================================================================
2019-11-25T01:14:03.8784779Z Task         : Bash
2019-11-25T01:14:03.8784920Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-11-25T01:14:05.1286271Z BUILD_SOURCEBRANCHNAME=auto
2019-11-25T01:14:05.1286471Z BUILD_SOURCESDIRECTORY=D:\a\2\s
2019-11-25T01:14:05.1286685Z BUILD_SOURCEVERSION=e35f2ada430b6f0fd928529cd0ece66d18588a56
2019-11-25T01:14:05.1286895Z BUILD_SOURCEVERSIONAUTHOR=bors
2019-11-25T01:14:05.1287126Z BUILD_SOURCEVERSIONMESSAGE=Auto merge of #66669 - petrochenkov:tup2attr, r=matthewjasper
2019-11-25T01:14:05.1287625Z CI_JOB_NAME=dist-i686-msvc
2019-11-25T01:14:05.1287814Z COBERTURA_HOME=C:\cobertura-2.1.1
2019-11-25T01:14:05.1288022Z COMMONPROGRAMFILES=C:\Program Files\Common Files
2019-11-25T01:14:05.1288251Z COMMON_TESTRESULTSDIRECTORY=D:\a\2\TestResults
---
2019-11-25T01:18:56.2129239Z 
2019-11-25T01:18:56.2129672Z Total Download Size:    168.30 MiB
2019-11-25T01:18:56.2129935Z Total Installed Size:  1048.57 MiB
2019-11-25T01:18:56.2130206Z 
2019-11-25T01:18:56.2130488Z :: Proceed with installation? [Y/n] error: Partition / too full: 48241 blocks needed, 40153 blocks free
2019-11-25T01:18:56.2130643Z error: failed to commit transaction (not enough free disk space)
2019-11-25T01:18:56.2642209Z Errors occurred, no packages were upgraded.
2019-11-25T01:18:56.2667103Z 
2019-11-25T01:18:56.2667103Z 
2019-11-25T01:18:56.2783365Z ##[error]Bash exited with code '1'.
2019-11-25T01:18:56.2919688Z ##[section]Starting: Checkout
2019-11-25T01:18:56.3017431Z ==============================================================================
2019-11-25T01:18:56.3017572Z Task         : Get sources
2019-11-25T01:18:56.3017690Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-11-25T01:20:33Z

💔 Test failed - checks-azure

dtolnay · 2019-11-25T02:05:45Z

@bors retry

bors · 2019-11-25T05:41:33Z

⌛ Testing commit f1359c6 with merge 4eee955...

Fix some issues with attributes on unnamed fields Fixes #66487 Fixes #66555

bors · 2019-11-25T08:59:29Z

☀️ Test successful - checks-azure
Approved by: matthewjasper
Pushing 4eee955 to master...

tmandry · 2019-11-26T18:43:44Z

Er, well, I nominated for beta and stable backports since #66555 is marked as a stable-to-stable regression. But now I can't reproduce on either beta or stable, so un-nominating.

(Leaving I-nominated so someone can follow up.)

tmandry · 2019-11-26T18:47:00Z

Actually, I can reproduce on stable and beta with the testcase in #66555 (comment). I was using a testcase I built myself using serde attributes (which showed up in the Fuchsia tree).

Re-nominating; sorry for the noise :)

@matthewjasper

resolve: Resolve visibilities on fields with non-builtin attributes Follow-up to rust-lang#66669. The first commit is primary (and also a backport candidate), the other ones are further cleanups. In this case it's not strictly necessary to avoid reporting errors during speculative resolution because 1) all visibilities are resolved non-speculatively sooner or later and 2) error reporting infrastructure merges identical errors with identical spans anyway. Fixes rust-lang#67006 r? @matthewjasper

[beta] Beta backports Backporting the following pull requests: * resolve: Always resolve visibilities on impl items #67236 * resolve: Resolve visibilities on fields with non-builtin attributes #67106 * E0023: handle expected != tuple pattern type #67044 * Fix `unused_parens` triggers on macro by example code #66983 * Fix some issues with attributes on unnamed fields #66669 * Ensure that we get a hard error on generic ZST constants if their bodies #67134 (via #67297) Some of these conflicted on merge, I resolved where possible, sometimes by cherry-picking a commit or two more from the relevant PRs. Since those changes are necessary though for backport to proceed (otherwise not even std/core compile), seems fine -- they're fairly minor cleanups anyway.

rust-highfive assigned alexcrichton Nov 23, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2019

This was referenced Nov 23, 2019

tuple structs with all-public fields can not be instantiated if one of the fields has an external attribute #66555

Closed

ICE 'no entry found for key' in Servo’s style crate #66487

Closed

petrochenkov added 2 commits November 24, 2019 11:47

def_collector: Do not forget to save indices of fields with multiple …

37bb0c7

…attributes

expand: Fully preserve visibilities on unnamed fields with attributes

f1359c6

petrochenkov force-pushed the tup2attr branch from f04899b to f1359c6 Compare November 24, 2019 08:58

rust-highfive assigned matthewjasper and unassigned alexcrichton Nov 24, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 25, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2019

petrochenkov mentioned this pull request Nov 25, 2019

unexpected panic, including librocksdb #66727

Closed

bors added a commit that referenced this pull request Nov 25, 2019

Auto merge of #66669 - petrochenkov:tup2attr, r=matthewjasper

4eee955

Fix some issues with attributes on unnamed fields Fixes #66487 Fixes #66555

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 25, 2019

bors merged commit f1359c6 into rust-lang:master Nov 25, 2019

memoryruins mentioned this pull request Nov 25, 2019

thread 'rustc' panicked at 'no entry found for key', src/libcore/option.rs:1187:5 #66742

Closed

tmandry added beta-nominated Nominated for backporting to the compiler in the beta channel. I-nominated stable-nominated Nominated for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 26, 2019

tmandry removed beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Nov 26, 2019

tmandry added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Nov 26, 2019

petrochenkov mentioned this pull request Nov 29, 2019

Contradictory E0423 (constructor not visible due to private fields) when attributes are not in scope #66853

Closed

petrochenkov mentioned this pull request Dec 6, 2019

resolve: Resolve visibilities on fields with non-builtin attributes #67106

Merged

pnkfelix added beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Dec 7, 2019

c410-f3r mentioned this pull request Dec 7, 2019

Improves u128/i128 handling serde-rs/serde#1679

Closed

petrochenkov mentioned this pull request Dec 8, 2019

rustc 1.39 crashed when compile code which using an unknown attribute #67141

Closed

Mark-Simulacrum removed beta-nominated Nominated for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Dec 14, 2019

Mark-Simulacrum mentioned this pull request Dec 14, 2019

[beta] Beta backports #67298

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some issues with attributes on unnamed fields #66669

Fix some issues with attributes on unnamed fields #66669

petrochenkov commented Nov 23, 2019

rust-highfive commented Nov 23, 2019

bors commented Nov 24, 2019

petrochenkov commented Nov 24, 2019

matthewjasper commented Nov 24, 2019

bors commented Nov 24, 2019

bors commented Nov 25, 2019

rust-highfive commented Nov 25, 2019

bors commented Nov 25, 2019

dtolnay commented Nov 25, 2019

bors commented Nov 25, 2019

bors commented Nov 25, 2019

tmandry commented Nov 26, 2019

tmandry commented Nov 26, 2019

Fix some issues with attributes on unnamed fields #66669

Fix some issues with attributes on unnamed fields #66669

Conversation

petrochenkov commented Nov 23, 2019

rust-highfive commented Nov 23, 2019

bors commented Nov 24, 2019

petrochenkov commented Nov 24, 2019

matthewjasper commented Nov 24, 2019

bors commented Nov 24, 2019

bors commented Nov 25, 2019

rust-highfive commented Nov 25, 2019

bors commented Nov 25, 2019

dtolnay commented Nov 25, 2019

bors commented Nov 25, 2019

bors commented Nov 25, 2019

tmandry commented Nov 26, 2019

tmandry commented Nov 26, 2019