Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #66607

Merged
merged 20 commits into from
Nov 21, 2019
Merged

Rollup of 5 pull requests #66607

merged 20 commits into from
Nov 21, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Nov 21, 2019

Successful merges:

Failed merges:

r? @ghost

csmoe and others added 20 commits November 11, 2019 21:37
Also remove `never_type` the feature-gate test.
…li-obk

Stabilize `!` in Rust 1.41.0

This PR stabilizes the `never_type` (written `!`). The type represents computations that we know diverge in the type system and therefore has no values / inhabitants / elements / members.

The current nightly version is 1.40.0 which will become stable on 2019-12-19.

Tracking issue: rust-lang#35121.
Closes rust-lang#57012.
Closes rust-lang#58184.
Original stabilization report: rust-lang#57012 (comment)

Additional notes:

- In rust-lang#62661 we reserved `impl<T> From<!> for T` so this concern should be resolved.
- The type inference fallback change is moved to `#![feature(never_type_fallback)]` (rust-lang#65992).
- You can find all of the tests referencing `never_type` in this PR which also reorganizes these tests whereas they were more scattered before.

r? @nikomatsakis
Suggest to add lifetime constraint at explicit ouput of functions

Closes rust-lang#62097
Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm`

r? @oli-obk
…aumeGomez

Revert "Update Source Code Pro and include italics"

This reverts commit ea9519b.
@Centril
Copy link
Contributor Author

Centril commented Nov 21, 2019

@bors r+ p=5 rollup=never

@bors
Copy link
Contributor

bors commented Nov 21, 2019

📌 Commit 5ab2bcc has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 21, 2019
@Centril Centril added the rollup A PR which is a rollup label Nov 21, 2019
@bors
Copy link
Contributor

bors commented Nov 21, 2019

⌛ Testing commit 5ab2bcc with merge 35ef33a...

bors added a commit that referenced this pull request Nov 21, 2019
Rollup of 5 pull requests

Successful merges:

 - #65355 (Stabilize `!` in Rust 1.41.0)
 - #65730 (Suggest to add lifetime constraint at explicit ouput of functions)
 - #66468 (Cleanup Miri SIMD intrinsics)
 - #66515 (Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm`)
 - #66602 (Revert "Update Source Code Pro and include italics")

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Nov 21, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 35ef33a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 21, 2019
@bors bors merged commit 5ab2bcc into rust-lang:master Nov 21, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #66607!

Tested on commit 35ef33a.
Direct link to PR: #66607

🎉 rustc-guide on linux: test-fail → test-pass (cc @JohnTitor @amanjeev @spastorino @mark-i-m, @rust-lang/infra).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants