Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions: preparations, part 1 #66569

Merged
merged 3 commits into from
Nov 25, 2019
Merged

GitHub Actions: preparations, part 1 #66569

merged 3 commits into from
Nov 25, 2019

Conversation

pietroalbini
Copy link
Member

This PR adds the first batch of commits in preparation for GitHub Actions:

  • Added GitHub Actions support in src/ci/shared.sh and bootstrap.
  • Addded a setup-environment.sh script which guesses and sets the DEPLOY, DEPLOY_ALT and IMAGE environment variables automatically, to reduce the verbosity of the CI configuration.

This PR does not yet add any builders on GitHub Actions.

r? @alexcrichton

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 20, 2019

📌 Commit b1463bd58327dd8d32e87c19ce3d4d3031b1e118 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2019
@pietroalbini
Copy link
Member Author

@bors try

Let's see if we can just rollup this.

@bors
Copy link
Contributor

bors commented Nov 20, 2019

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

@pietroalbini
Copy link
Member Author

@bors r- try

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 20, 2019
@bors
Copy link
Contributor

bors commented Nov 20, 2019

⌛ Trying commit b1463bd58327dd8d32e87c19ce3d4d3031b1e118 with merge f2ab2c5ecc64a7eb12d6cef52fe69f66c8abf264...

@pietroalbini
Copy link
Member Author

Of course I forgot some builders share images.

@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-11-20T17:43:40.5197553Z info: removing rustup binaries
2019-11-20T17:43:40.5197794Z info: rustup is uninstalled
2019-11-20T17:43:40.5553832Z Invalid image: dist-x86_64-linux-alt
2019-11-20T17:43:40.5582104Z 
2019-11-20T17:43:40.5680054Z ##[error]Bash exited with code '1'.
2019-11-20T17:43:40.5718248Z ##[section]Starting: Checkout
2019-11-20T17:43:40.5720336Z ==============================================================================
2019-11-20T17:43:40.5720413Z Task         : Get sources
2019-11-20T17:43:40.5720521Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Nov 20, 2019

💔 Test failed - checks-azure

@pietroalbini pietroalbini force-pushed the gha-1 branch 2 times, most recently from ab9d46b to b1a5bb0 Compare November 20, 2019 18:13
@pietroalbini
Copy link
Member Author

Changed the script to avoid setting the IMAGE if it's already set and overrode the one for dist-x86_64-linux-alt (the only one with a different one).

@bors try

@bors
Copy link
Contributor

bors commented Nov 20, 2019

⌛ Trying commit b1a5bb0 with merge b64bd82535444e83819addf25b7e92c4925ea7d7...

@bors
Copy link
Contributor

bors commented Nov 20, 2019

☀️ Try build successful - checks-azure
Build commit: b64bd82535444e83819addf25b7e92c4925ea7d7 (b64bd82535444e83819addf25b7e92c4925ea7d7)

@pietroalbini
Copy link
Member Author

@bors r=alexcrichton rollup

@bors
Copy link
Contributor

bors commented Nov 20, 2019

📌 Commit b1a5bb0 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2019
@Centril Centril mentioned this pull request Nov 20, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Nov 20, 2019
@Centril
Rollup merge of rust-lang#66569 - pietroalbini:gha-1, r=alexcrichton
7785cc4 
GitHub Actions: preparations, part 1

This PR adds the first batch of commits in preparation for GitHub Actions:

* Added GitHub Actions support in `src/ci/shared.sh` and bootstrap.
* Addded a `setup-environment.sh` script which guesses and sets the `DEPLOY`, `DEPLOY_ALT` and `IMAGE` environment variables automatically, to reduce the verbosity of the CI configuration.

This PR does **not** yet add any builders on GitHub Actions.

r? @alexcrichton
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 22, 2019
@pietroalbini
Rollup merge of rust-lang#66569 - pietroalbini:gha-1, r=alexcrichton
e3590d5 
GitHub Actions: preparations, part 1

This PR adds the first batch of commits in preparation for GitHub Actions:

* Added GitHub Actions support in `src/ci/shared.sh` and bootstrap.
* Addded a `setup-environment.sh` script which guesses and sets the `DEPLOY`, `DEPLOY_ALT` and `IMAGE` environment variables automatically, to reduce the verbosity of the CI configuration.

This PR does **not** yet add any builders on GitHub Actions.

r? @alexcrichton
@pietroalbini pietroalbini mentioned this pull request Nov 22, 2019
Closed
@pietroalbini
ci: add support for GitHub Actions in the CI scripts
262ce31
@pietroalbini
ci: guess some environment variables based on builder name and os
ee12992 
Some environment variables (like DEPLOY or DEPLOY_ALT for dist builders,
or IMAGE on Linux builders) are set on a lot of builders, and whether
they should be present or not can be detected automatically based on the
builder name and the platform.

This commit simplifies the CI configuration by automatically setting
those environment variables.
@pietroalbini
DO NOT MERGE: enable windows try builder
90a37bc
@pietroalbini
Copy link
Member Author

@bors r- try

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 22, 2019
@bors
Copy link
Contributor

bors commented Nov 22, 2019

⌛ Trying commit 90a37bc with merge 0459a65...

bors added a commit that referenced this pull request Nov 22, 2019
@bors
Auto merge of #66569 - pietroalbini:gha-1, r=<try>
0459a65 
GitHub Actions: preparations, part 1

This PR adds the first batch of commits in preparation for GitHub Actions:

* Added GitHub Actions support in `src/ci/shared.sh` and bootstrap.
* Addded a `setup-environment.sh` script which guesses and sets the `DEPLOY`, `DEPLOY_ALT` and `IMAGE` environment variables automatically, to reduce the verbosity of the CI configuration.

This PR does **not** yet add any builders on GitHub Actions.

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Nov 22, 2019

☀️ Try build successful - checks-azure
Build commit: 0459a65 (0459a65e04f24601ccc7f09655ddb5f6dd5c3d50)

@pietroalbini
Copy link
Member Author

@bors r=alexcrichton rollup

@bors
Copy link
Contributor

bors commented Nov 25, 2019

📌 Commit 90a37bc has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 25, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 25, 2019
@pietroalbini
Rollup merge of rust-lang#66569 - pietroalbini:gha-1, r=alexcrichton
1fc1a98 
GitHub Actions: preparations, part 1

This PR adds the first batch of commits in preparation for GitHub Actions:

* Added GitHub Actions support in `src/ci/shared.sh` and bootstrap.
* Addded a `setup-environment.sh` script which guesses and sets the `DEPLOY`, `DEPLOY_ALT` and `IMAGE` environment variables automatically, to reduce the verbosity of the CI configuration.

This PR does **not** yet add any builders on GitHub Actions.

r? @alexcrichton
@pietroalbini pietroalbini mentioned this pull request Nov 25, 2019
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 25, 2019
@pietroalbini
Rollup merge of rust-lang#66569 - pietroalbini:gha-1, r=alexcrichton
c75044f 
GitHub Actions: preparations, part 1

This PR adds the first batch of commits in preparation for GitHub Actions:

* Added GitHub Actions support in `src/ci/shared.sh` and bootstrap.
* Addded a `setup-environment.sh` script which guesses and sets the `DEPLOY`, `DEPLOY_ALT` and `IMAGE` environment variables automatically, to reduce the verbosity of the CI configuration.

This PR does **not** yet add any builders on GitHub Actions.

r? @alexcrichton
@pietroalbini pietroalbini mentioned this pull request Nov 25, 2019
Merged
bors added a commit that referenced this pull request Nov 25, 2019
@bors
Auto merge of #66739 - pietroalbini:rollup-2t2pd4a, r=pietroalbini
a44774c 
Rollup of 7 pull requests

Successful merges:

 - #65613 (Preserve whitespace inside one-backtick codeblocks)
 - #66512 (Add unix::process::CommandExt::arg0)
 - #66569 (GitHub Actions: preparations, part 1)
 - #66678 (Remove useless line for error index generation)
 - #66684 (Drive-by cleanup in region naming)
 - #66694 (Add some comments to panic runtime)
 - #66698 (tidy: Remove unused import)

Failed merges:

r? @ghost
@bors bors merged commit 90a37bc into rust-lang:master Nov 25, 2019
@pietroalbini pietroalbini deleted the gha-1 branch November 26, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pietroalbini @alexcrichton @bors @rust-highfive