-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a test compatible across python versions. #66396
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ |
📌 Commit f37f423 has been approved by |
Make a test compatible across python versions. Progress on rust-lang#65063 This PR allows this test to work on both python2 and python3, and it also allows `./x.py test` to fully complete on my system without python2 installed at all.
Make a test compatible across python versions. Progress on rust-lang#65063 This PR allows this test to work on both python2 and python3, and it also allows `./x.py test` to fully complete on my system without python2 installed at all.
Seems failed in #66421 (comment) |
If I'm reading that right there's no |
It's because installing The decision what to do here is up to reviewer. |
I don't know how best to fix this, but it looks like the CI environment doesn't have a |
The test failed on Linux i686-gnu but succeeded on Linux x86_64-gnu-llvm-6.0. Comparing the packages installed at src/ci/docker/i686-gnu/Dockerfile vs src/ci/docker/x86_64-gnu-llvm-6.0/Dockerfile shows these packages installed on x86_64 but not i686: g++ vs g++-multilib It looks like llvm-6.0-tools depends on python, which means we get lucky on that platform. I'm assuming something similar is true for the other successful platforms. I'll change the makefile back to calling python2.7, and that can switch when all the infrastructure updates to python3. The change to the actual python file will still help, since it won't need to be changed at that point. |
@bors: r+ |
📌 Commit 56f9212 has been approved by |
Make a test compatible across python versions. Progress on #65063 This PR allows this test to work on both python2 and python3, ~~and it also allows `./x.py test` to fully complete on my system without python2 installed at all.~~
☀️ Test successful - checks-azure |
Progress on #65063
This PR allows this test to work on both python2 and python3,
and it also allows./x.py test
to fully complete on my system without python2 installed at all.