Update clippy #66207

Manishearth · 2019-11-08T03:15:58Z

Fixes #66150

r? @ghost

Manishearth · 2019-11-08T03:16:08Z

@bors r+ p=1

bors · 2019-11-08T03:16:09Z

📌 Commit c99091bb86ad1c69c28a294f322f743886c0d423 has been approved by Manishearth

tesuji · 2019-11-08T03:18:53Z

Need another rustup here: rust-lang/rust-clippy#4792

tesuji · 2019-11-08T03:20:48Z

Also you might need to update Cargo.lock.

rust-highfive · 2019-11-08T03:20:52Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-08T03:16:33.4249800Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-08T03:16:33.4426385Z ##[command]git config gc.auto 0
2019-11-08T03:16:33.4508848Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-08T03:16:33.4560407Z ##[command]git config --get-all http.proxy
2019-11-08T03:16:33.4711374Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66207/merge:refs/remotes/pull/66207/merge
---
2019-11-08T03:19:56.4540482Z ##############                                                            20.1%
2019-11-08T03:19:56.4541293Z ######################################################################## 100.0%
2019-11-08T03:20:02.1263846Z extracting /checkout/obj/build/cache/2019-09-25/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
2019-11-08T03:20:02.2098443Z     Updating crates.io index
2019-11-08T03:20:07.8889674Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-08T03:20:07.8920803Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-08T03:20:07.8964955Z make: *** [prepare] Error 1
2019-11-08T03:20:07.8966449Z Makefile:67: recipe for target 'prepare' failed
2019-11-08T03:20:08.8985045Z Command failed. Attempt 2/5:
2019-11-08T03:20:08.8985045Z Command failed. Attempt 2/5:
2019-11-08T03:20:09.0951442Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-08T03:20:09.0968774Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-08T03:20:09.1012081Z make: *** [prepare] Error 1
2019-11-08T03:20:09.1012933Z Makefile:67: recipe for target 'prepare' failed
2019-11-08T03:20:11.1251179Z Command failed. Attempt 3/5:
2019-11-08T03:20:11.1251179Z Command failed. Attempt 3/5:
2019-11-08T03:20:11.3034796Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-08T03:20:11.3045253Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-08T03:20:11.3086968Z Makefile:67: recipe for target 'prepare' failed
2019-11-08T03:20:11.3091863Z make: *** [prepare] Error 1
2019-11-08T03:20:14.3106972Z Command failed. Attempt 4/5:
2019-11-08T03:20:14.3106972Z Command failed. Attempt 4/5:
2019-11-08T03:20:14.5197193Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-08T03:20:14.5210636Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-08T03:20:14.5256025Z Makefile:67: recipe for target 'prepare' failed
2019-11-08T03:20:14.5256570Z make: *** [prepare] Error 1
2019-11-08T03:20:18.5272076Z Command failed. Attempt 5/5:
2019-11-08T03:20:18.5272076Z Command failed. Attempt 5/5:
2019-11-08T03:20:18.7460768Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-08T03:20:18.7475402Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-08T03:20:18.7522984Z Makefile:67: recipe for target 'prepare' failed
2019-11-08T03:20:18.7523766Z make: *** [prepare] Error 1
2019-11-08T03:20:18.7524422Z The command has failed after 5 attempts.
2019-11-08T03:20:18.7524706Z == clock drift check ==
2019-11-08T03:20:18.7524706Z == clock drift check ==
2019-11-08T03:20:18.7531940Z   local time: Fri Nov  8 03:20:18 UTC 2019
2019-11-08T03:20:18.7885671Z   network time: Fri, 08 Nov 2019 03:20:18 GMT
2019-11-08T03:20:18.7890122Z == end clock drift check ==
2019-11-08T03:20:25.6786745Z 
2019-11-08T03:20:25.6920156Z ##[error]Bash exited with code '1'.
2019-11-08T03:20:25.6949431Z ##[section]Starting: Checkout
2019-11-08T03:20:25.6951437Z ==============================================================================
2019-11-08T03:20:25.6951482Z Task         : Get sources
2019-11-08T03:20:25.6951523Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Manishearth · 2019-11-08T03:21:39Z

@bors r-

rust-highfive · 2019-11-08T03:29:31Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-08T03:24:55.4111250Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-08T03:24:55.4300866Z ##[command]git config gc.auto 0
2019-11-08T03:24:55.4377941Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-08T03:24:55.4433615Z ##[command]git config --get-all http.proxy
2019-11-08T03:24:55.4599106Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66207/merge:refs/remotes/pull/66207/merge
---
2019-11-08T03:28:40.9004070Z ######################################################################## 100.0%
2019-11-08T03:28:41.3903288Z extracting /checkout/obj/build/cache/2019-09-25/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
2019-11-08T03:28:41.4810153Z     Updating crates.io index
2019-11-08T03:28:46.9276192Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-08T03:28:51.5620825Z     Updating git repository `***-clippy`
2019-11-08T03:28:56.6786898Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-08T03:28:56.6813478Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-08T03:28:56.6858316Z make: *** [prepare] Error 1
2019-11-08T03:28:56.6859042Z Makefile:67: recipe for target 'prepare' failed
2019-11-08T03:28:57.6881321Z Command failed. Attempt 2/5:
2019-11-08T03:28:57.8253964Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-08T03:28:57.8253964Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-08T03:28:58.1224989Z     Updating git repository `***-clippy`
2019-11-08T03:28:59.2179686Z     Updating crates.io index
2019-11-08T03:29:00.4642777Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-08T03:29:00.4679920Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-08T03:29:00.4726193Z make: *** [prepare] Error 1
2019-11-08T03:29:00.4726818Z Makefile:67: recipe for target 'prepare' failed
2019-11-08T03:29:02.4741367Z Command failed. Attempt 3/5:
2019-11-08T03:29:02.6662939Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-08T03:29:02.6662939Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-08T03:29:02.8960012Z     Updating git repository `***-clippy`
2019-11-08T03:29:03.1111367Z     Updating crates.io index
2019-11-08T03:29:03.3640294Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-08T03:29:03.3658385Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-08T03:29:03.3700135Z Makefile:67: recipe for target 'prepare' failed
2019-11-08T03:29:03.3703050Z make: *** [prepare] Error 1
2019-11-08T03:29:06.3717985Z Command failed. Attempt 4/5:
2019-11-08T03:29:06.5202641Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-08T03:29:06.5202641Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-08T03:29:08.6242346Z     Updating git repository `***-clippy`
2019-11-08T03:29:08.8303846Z     Updating crates.io index
2019-11-08T03:29:09.0755202Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-08T03:29:09.0774290Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-08T03:29:09.0816447Z make: *** [prepare] Error 1
2019-11-08T03:29:09.0820614Z Makefile:67: recipe for target 'prepare' failed
2019-11-08T03:29:13.0833970Z Command failed. Attempt 5/5:
2019-11-08T03:29:13.2239082Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-08T03:29:13.2239082Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-08T03:29:13.4502615Z     Updating git repository `***-clippy`
2019-11-08T03:29:13.6524019Z     Updating crates.io index
2019-11-08T03:29:13.9002370Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-08T03:29:13.9018859Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-08T03:29:13.9072427Z Makefile:67: recipe for target 'prepare' failed
2019-11-08T03:29:13.9072559Z make: *** [prepare] Error 1
2019-11-08T03:29:13.9073705Z The command has failed after 5 attempts.
2019-11-08T03:29:13.9077339Z == clock drift check ==
2019-11-08T03:29:13.9077339Z == clock drift check ==
2019-11-08T03:29:13.9090863Z   local time: Fri Nov  8 03:29:13 UTC 2019
2019-11-08T03:29:13.9799996Z   network time: Fri, 08 Nov 2019 03:29:13 GMT
2019-11-08T03:29:13.9803137Z == end clock drift check ==
2019-11-08T03:29:16.0240300Z 
2019-11-08T03:29:16.0349454Z ##[error]Bash exited with code '1'.
2019-11-08T03:29:16.0378675Z ##[section]Starting: Checkout
2019-11-08T03:29:16.0380366Z ==============================================================================
2019-11-08T03:29:16.0380425Z Task         : Get sources
2019-11-08T03:29:16.0380476Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

msizanoen1 · 2019-11-08T05:30:26Z

Please note that the clippy test still assume the test dependencies is in the host rlib directory.
This includes serde and regex which will cause the tests to fail even after rust-lang/rust-clippy#4784.
However this assumption was broken in rust-lang/rust-clippy#4714.
Also the rustbuild build system always passes the --target flag to cargo, which causes it to put the rlib into a separate directory, e.g.: target/x86_64-unknown-linux-gnu/release/deps instead of the host rlib directory: target/release/deps - even when natively compiled.
In order to fix this, both the target and host rlib directory must be in the search path.
The environment variable needed to support this is in rust-lang/rust-clippy#4786.

msizanoen1 · 2019-11-09T04:20:15Z

rust-lang/rust-clippy#4786 is merged, now you should reupdate clippy and set the TARGET_LIBS like this:
#66158 (comment)

Manishearth · 2019-11-09T18:06:39Z

@bors r+ p=2

bors · 2019-11-09T18:06:40Z

📌 Commit c337fd02221eb436dbb0a5a0816b991cbd83f7e6 has been approved by Manishearth

rust-highfive · 2019-11-09T18:11:38Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-09T18:07:09.7533354Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-09T18:07:09.7733886Z ##[command]git config gc.auto 0
2019-11-09T18:07:09.7830743Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-09T18:07:09.7886333Z ##[command]git config --get-all http.proxy
2019-11-09T18:07:10.7931775Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66207/merge:refs/remotes/pull/66207/merge
---
2019-11-09T18:10:44.5203995Z ######################################################################## 100.0%
2019-11-09T18:10:44.9800804Z extracting /checkout/obj/build/cache/2019-09-25/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
2019-11-09T18:10:45.0713340Z     Updating crates.io index
2019-11-09T18:10:51.1512750Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-09T18:10:56.9757573Z     Updating git repository `***-clippy`
2019-11-09T18:11:01.9055099Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-09T18:11:01.9089034Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-09T18:11:01.9162397Z Makefile:67: recipe for target 'prepare' failed
2019-11-09T18:11:01.9162660Z make: *** [prepare] Error 1
2019-11-09T18:11:02.9182414Z Command failed. Attempt 2/5:
2019-11-09T18:11:03.0634744Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-09T18:11:03.0634744Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-09T18:11:03.4534653Z     Updating git repository `***-clippy`
2019-11-09T18:11:04.3509084Z     Updating crates.io index
2019-11-09T18:11:04.6572772Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-09T18:11:04.6593219Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-09T18:11:04.6643431Z Makefile:67: recipe for target 'prepare' failed
2019-11-09T18:11:04.6643528Z make: *** [prepare] Error 1
2019-11-09T18:11:06.6661615Z Command failed. Attempt 3/5:
2019-11-09T18:11:06.8177624Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-09T18:11:06.8177624Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-09T18:11:07.0988773Z     Updating git repository `***-clippy`
2019-11-09T18:11:07.3496948Z     Updating crates.io index
2019-11-09T18:11:07.6311953Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-09T18:11:07.6332287Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-09T18:11:07.6385252Z Makefile:67: recipe for target 'prepare' failed
2019-11-09T18:11:07.6385331Z make: *** [prepare] Error 1
2019-11-09T18:11:10.6407144Z Command failed. Attempt 4/5:
2019-11-09T18:11:10.7954773Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-09T18:11:10.7954773Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-09T18:11:11.0677286Z     Updating git repository `***-clippy`
2019-11-09T18:11:11.3170651Z     Updating crates.io index
2019-11-09T18:11:11.6012613Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-09T18:11:11.6034537Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-09T18:11:11.6086978Z Makefile:67: recipe for target 'prepare' failed
2019-11-09T18:11:11.6087140Z make: *** [prepare] Error 1
2019-11-09T18:11:15.6119743Z Command failed. Attempt 5/5:
2019-11-09T18:11:15.7589555Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-09T18:11:15.7589555Z     Updating git repository `https://github.com/rust-lang/cargo`
2019-11-09T18:11:16.0323820Z     Updating git repository `***-clippy`
2019-11-09T18:11:16.2807941Z     Updating crates.io index
2019-11-09T18:11:16.5577093Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-11-09T18:11:16.5603013Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-11-09T18:11:16.5658437Z make: *** [prepare] Error 1
2019-11-09T18:11:16.5659163Z Makefile:67: recipe for target 'prepare' failed
2019-11-09T18:11:16.5659613Z The command has failed after 5 attempts.
2019-11-09T18:11:16.5659786Z == clock drift check ==
2019-11-09T18:11:16.5659786Z == clock drift check ==
2019-11-09T18:11:16.5667550Z   local time: Sat Nov  9 18:11:16 UTC 2019
2019-11-09T18:11:16.7150652Z   network time: Sat, 09 Nov 2019 18:11:16 GMT
2019-11-09T18:11:16.7155454Z == end clock drift check ==
2019-11-09T18:11:21.3459440Z 
2019-11-09T18:11:21.3566893Z ##[error]Bash exited with code '1'.
2019-11-09T18:11:21.3627496Z ##[section]Starting: Checkout
2019-11-09T18:11:21.3629589Z ==============================================================================
2019-11-09T18:11:21.3629848Z Task         : Get sources
2019-11-09T18:11:21.3629906Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Manishearth · 2019-11-09T18:13:04Z

@bors r+

bors · 2019-11-09T18:13:05Z

📌 Commit 4ba4552e838c851ff6c70e5eb2803195fdaaace6 has been approved by Manishearth

rust-highfive · 2019-11-09T20:34:54Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-09T18:13:38.8141241Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-09T18:13:38.8365445Z ##[command]git config gc.auto 0
2019-11-09T18:13:38.8441052Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-09T18:13:39.7835522Z ##[command]git config --get-all http.proxy
2019-11-09T18:13:39.7846700Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66207/merge:refs/remotes/pull/66207/merge
---
2019-11-09T19:51:40.0001956Z     Finished release [optimized] target(s) in 10m 36s
2019-11-09T19:53:22.3735368Z Error: there are broken links
2019-11-09T19:53:22.3737323Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/parse/struct.ParseSess.html" returned 404 Not Found
2019-11-09T19:53:22.3739207Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/parse/struct.ParseSess.html#method.buffer_lint" returned 404 Not Found
2019-11-09T19:53:22.3740111Z  Caused By: "***/tree/master/src/libsyntax/ext/tt" returned 404 Not Found
2019-11-09T19:53:22.3741503Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/fn.parse.html" returned 404 Not Found
2019-11-09T19:53:22.3742148Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_rules/" returned 404 Not Found
2019-11-09T19:53:22.3742890Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/" returned 404 Not Found
2019-11-09T19:53:22.3743476Z  Caused By: "https://github.com/rust-lang/chalk/blob/master/src/test/wf.rs" returned 404 Not Found
---
2019-11-09T20:34:48.7449173Z Verifying status of rustfmt...
2019-11-09T20:34:48.7460528Z Verifying status of clippy-driver...
2019-11-09T20:34:48.7473474Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2019-11-09T20:34:48.7483084Z 
2019-11-09T20:34:48.7484261Z ⚠️ We detected that this PR updated 'clippy-driver', but its tests failed.
2019-11-09T20:34:48.7484967Z 
2019-11-09T20:34:48.7485272Z If you do intend to update 'clippy-driver', please check the error messages above and
2019-11-09T20:34:48.7485322Z commit another update.
2019-11-09T20:34:48.7485349Z 
2019-11-09T20:34:48.7485800Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2019-11-09T20:34:48.7486083Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2019-11-09T20:34:48.7486131Z proper steps.
2019-11-09T20:34:48.7507458Z   local time: Sat Nov  9 20:34:48 UTC 2019
2019-11-09T20:34:48.9102696Z   network time: Sat, 09 Nov 2019 20:34:48 GMT
2019-11-09T20:34:48.9106505Z == end clock drift check ==
2019-11-09T20:34:49.4390108Z 
2019-11-09T20:34:49.4390108Z 
2019-11-09T20:34:49.4472644Z ##[error]Bash exited with code '3'.
2019-11-09T20:34:49.4514677Z ##[section]Starting: Checkout
2019-11-09T20:34:49.4516342Z ==============================================================================
2019-11-09T20:34:49.4516390Z Task         : Get sources
2019-11-09T20:34:49.4516448Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-11-09T20:38:46Z

⌛ Testing commit 4ba4552e838c851ff6c70e5eb2803195fdaaace6 with merge bcad43d260220ae58e1e53956230e4565cf4a830...

rust-highfive · 2019-11-09T23:00:45Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-09T22:58:20.7654402Z Verifying status of rustfmt...
2019-11-09T22:58:20.7665516Z Verifying status of clippy-driver...
2019-11-09T22:58:20.7681925Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2019-11-09T22:58:20.7695113Z 
2019-11-09T22:58:20.7695725Z ⚠️ We detected that this PR updated 'clippy-driver', but its tests failed.
2019-11-09T22:58:20.7695844Z 
2019-11-09T22:58:20.7696147Z If you do intend to update 'clippy-driver', please check the error messages above and
2019-11-09T22:58:20.7696250Z commit another update.
2019-11-09T22:58:20.7696290Z 
2019-11-09T22:58:20.7697024Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2019-11-09T22:58:20.7697365Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2019-11-09T22:58:20.7697680Z proper steps.
2019-11-09T22:58:20.7721190Z   local time: Sat Nov  9 22:58:20 UTC 2019
2019-11-09T22:58:21.0524480Z   network time: Sat, 09 Nov 2019 22:58:21 GMT
2019-11-09T22:58:21.0528559Z == end clock drift check ==
2019-11-09T22:58:21.6894979Z 
2019-11-09T22:58:21.6894979Z 
2019-11-09T22:58:21.7000217Z ##[error]Bash exited with code '3'.
2019-11-09T22:58:21.7034034Z ##[section]Starting: Checkout
2019-11-09T22:58:21.7035740Z ==============================================================================
2019-11-09T22:58:21.7035815Z Task         : Get sources
2019-11-09T22:58:21.7035900Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-11-09T23:00:59Z

💔 Test failed - checks-azure

rust-highfive · 2019-11-10T20:47:18Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-11-10T20:47:27Z

💔 Test failed - checks-azure

Manishearth · 2019-11-10T21:42:52Z

cc @pietroalbini something seems wrong there ^^

msizanoen1 · 2019-11-11T05:41:31Z

https://developer.apple.com/documentation/security/1503828-secure_transport_result_codes/errsslclosedabort?language=objc

msizanoen1 · 2019-11-11T05:42:08Z

Also it took an hour and 30 minutes before failing.

Manishearth · 2019-11-11T05:46:32Z

@bors retry

i guess that server is just wonky

bors · 2019-11-11T05:59:53Z

⌛ Testing commit a498d2848ba7f3caf588c01a0a6ce4c84283100d with merge 6d07f23dbba0beb2b7ac6f23dc28d55e68e7386f...

Manishearth · 2019-11-11T06:11:16Z

@bors r-

needs rust-lang/rust-clippy#4802

Centril · 2019-11-11T06:29:09Z

Updated to clippy HEAD. @bors r+ retry

bors · 2019-11-11T06:29:10Z

📌 Commit 955f861 has been approved by Centril

bors · 2019-11-11T06:29:21Z

⌛ Testing commit 955f861 with merge 2a9be46...

@ghost

Update clippy Fixes #66150 r? @ghost

bors · 2019-11-11T09:40:28Z

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 2a9be46 to master...

rust-highfive · 2019-11-11T09:41:45Z

📣 Toolstate changed by #66207!

Tested on commit 2a9be46.
Direct link to PR: #66207

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

@mcarton

Tested on commit rust-lang/rust@2a9be46. Direct link to PR: <rust-lang/rust#66207> 🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 8, 2019

Manishearth mentioned this pull request Nov 8, 2019

update clippy to fix toolstate #66158

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 8, 2019

Manishearth force-pushed the clippyup branch from c99091b to 2fd966e Compare November 8, 2019 03:22

Manishearth force-pushed the clippyup branch 2 times, most recently from 1b8e8c1 to c337fd0 Compare November 9, 2019 18:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 9, 2019

Manishearth force-pushed the clippyup branch from c337fd0 to 4ba4552 Compare November 9, 2019 18:13

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 9, 2019

bors mentioned this pull request Nov 10, 2019

Add a HIR pass to check consts for if, loop, etc. #66170

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 10, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 11, 2019

Update clippy

955f861

Centril force-pushed the clippyup branch from a498d28 to 955f861 Compare November 11, 2019 06:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 11, 2019

bors added a commit that referenced this pull request Nov 11, 2019

Auto merge of #66207 - Manishearth:clippyup, r=Centril

2a9be46

Update clippy Fixes #66150 r? @ghost

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 11, 2019

bors merged commit 955f861 into rust-lang:master Nov 11, 2019

msizanoen1 mentioned this pull request Nov 11, 2019

Tools are not available on cross compiled platforms since #61861 #62558

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update clippy #66207

Update clippy #66207

Manishearth commented Nov 8, 2019

Manishearth commented Nov 8, 2019

bors commented Nov 8, 2019

tesuji commented Nov 8, 2019

tesuji commented Nov 8, 2019

rust-highfive commented Nov 8, 2019

Manishearth commented Nov 8, 2019

rust-highfive commented Nov 8, 2019

msizanoen1 commented Nov 8, 2019 •

edited

Loading

msizanoen1 commented Nov 9, 2019

Manishearth commented Nov 9, 2019

bors commented Nov 9, 2019

rust-highfive commented Nov 9, 2019

Manishearth commented Nov 9, 2019

bors commented Nov 9, 2019

rust-highfive commented Nov 9, 2019

bors commented Nov 9, 2019

rust-highfive commented Nov 9, 2019

bors commented Nov 9, 2019

rust-highfive commented Nov 10, 2019

bors commented Nov 10, 2019

Manishearth commented Nov 10, 2019

msizanoen1 commented Nov 11, 2019

msizanoen1 commented Nov 11, 2019

Manishearth commented Nov 11, 2019

bors commented Nov 11, 2019

Manishearth commented Nov 11, 2019

Centril commented Nov 11, 2019

bors commented Nov 11, 2019

bors commented Nov 11, 2019

bors commented Nov 11, 2019

rust-highfive commented Nov 11, 2019

Update clippy #66207

Update clippy #66207

Conversation

Manishearth commented Nov 8, 2019

Manishearth commented Nov 8, 2019

bors commented Nov 8, 2019

tesuji commented Nov 8, 2019

tesuji commented Nov 8, 2019

rust-highfive commented Nov 8, 2019

Manishearth commented Nov 8, 2019

rust-highfive commented Nov 8, 2019

msizanoen1 commented Nov 8, 2019 • edited Loading

msizanoen1 commented Nov 9, 2019

Manishearth commented Nov 9, 2019

bors commented Nov 9, 2019

rust-highfive commented Nov 9, 2019

Manishearth commented Nov 9, 2019

bors commented Nov 9, 2019

rust-highfive commented Nov 9, 2019

bors commented Nov 9, 2019

rust-highfive commented Nov 9, 2019

bors commented Nov 9, 2019

rust-highfive commented Nov 10, 2019

bors commented Nov 10, 2019

Manishearth commented Nov 10, 2019

msizanoen1 commented Nov 11, 2019

msizanoen1 commented Nov 11, 2019

Manishearth commented Nov 11, 2019

bors commented Nov 11, 2019

Manishearth commented Nov 11, 2019

Centril commented Nov 11, 2019

bors commented Nov 11, 2019

bors commented Nov 11, 2019

bors commented Nov 11, 2019

rust-highfive commented Nov 11, 2019

msizanoen1 commented Nov 8, 2019 •

edited

Loading