Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect :: -> : typo when involving turbofish #66098

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Detect :: -> : typo when involving turbofish #66098

merged 2 commits into from
Nov 6, 2019

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Nov 5, 2019

Fix #65569.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2019
@estebank
Copy link
Contributor Author

estebank commented Nov 5, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned eddyb Nov 5, 2019
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2019
@estebank
Copy link
Contributor Author

estebank commented Nov 5, 2019

@bors r=Centril

@Centril feel free to revoke if the new commit has something you'd want changed.

@bors
Copy link
Contributor

bors commented Nov 5, 2019

📌 Commit a8ccbf5 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 5, 2019
@Centril
Rollup merge of rust-lang#66098 - estebank:path-asciption-typo, r=Cen…
defb251 
…tril

Detect `::` -> `:` typo when involving turbofish

Fix rust-lang#65569.
@Centril Centril mentioned this pull request Nov 5, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Nov 6, 2019
@Centril
Rollup merge of rust-lang#66098 - estebank:path-asciption-typo, r=Cen…
409b2bf 
…tril

Detect `::` -> `:` typo when involving turbofish

Fix rust-lang#65569.
@Centril Centril mentioned this pull request Nov 6, 2019
Merged
bors added a commit that referenced this pull request Nov 6, 2019
@bors
Auto merge of #66141 - Centril:rollup-n2fcvp9, r=Centril
e4931ea 
Rollup of 11 pull requests

Successful merges:

 - #65892 (Remove `PartialEq` and `Eq` from the `SpecialDerives`.)
 - #66014 (Show type parameter name and definition in type mismatch error messages )
 - #66027 (Move has_panic_handler to query)
 - #66054 (syntax: Avoid span arithmetic for delimiter tokens)
 - #66068 (use silent emitter for rustdoc highlighting pass)
 - #66081 (let caller of check_ptr_access_align control the error message)
 - #66093 (Do not ICE with a precision flag in formatting str and no format arguments)
 - #66098 (Detect `::` -> `:` typo when involving turbofish)
 - #66101 (Tweak type mismatch caused by break on tail expr)
 - #66106 (Fix typo in explanation of `E0080`)
 - #66115 (rustc: remove "GlobalMetaData" dead code from hir::map::definitions.)

Failed merges:

r? @ghost
@bors bors merged commit a8ccbf5 into rust-lang:master Nov 6, 2019
@SimonSapin SimonSapin mentioned this pull request Nov 12, 2019
Closed
@estebank estebank deleted the path-asciption-typo branch November 9, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

::→: typo in turbofish doesn't have a good error
5 participants
@estebank @rust-highfive @bors @Centril @eddyb