Cheaper doc comments #65750
Merged
Cheaper doc comments #65750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 0b907f7ed55cd4b79ccb380e68fcca0dacc0f0e2 with merge b773dddc5a6434753e502b8beb1868fd476103f8... |
This was referenced Oct 24, 2019
|
@Manishearth, @nrc: this PR will affect Clippy and rustfmt. |
nnethercote
force-pushed
the
cheaper-doc-comments
branch
from
0b907f7 to
42bac15
Compare
petrochenkov
added
the
S-waiting-on-review
|
@rust-timer build b773dddc5a6434753e502b8beb1868fd476103f8 |
|
Queued b773dddc5a6434753e502b8beb1868fd476103f8 with parent 4a8c5b2, future comparison URL. |
|
Finished benchmarking try commit b773dddc5a6434753e502b8beb1868fd476103f8, comparison URL. |
|
Perf results are excellent, as expected. |
|
📌 Commit 42bac153bb9e9baaf30f9aaa2830faf69042ac99 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=never (perf) |
|
@bors r- |
bors
added
S-waiting-on-author
|
Sure -- I don't mind. |
|
cc @topecongiro for possible rustfmt breakage |
|
☔ The latest upstream changes (presumably #65804) made this pull request unmergeable. Please resolve the merge conflicts. |
nnethercote
force-pushed
the
cheaper-doc-comments
branch
from
42bac15 to
7afba1a
Compare
|
I have rebased. |
This kind of thing just makes the code harder to read.
`AttrKind` is a new type with two variants, `Normal` and `DocComment`. It's a
big performance win (over 10% in some cases) because `DocComment` lets doc
comments (which are common) be represented very cheaply.
`Attribute` gets some new helper methods to ease the transition:
- `has_name()`: check if the attribute name matches a single `Symbol`; for
`DocComment` variants it succeeds if the symbol is `sym::doc`.
- `is_doc_comment()`: check if it has a `DocComment` kind.
- `{get,unwrap}_normal_item()`: extract the item from a `Normal` variant;
panic otherwise.
Fixes rust-lang#60935.
nnethercote
force-pushed
the
cheaper-doc-comments
branch
from
9964212 to
eea6f23
Compare
|
@bors r=petrochenkov |
|
📌 Commit eea6f23 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 7, 2019
Cheaper doc comments This PR implements the idea from #60935: represent doc comments more cheaply, rather than converting them into `#[doc="..."]` attribute form. Unlike #60936 (which is about coalescing doc comments to reduce their number), this approach does not have any backwards compatibility concerns, and it eliminates about 80-90% of the current cost of doc comments (as estimated using the numbers in #60930, which eliminated the cost of doc comments entirely by treating them as normal comments). r? @petrochenkov
|
☀️ Test successful - checks-azure |
This was referenced Nov 7, 2019
msizanoen1
added a commit
to msizanoen1/rust-clippy
that referenced
this pull request
Nov 7, 2019
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 3, 2019
syntax: Unify macro and attribute arguments in AST The unified form (`ast::MacArgs`) represents parsed arguments instead of an unstructured token stream that was previously used for attributes. It also tracks some spans and delimiter kinds better for fn-like macros and macro definitions. I've been talking about implementing this with @nnethercote in rust-lang#65750 (comment). The parsed representation is closer to `MetaItem` and requires less token juggling during conversions, so it potentially may be faster. r? @Centril
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 3, 2019
syntax: Unify macro and attribute arguments in AST The unified form (`ast::MacArgs`) represents parsed arguments instead of an unstructured token stream that was previously used for attributes. It also tracks some spans and delimiter kinds better for fn-like macros and macro definitions. I've been talking about implementing this with @nnethercote in rust-lang#65750 (comment). The parsed representation is closer to `MetaItem` and requires less token juggling during conversions, so it potentially may be faster. r? @Centril
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 14, 2019
doc comments: Less attribute mimicking Make sure doc comments are not converted into intermediate meta-items, or not mixed with `doc(inline)` or something like that. Follow-up to rust-lang#65750.
bors
added a commit
that referenced
this pull request
Dec 28, 2019
doc comments: Less attribute mimicking Make sure doc comments are not converted into intermediate meta-items, or not mixed with `doc(inline)` or something like that. Follow-up to #65750.
calebcartwright
added a commit
to calebcartwright/rustfmt
that referenced
this pull request
Jan 16, 2020
Implements changes required post rust-lang/rust#65750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the idea from #60935: represent doc comments more cheaply, rather than converting them into
#[doc="..."]attribute form. Unlike #60936 (which is about coalescing doc comments to reduce their number), this approach does not have any backwards compatibility concerns, and it eliminates about 80-90% of the current cost of doc comments (as estimated using the numbers in #60930, which eliminated the cost of doc comments entirely by treating them as normal comments).r? @petrochenkov