Correctly note code as Ok not error for E0573 #65620
Conversation
|
Some changes occurred in diagnostic error codes |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
| @@ -1682,7 +1682,7 @@ enum Wizard { | |||
| } | |||
|
|
|||
| trait Isengard { | |||
| fn wizard(w: Wizard) { // error! | |||
There was a problem hiding this comment.
Please replace "// error!" with "// ok!"
There was a problem hiding this comment.
done! c1422e68eaea6ec9e20da9ca2c6aae1febd002a8
|
@ryoqun: great, if you could squash your two commits into one, this looks good to go! |
ryoqun
force-pushed
the
remove-unneeded-comment
branch
from
c1422e6 to
b56b8a2
Compare
ryoqun
force-pushed
the
remove-unneeded-comment
branch
from
b56b8a2 to
101e1f6
Compare
|
@varkor Thanks! I squashed! |
|
📌 Commit 101e1f6 has been approved by |
bors
added
S-waiting-on-bors
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 101e1f6 has been approved by |
ryoqun
changed the title
…arkor Correctly note code as Ok not error for E0573 Hi, this is my first pull request to the Rust project. The fix is very small one just to fix an oversight in a comment. Namely, [this documentation PR](rust-lang#65234) added a longer explanation for E0573. It illustrated the error using erroneous/corrected contrasting examples. But it accidentally forgot to remove `// error` from the corrected example. Sadly, I found the error after the PR got merged. [As suggested by the original author](https://github.com/rust-lang/rust/pull/65234/files#r336518549) of the PR, I created an PR to fix this. Part of rust-lang#61137.
Rollup of 5 pull requests Successful merges: - #65544 (Added doc on keyword break) - #65620 (Correctly note code as Ok not error for E0573) - #65624 ([mir-opt] Improve SimplifyLocals pass so it can remove unused consts) - #65650 (use unwrap_or in lint code) - #65652 (Fix `canonicalize_const_var` leaking inference variables) Failed merges: r? @ghost
Rollup of 5 pull requests Successful merges: - #65544 (Added doc on keyword break) - #65620 (Correctly note code as Ok not error for E0573) - #65624 ([mir-opt] Improve SimplifyLocals pass so it can remove unused consts) - #65650 (use unwrap_or in lint code) - #65652 (Fix `canonicalize_const_var` leaking inference variables) Failed merges: r? @ghost
Hi, this is my first pull request to the Rust project.
The fix is very small one just to fix an oversight in a comment.
Namely, this documentation PR added a longer explanation for E0573. It illustrated the error using erroneous/corrected contrasting examples. But it accidentally forgot to remove
// errorfrom the corrected example.Sadly, I found the error after the PR got merged. As suggested by the original author of the PR, I created an PR to fix this.
Part of #61137.