docs: improve disclaimer regarding LinkedList #65574

tshepang · 2019-10-18T21:20:29Z

No description provided.

rust-highfive · 2019-10-18T21:20:33Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-10-19T00:02:41Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-18T22:08:10.7445491Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-18T22:08:10.7651487Z ##[command]git config gc.auto 0
2019-10-18T22:08:10.7740310Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-18T22:08:10.7805156Z ##[command]git config --get-all http.proxy
2019-10-18T22:08:10.7962545Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65574/merge:refs/remotes/pull/65574/merge
---
2019-10-18T23:11:16.2777329Z .................................................................................................... 1600/9196
2019-10-18T23:11:21.6809119Z .................................................................................................... 1700/9196
2019-10-18T23:11:34.9809878Z .............................i...............i...................................................... 1800/9196
2019-10-18T23:11:42.7175898Z .................................................................................................... 1900/9196
2019-10-18T23:11:57.2985452Z ...................iiiii............................................................................ 2000/9196
2019-10-18T23:12:08.1531684Z .................................................................................................... 2200/9196
2019-10-18T23:12:10.7999319Z .................................................................................................... 2300/9196
2019-10-18T23:12:16.3013879Z .................................................................................................... 2400/9196
2019-10-18T23:12:38.8010006Z .................................................................................................... 2500/9196
---
2019-10-18T23:15:39.8497719Z ......................i...............i............................................................. 4800/9196
2019-10-18T23:15:51.8128638Z .................................................................................................... 4900/9196
2019-10-18T23:15:58.4226623Z .................................................................................................... 5000/9196
2019-10-18T23:16:09.2652796Z .................................................................................................... 5100/9196
2019-10-18T23:16:15.9110655Z ......................ii.ii......................................................................... 5200/9196
2019-10-18T23:16:26.8970653Z .................................................................................................... 5400/9196
2019-10-18T23:16:37.3286206Z ........................................................................................i........... 5500/9196
2019-10-18T23:16:45.7989358Z .................................................................................................... 5600/9196
2019-10-18T23:16:51.1131277Z .................................................................................................... 5700/9196
2019-10-18T23:16:51.1131277Z .................................................................................................... 5700/9196
2019-10-18T23:17:02.0509973Z .....................................................................................ii...i..ii..... 5800/9196
2019-10-18T23:17:29.5965532Z .................................................................................................... 6000/9196
2019-10-18T23:17:38.2196089Z .................................................................................................... 6100/9196
2019-10-18T23:17:43.0714003Z .................................................................................................... 6200/9196
2019-10-18T23:17:43.0714003Z .................................................................................................... 6200/9196
2019-10-18T23:17:57.7261574Z .......i..ii........................................................................................ 6300/9196
2019-10-18T23:18:18.2441835Z ...................................................................i................................ 6500/9196
2019-10-18T23:18:20.5318614Z .................................................................................................... 6600/9196
2019-10-18T23:18:23.1241224Z .........................................i.......................................................... 6700/9196
2019-10-18T23:18:27.2076483Z .................................................................................................... 6800/9196
---
2019-10-18T23:23:07.4836102Z  finished in 5.556
2019-10-18T23:23:07.5059875Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-18T23:23:07.6736551Z 
2019-10-18T23:23:07.6736870Z running 153 tests
2019-10-18T23:23:11.0569899Z i....iii......iii..iiii...i.............................i..i..................i....i...........ii.i. 100/153
2019-10-18T23:23:13.2082876Z i..iiii..............i.........iii.i.........ii......
2019-10-18T23:23:13.2083887Z 
2019-10-18T23:23:13.2088903Z  finished in 5.703
2019-10-18T23:23:13.2286224Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-18T23:23:13.4118835Z 
---
2019-10-18T23:23:15.5883277Z  finished in 2.359
2019-10-18T23:23:15.6115741Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-18T23:23:15.7801735Z 
2019-10-18T23:23:15.7802448Z running 9 tests
2019-10-18T23:23:15.7803632Z iiiiiiiii
2019-10-18T23:23:15.7804101Z 
2019-10-18T23:23:15.7804148Z  finished in 0.168
2019-10-18T23:23:15.8011538Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-18T23:23:15.9859964Z 
---
2019-10-18T23:23:34.9887480Z  finished in 19.187
2019-10-18T23:23:35.0103493Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-18T23:23:35.1755691Z 
2019-10-18T23:23:35.1755974Z running 123 tests
2019-10-18T23:24:00.1100238Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-18T23:24:04.9698551Z i.i.i......iii.i.....ii
2019-10-18T23:24:04.9699200Z 
2019-10-18T23:24:04.9707512Z  finished in 29.960
2019-10-18T23:24:04.9720791Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-18T23:24:04.9721149Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-10-18T23:37:35.7673213Z 
2019-10-18T23:37:35.7674335Z    Doc-tests core
2019-10-18T23:37:41.1061185Z 
2019-10-18T23:37:41.1061760Z running 2406 tests
2019-10-18T23:37:52.7095605Z ......iiiii......................................................................................... 100/2406
2019-10-18T23:38:04.1632709Z ................................................................................ii.................. 200/2406
2019-10-18T23:38:31.2335808Z ..i................................................................................................. 400/2406
2019-10-18T23:38:31.2335808Z ..i................................................................................................. 400/2406
2019-10-18T23:38:42.2004536Z .................................................i..i.................iiii.......................... 500/2406
2019-10-18T23:39:03.5101622Z .................................................................................................... 700/2406
2019-10-18T23:39:15.0797986Z .................................................................................................... 800/2406
2019-10-18T23:39:26.0573049Z .................................................................................................... 900/2406
2019-10-18T23:39:37.0964627Z .................................................................................................... 1000/2406
---
2019-10-18T23:43:51.1300350Z .................................................................................................... 500/763
2019-10-18T23:43:51.1607075Z ....................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-18T23:43:51.1639288Z ....thread 'thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1165:5
2019-10-18T23:43:51.1645336Z <unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-18T23:43:51.1671146Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-18T23:43:51.4227169Z ..........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-18T23:43:51.4258905Z ....thread '<unnamed>' panicked at '.called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:.5
2019-10-18T23:43:51.4287101Z .....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-18T23:43:53.4818238Z ...........................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:629:13
2019-10-18T23:43:53.4820750Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:584:13
2019-10-18T23:43:53.4824016Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:561:13
2019-10-18T23:43:53.4827395Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:689:13
---
2019-10-18T23:44:02.9869151Z 
2019-10-18T23:44:02.9869445Z running 994 tests
2019-10-18T23:44:25.8502554Z i................................................................................................... 100/994
2019-10-18T23:44:38.2889469Z .................................................................................................... 200/994
2019-10-18T23:44:47.1332818Z ...................iii......i......i...i......i..................................................... 300/994
2019-10-18T23:44:53.1105458Z .................................................................................................... 400/994
2019-10-18T23:45:01.2926503Z .....................................i..i.................................ii........................ 500/994
2019-10-18T23:45:16.8446275Z .................................................................................................... 700/994
2019-10-18T23:45:16.8446275Z .................................................................................................... 700/994
2019-10-18T23:45:25.4775650Z ....................iiii............................................................................ 800/994
2019-10-18T23:45:41.5332420Z .................................................................................................... 900/994
2019-10-18T23:45:49.7485383Z ..........................................iiii................................................
2019-10-18T23:45:49.7486797Z 
2019-10-18T23:45:49.7550188Z  finished in 206.532
2019-10-18T23:45:49.7566401Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-18T23:45:49.9803322Z    Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-10-19T00:02:00.0118027Z Rustbook (x86_64-unknown-linux-gnu) - edition-guide
2019-10-19T00:02:00.3752789Z Building stage0 tool linkchecker (x86_64-unknown-linux-gnu)
2019-10-19T00:02:00.5440665Z    Compiling linkchecker v0.1.0 (/checkout/src/tools/linkchecker)
2019-10-19T00:02:02.7502358Z     Finished release [optimized] target(s) in 2.37s
2019-10-19T00:02:03.5025214Z std/collections/linked_list/struct.LinkedList.html:4: broken link - std/collections/vec/struct.Vec.html
2019-10-19T00:02:03.5191519Z std/collections/struct.LinkedList.html:4: broken link - std/vec_deque/struct.VecDeque.html
2019-10-19T00:02:10.5054608Z alloc/collections/linked_list/struct.LinkedList.html:4: broken link - alloc/collections/vec/struct.Vec.html
2019-10-19T00:02:11.8359725Z thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:41:9
2019-10-19T00:02:11.8368264Z 
2019-10-19T00:02:11.8368479Z 
2019-10-19T00:02:11.8369204Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
2019-10-19T00:02:11.8369458Z expected success, got: exit code: 101
---
2019-10-19T00:02:11.8370486Z   local time: Sat Oct 19 00:02:11 UTC 2019
2019-10-19T00:02:11.8370668Z   network time: Sat, 19 Oct 2019 00:02:11 GMT
2019-10-19T00:02:11.8370828Z == end clock drift check ==
2019-10-19T00:02:14.2319482Z 
2019-10-19T00:02:14.2442570Z ##[error]Bash exited with code '1'.
2019-10-19T00:02:14.2484924Z ##[section]Starting: Checkout
2019-10-19T00:02:14.2487134Z ==============================================================================
2019-10-19T00:02:14.2487183Z Task         : Get sources
2019-10-19T00:02:14.2487224Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/liballoc/collections/linked_list.rs

Centril · 2019-10-19T04:06:40Z

r? @Centril

Centril · 2019-10-26T15:33:11Z

r=me rollup when green.

Centril · 2019-10-26T15:33:57Z

(Also, note for the future: It's best to avoid @-pinging folks since it tends to generate more notifications when rebasing etc.)

rust-highfive · 2019-10-26T17:21:13Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-26T15:32:01.2315825Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-26T15:32:01.2534681Z ##[command]git config gc.auto 0
2019-10-26T15:32:01.2609843Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-26T15:32:01.2672625Z ##[command]git config --get-all http.proxy
2019-10-26T15:32:01.2862495Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65574/merge:refs/remotes/pull/65574/merge
---
2019-10-26T16:32:48.8838969Z .................................................................................................... 1600/9251
2019-10-26T16:32:54.4478931Z .................................................................................................... 1700/9251
2019-10-26T16:33:07.1676223Z ........................................................i...............i........................... 1800/9251
2019-10-26T16:33:14.8714205Z .................................................................................................... 1900/9251
2019-10-26T16:33:29.9386748Z ..............................................iiiii................................................. 2000/9251
2019-10-26T16:33:40.8425094Z .................................................................................................... 2200/9251
2019-10-26T16:33:43.4074474Z .................................................................................................... 2300/9251
2019-10-26T16:33:47.2812744Z .................................................................................................... 2400/9251
2019-10-26T16:34:10.6186717Z .................................................................................................... 2500/9251
---
2019-10-26T16:37:03.6294208Z .................................................i...............i.................................. 4800/9251
2019-10-26T16:37:12.7887787Z .................................................................................................... 4900/9251
2019-10-26T16:37:21.3993206Z .................................................................................................... 5000/9251
2019-10-26T16:37:27.6683036Z .................................................................................................... 5100/9251
2019-10-26T16:37:38.3242306Z ..................................................ii.ii...........i................................. 5200/9251
2019-10-26T16:37:48.1344337Z .................................................................................................... 5400/9251
2019-10-26T16:37:57.5288028Z .................................................................................................... 5500/9251
2019-10-26T16:38:05.3823694Z ....................i............................................................................... 5600/9251
2019-10-26T16:38:10.9817365Z .................................................................................................... 5700/9251
2019-10-26T16:38:10.9817365Z .................................................................................................... 5700/9251
2019-10-26T16:38:23.2407220Z .................................................................................................... 5800/9251
2019-10-26T16:38:34.4036968Z .................ii...i..ii...........i............................................................. 5900/9251
2019-10-26T16:38:56.1238409Z .................................................................................................... 6100/9251
2019-10-26T16:39:02.0672212Z .................................................................................................... 6200/9251
2019-10-26T16:39:02.0672212Z .................................................................................................... 6200/9251
2019-10-26T16:39:14.9855971Z ........................................i..ii....................................................... 6300/9251
2019-10-26T16:39:37.2415089Z .................................................................................................... 6500/9251
2019-10-26T16:39:39.5215622Z ......i............................................................................................. 6600/9251
2019-10-26T16:39:42.2484031Z .................................................................................i.................. 6700/9251
2019-10-26T16:39:44.8457725Z .................................................................................................... 6800/9251
---
2019-10-26T16:44:17.9573340Z  finished in 5.761
2019-10-26T16:44:17.9754388Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-26T16:44:18.1893565Z 
2019-10-26T16:44:18.1894810Z running 153 tests
2019-10-26T16:44:21.3559870Z i....iii......iii..iiii...i.............................i..i..................i....i...........ii.i. 100/153
2019-10-26T16:44:23.2895051Z i..iiii..............i.........iii.i.........ii......
2019-10-26T16:44:23.2895636Z 
2019-10-26T16:44:23.2900981Z  finished in 5.314
2019-10-26T16:44:23.3084853Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-26T16:44:23.4697166Z 
---
2019-10-26T16:44:25.5046258Z  finished in 2.196
2019-10-26T16:44:25.5221905Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-26T16:44:25.6816166Z 
2019-10-26T16:44:25.6817574Z running 9 tests
2019-10-26T16:44:25.6818495Z iiiiiiiii
2019-10-26T16:44:25.6818903Z 
2019-10-26T16:44:25.6818980Z  finished in 0.159
2019-10-26T16:44:25.7006205Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-26T16:44:25.8805418Z 
---
2019-10-26T16:44:44.2067398Z  finished in 18.506
2019-10-26T16:44:44.3102238Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-26T16:44:44.4984472Z 
2019-10-26T16:44:44.4984984Z running 123 tests
2019-10-26T16:45:09.1508383Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-26T16:45:14.0631964Z i.i.i......iii.i.....ii
2019-10-26T16:45:14.0633319Z 
2019-10-26T16:45:14.0637939Z  finished in 29.753
2019-10-26T16:45:14.0648416Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-26T16:45:14.0648818Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-10-26T16:57:47.8012510Z 
2019-10-26T16:57:47.8016921Z    Doc-tests core
2019-10-26T16:57:53.0203762Z 
2019-10-26T16:57:53.0204590Z running 2408 tests
2019-10-26T16:58:04.0792042Z ......iiiii......................................................................................... 100/2408
2019-10-26T16:58:14.7931810Z ................................................................................ii.................. 200/2408
2019-10-26T16:58:40.4418860Z ..i................................................................................................. 400/2408
2019-10-26T16:58:40.4418860Z ..i................................................................................................. 400/2408
2019-10-26T16:58:50.9202884Z .................................................i..i.................iiii.......................... 500/2408
2019-10-26T16:59:11.3347590Z .................................................................................................... 700/2408
2019-10-26T16:59:21.7039336Z .................................................................................................... 800/2408
2019-10-26T16:59:32.1126330Z .................................................................................................... 900/2408
2019-10-26T16:59:42.3857137Z .................................................................................................... 1000/2408
---
2019-10-26T17:03:42.3751406Z ............................................... 300/763
2019-10-26T17:03:42.3753778Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/stdio.rs:854:13
2019-10-26T17:03:42.4164942Z .................................................................................................... 400/763
2019-10-26T17:03:44.5106434Z .................................................................................................... 500/763
2019-10-26T17:03:44.5392145Z ....................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-26T17:03:44.5418686Z ....thread 'thread '<unnamed><unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1165:5
2019-10-26T17:03:44.5436920Z .' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-26T17:03:44.5477587Z ......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-26T17:03:44.8039670Z ............................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-26T17:03:44.8054088Z ....thread 'thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-26T17:03:44.8062785Z <unnamed>.' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1165:5
2019-10-26T17:03:44.8076461Z .....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-26T17:03:46.8567325Z ......................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:629:13
2019-10-26T17:03:46.8576007Z ......thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:584:13
2019-10-26T17:03:46.8577901Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:561:13
2019-10-26T17:03:46.8583601Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:689:13
---
2019-10-26T17:03:56.3437126Z 
2019-10-26T17:03:56.3437469Z running 997 tests
2019-10-26T17:04:18.0654927Z i................................................................................................... 100/997
2019-10-26T17:04:29.8705857Z .................................................................................................... 200/997
2019-10-26T17:04:38.2485667Z ...................iii......i......i...i......i..................................................... 300/997
2019-10-26T17:04:43.9983762Z .................................................................................................... 400/997
2019-10-26T17:04:51.7743923Z ........................................i..i.................................ii..................... 500/997
2019-10-26T17:05:06.7031042Z .................................................................................................... 700/997
2019-10-26T17:05:06.7031042Z .................................................................................................... 700/997
2019-10-26T17:05:14.5342381Z .......................iiii......................................................................... 800/997
2019-10-26T17:05:30.4374726Z .................................................................................................... 900/997
2019-10-26T17:05:38.3221655Z .............................................iiii................................................
2019-10-26T17:05:38.3221950Z 
2019-10-26T17:05:38.3341096Z  finished in 197.219
2019-10-26T17:05:38.3354917Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-26T17:05:38.5476946Z    Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-10-26T17:20:51.4443619Z Rustbook (x86_64-unknown-linux-gnu) - edition-guide
2019-10-26T17:20:51.8399573Z Building stage0 tool linkchecker (x86_64-unknown-linux-gnu)
2019-10-26T17:20:52.3698555Z    Compiling linkchecker v0.1.0 (/checkout/src/tools/linkchecker)
2019-10-26T17:20:54.2082880Z     Finished release [optimized] target(s) in 2.36s
2019-10-26T17:20:54.8066965Z std/collections/linked_list/struct.LinkedList.html:4: broken link - std/collections/vec/struct.Vec.html
2019-10-26T17:20:54.8192205Z std/collections/struct.LinkedList.html:4: broken link - std/vec_deque/struct.VecDeque.html
2019-10-26T17:21:01.4804071Z alloc/collections/linked_list/struct.LinkedList.html:4: broken link - alloc/collections/vec/struct.Vec.html
2019-10-26T17:21:02.5356236Z thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:41:9
2019-10-26T17:21:02.5358500Z 
2019-10-26T17:21:02.5358868Z 
2019-10-26T17:21:02.5361194Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
2019-10-26T17:21:02.5362820Z expected success, got: exit code: 101
---
2019-10-26T17:21:02.5457875Z   local time: Sat Oct 26 17:21:02 UTC 2019
2019-10-26T17:21:02.8221170Z   network time: Sat, 26 Oct 2019 17:21:02 GMT
2019-10-26T17:21:02.8221883Z == end clock drift check ==
2019-10-26T17:21:05.8929990Z 
2019-10-26T17:21:05.9035347Z ##[error]Bash exited with code '1'.
2019-10-26T17:21:05.9085785Z ##[section]Starting: Checkout
2019-10-26T17:21:05.9087577Z ==============================================================================
2019-10-26T17:21:05.9087642Z Task         : Get sources
2019-10-26T17:21:05.9087696Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-10-27T20:37:51Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-27T18:53:12.8593980Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-27T18:53:12.8797168Z ##[command]git config gc.auto 0
2019-10-27T18:53:12.8854506Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-27T18:53:12.8908911Z ##[command]git config --get-all http.proxy
2019-10-27T18:53:12.9034127Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65574/merge:refs/remotes/pull/65574/merge
---
2019-10-27T19:51:37.6376413Z .................................................................................................... 1600/9253
2019-10-27T19:51:43.2181067Z .................................................................................................... 1700/9253
2019-10-27T19:51:55.2106424Z ..........................................................i...............i......................... 1800/9253
2019-10-27T19:52:02.5745317Z .................................................................................................... 1900/9253
2019-10-27T19:52:16.7588964Z ................................................iiiii............................................... 2000/9253
2019-10-27T19:52:27.1992898Z .................................................................................................... 2200/9253
2019-10-27T19:52:29.6453324Z .................................................................................................... 2300/9253
2019-10-27T19:52:33.1311820Z .................................................................................................... 2400/9253
2019-10-27T19:52:55.6609979Z .................................................................................................... 2500/9253
---
2019-10-27T19:55:41.4441996Z ...................................................i...............i................................ 4800/9253
2019-10-27T19:55:50.0879837Z .................................................................................................... 4900/9253
2019-10-27T19:55:58.6176756Z .................................................................................................... 5000/9253
2019-10-27T19:56:04.5689073Z .................................................................................................... 5100/9253
2019-10-27T19:56:14.7242958Z ....................................................ii.ii...........i............................... 5200/9253
2019-10-27T19:56:24.1586767Z .................................................................................................... 5400/9253
2019-10-27T19:56:33.4456483Z .................................................................................................... 5500/9253
2019-10-27T19:56:40.7998405Z ......................i............................................................................. 5600/9253
2019-10-27T19:56:46.5082871Z .................................................................................................... 5700/9253
2019-10-27T19:56:46.5082871Z .................................................................................................... 5700/9253
2019-10-27T19:56:58.1820405Z .................................................................................................... 5800/9253
2019-10-27T19:57:09.1526635Z ...................ii...i..ii...........i........................................................... 5900/9253
2019-10-27T19:57:29.3490424Z .................................................................................................... 6100/9253
2019-10-27T19:57:37.8980337Z .................................................................................................... 6200/9253
2019-10-27T19:57:37.8980337Z .................................................................................................... 6200/9253
2019-10-27T19:57:51.1140336Z ..........................................i..ii..................................................... 6300/9253
2019-10-27T19:58:12.4632584Z .................................................................................................... 6500/9253
2019-10-27T19:58:14.5664043Z ........i........................................................................................... 6600/9253
2019-10-27T19:58:16.6128277Z ...................................................................................i................ 6700/9253
2019-10-27T19:58:19.0947485Z .................................................................................................... 6800/9253
---
2019-10-27T20:02:42.1914954Z  finished in 5.421
2019-10-27T20:02:42.2076183Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-27T20:02:42.3818278Z 
2019-10-27T20:02:42.3819816Z running 153 tests
2019-10-27T20:02:45.4756460Z i....iii......iii..iiii...i.............................i..i..................i....i...........ii.i. 100/153
2019-10-27T20:02:47.2976819Z i..iiii..............i.........iii.i.........ii......
2019-10-27T20:02:47.2977384Z 
2019-10-27T20:02:47.2980872Z  finished in 5.090
2019-10-27T20:02:47.3150981Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-27T20:02:47.4642936Z 
---
2019-10-27T20:02:49.3216900Z  finished in 2.006
2019-10-27T20:02:49.3378040Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-27T20:02:49.4891370Z 
2019-10-27T20:02:49.4891619Z running 9 tests
2019-10-27T20:02:49.4892385Z iiiiiiiii
2019-10-27T20:02:49.4892948Z 
2019-10-27T20:02:49.4892983Z  finished in 0.151
2019-10-27T20:02:49.5054723Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-27T20:02:49.6794027Z 
---
2019-10-27T20:03:07.1859110Z  finished in 17.680
2019-10-27T20:03:07.2088654Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-27T20:03:07.3921409Z 
2019-10-27T20:03:07.3922430Z running 123 tests
2019-10-27T20:03:30.0017175Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-27T20:03:34.4376586Z i.i.i......iii.i.....ii
2019-10-27T20:03:34.4380553Z 
2019-10-27T20:03:34.4380628Z  finished in 27.228
2019-10-27T20:03:34.4386335Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-27T20:03:34.4386651Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-10-27T20:15:32.7678185Z 
2019-10-27T20:15:32.7681553Z    Doc-tests core
2019-10-27T20:15:37.8479121Z 
2019-10-27T20:15:37.8480622Z running 2409 tests
2019-10-27T20:15:48.2430879Z ......iiiii......................................................................................... 100/2409
2019-10-27T20:15:58.3050632Z ................................................................................ii.................. 200/2409
2019-10-27T20:16:22.6424455Z ..i................................................................................................. 400/2409
2019-10-27T20:16:22.6424455Z ..i................................................................................................. 400/2409
2019-10-27T20:16:32.3657095Z .................................................i..i.................iiii.......................... 500/2409
2019-10-27T20:16:51.3025722Z .................................................................................................... 700/2409
2019-10-27T20:17:01.0041078Z .................................................................................................... 800/2409
2019-10-27T20:17:10.6238155Z .................................................................................................... 900/2409
2019-10-27T20:17:20.1435681Z .................................................................................................... 1000/2409
---
2019-10-27T20:21:06.5937485Z .................................................................................................... 500/763
2019-10-27T20:21:06.6223864Z ....................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-27T20:21:06.6254261Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1165:5
2019-10-27T20:21:06.6257438Z thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-27T20:21:06.6311864Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-27T20:21:06.8166669Z ..........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-27T20:21:06.8193900Z .....thread '<unnamed>.' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1165:5
2019-10-27T20:21:06.8208304Z ..thread '...<unnamed>' panicked at '.called `Result::unwrap()` on an `Err` value: RecvErrorthread '', src/libcore/result.rs:1165:5
2019-10-27T20:21:06.8342144Z ............... 600/763
2019-10-27T20:21:08.8631613Z ......................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:629:13
2019-10-27T20:21:08.8632690Z ..thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:584:13
2019-10-27T20:21:08.8649086Z ...thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:561:13
---
2019-10-27T20:21:18.2661827Z 
2019-10-27T20:21:18.2691238Z running 999 tests
2019-10-27T20:21:38.7366265Z i................................................................................................... 100/999
2019-10-27T20:21:49.7515478Z .................................................................................................... 200/999
2019-10-27T20:21:57.7043154Z ...................iii......i......i...i......i..................................................... 300/999
2019-10-27T20:22:03.0829380Z .................................................................................................... 400/999
2019-10-27T20:22:10.5274160Z ..........................................i..i.................................ii................... 500/999
2019-10-27T20:22:24.8403369Z .................................................................................................... 700/999
2019-10-27T20:22:24.8403369Z .................................................................................................... 700/999
2019-10-27T20:22:32.0901692Z .........................iiii....................................................................... 800/999
2019-10-27T20:22:47.0516528Z .................................................................................................... 900/999
2019-10-27T20:22:54.4876214Z ...............................................iiii................................................
2019-10-27T20:22:54.4877293Z 
2019-10-27T20:22:54.4919123Z  finished in 186.677
2019-10-27T20:22:54.4936795Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-27T20:22:54.6897846Z    Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-10-27T20:37:32.1920542Z Rustbook (x86_64-unknown-linux-gnu) - edition-guide
2019-10-27T20:37:32.5309048Z Building stage0 tool linkchecker (x86_64-unknown-linux-gnu)
2019-10-27T20:37:32.6868066Z    Compiling linkchecker v0.1.0 (/checkout/src/tools/linkchecker)
2019-10-27T20:37:34.7213826Z     Finished release [optimized] target(s) in 2.18s
2019-10-27T20:37:35.2557602Z std/collections/linked_list/struct.LinkedList.html:4: broken link - std/collections/vec/struct.Vec.html
2019-10-27T20:37:35.2558231Z std/collections/linked_list/struct.LinkedList.html:4: broken link - std/collections/linked_list/vec_deque/struct.VecDeque.html
2019-10-27T20:37:41.2132927Z alloc/collections/linked_list/struct.LinkedList.html:4: broken link - alloc/collections/vec/struct.Vec.html
2019-10-27T20:37:41.2134267Z alloc/collections/linked_list/struct.LinkedList.html:4: broken link - alloc/collections/linked_list/vec_deque/struct.VecDeque.html
2019-10-27T20:37:42.1240288Z thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:41:9
2019-10-27T20:37:42.1240543Z 
2019-10-27T20:37:42.1240566Z 
2019-10-27T20:37:42.1241164Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
2019-10-27T20:37:42.1241281Z expected success, got: exit code: 101
---
2019-10-27T20:37:42.1312591Z   local time: Sun Oct 27 20:37:42 UTC 2019
2019-10-27T20:37:42.1530966Z   network time: Sun, 27 Oct 2019 20:37:42 GMT
2019-10-27T20:37:42.1533868Z == end clock drift check ==
2019-10-27T20:37:46.3085160Z 
2019-10-27T20:37:46.3193817Z ##[error]Bash exited with code '1'.
2019-10-27T20:37:46.3237213Z ##[section]Starting: Checkout
2019-10-27T20:37:46.3238820Z ==============================================================================
2019-10-27T20:37:46.3238873Z Task         : Get sources
2019-10-27T20:37:46.3238932Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

tshepang · 2019-10-29T20:34:44Z

r? @Centril

Centril · 2019-10-30T10:53:53Z

src/liballoc/collections/linked_list.rs

-//! Almost always it is better to use `Vec` or [`VecDeque`] instead of
-//! [`LinkedList`]. In general, array-based containers are faster,
-//! more memory efficient and make better use of CPU cache.
+//! NOTE: It is almost always better to use [`Vec`] or [`VecDeque`]...


Why the ... at the end now?

A period (.) feels abrupt. The ... indicates a gentle connection between the before (claim) and after (justification).

Also, am sure there's a better explanation why people use ..., which is something of a subtle concept.

I often use "..." in casual conversation because it suggests that I'm not done thinking; it's a sort of "uhm", "eh". but in a more formal setting (i.e. standards documentation) it just feels sloppy. See also https://en.wikipedia.org/wiki/Speech_disfluency and https://en.wikipedia.org/wiki/Filler_(linguistics).

Alternative:

NOTE: It is almost always better to use Vec or VecDeque because array-based containers are generally faster...

As a sidenote, and assuming you like that better, do you think we should add a comma there...

NOTE: It is almost always better to use Vec or VecDeque, because array-based containers are generally faster...

The first alternative is fine.

Centril · 2019-11-05T01:51:09Z

@bors r+ rollup

bors · 2019-11-05T01:51:11Z

📌 Commit a844e59 has been approved by Centril

…Centril docs: improve disclaimer regarding LinkedList

@ghost

Rollup of 10 pull requests Successful merges: - #65136 (Update codegen option documentation.) - #65574 (docs: improve disclaimer regarding LinkedList) - #65720 (Add FFI bindings for LLVM's Module::getInstructionCount()) - #65905 ([doc] fixes for unix/vxworks `OpenOptionsExt::mode`) - #65962 (Fix logic in example.) - #66019 (Improved std::iter::Chain documentation) - #66038 (doc(str): show example of chars().count() under len()) - #66042 (Suggest correct code when encountering an incorrect trait bound referencing the current trait) - #66073 (Do not needlessly write-lock) - #66096 (Add a failing UI test for multiple loops of all kinds in a `const`) Failed merges: r? @ghost

rust-highfive assigned withoutboats Oct 18, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2019

Centril reviewed Oct 19, 2019

View reviewed changes

rust-highfive assigned Centril and unassigned withoutboats Oct 19, 2019

Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2019

tshepang force-pushed the linked-list-disclaimer branch from a458a4a to 7c08bea Compare October 27, 2019 18:52

tshepang force-pushed the linked-list-disclaimer branch from 7c08bea to 9fdc913 Compare October 29, 2019 06:57

Centril reviewed Oct 30, 2019

View reviewed changes

docs: improve disclaimer regarding LinkedList

a844e59

tshepang force-pushed the linked-list-disclaimer branch from 9fdc913 to a844e59 Compare October 31, 2019 12:02

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 5, 2019

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 5, 2019

Rollup merge of rust-lang#65574 - tshepang:linked-list-disclaimer, r=…

5831e06

…Centril docs: improve disclaimer regarding LinkedList

pietroalbini mentioned this pull request Nov 5, 2019

Rollup of 10 pull requests #66109

Merged

bors merged commit a844e59 into rust-lang:master Nov 5, 2019

tshepang deleted the linked-list-disclaimer branch November 5, 2019 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: improve disclaimer regarding LinkedList #65574

docs: improve disclaimer regarding LinkedList #65574

tshepang commented Oct 18, 2019

rust-highfive commented Oct 18, 2019

rust-highfive commented Oct 19, 2019

Centril commented Oct 19, 2019

Centril commented Oct 26, 2019

Centril commented Oct 26, 2019

rust-highfive commented Oct 26, 2019

rust-highfive commented Oct 27, 2019

tshepang commented Oct 29, 2019

Centril Oct 30, 2019

tshepang Oct 30, 2019

Centril Oct 30, 2019

tshepang Oct 31, 2019

Centril Oct 31, 2019

tshepang Oct 31, 2019

Centril commented Nov 5, 2019

bors commented Nov 5, 2019

docs: improve disclaimer regarding LinkedList #65574

docs: improve disclaimer regarding LinkedList #65574

Conversation

tshepang commented Oct 18, 2019

rust-highfive commented Oct 18, 2019

rust-highfive commented Oct 19, 2019

Centril commented Oct 19, 2019

Centril commented Oct 26, 2019

Centril commented Oct 26, 2019

rust-highfive commented Oct 26, 2019

rust-highfive commented Oct 27, 2019

tshepang commented Oct 29, 2019

Centril Oct 30, 2019

Choose a reason for hiding this comment

tshepang Oct 30, 2019

Choose a reason for hiding this comment

Centril Oct 30, 2019

Choose a reason for hiding this comment

tshepang Oct 31, 2019

Choose a reason for hiding this comment

Centril Oct 31, 2019

Choose a reason for hiding this comment

tshepang Oct 31, 2019

Choose a reason for hiding this comment

Centril commented Nov 5, 2019

bors commented Nov 5, 2019