Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #65550

Closed
wants to merge 32 commits into from
Closed

Commits on Sep 30, 2019

  1. Document JSON message output.

    ehuss committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    f04ea6c View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2019

  1. Disable Go and OCaml bindings when building LLVM

    Instead of instaling OCaml bindings in a location where installation
    will not fail, don't build them in the first place.
    tmiasko committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    3b0fd82 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. Add more coherence tests

    weiznich committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    77f0aaf View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Use a BitSet in LexicalResolver::iterate_until_fixed_point().

    This wins 3% on `unicode_normalization`.
    nnethercote committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    70b136d View commit details
    Browse the repository at this point in the history
  2. Inline and remove iterate_until_fixed_point().

    The commit also removes the debug statement, because they annoyed me.
    This change wins another 1% on `unicode_normalization`, at least partly
    because it no longer needs to increment `iteration`.
    nnethercote committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    d51fee0 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Configuration menu
    Copy the full SHA
    42c0236 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d1db077 View commit details
    Browse the repository at this point in the history
  3. Update ui tests

    GuillaumeGomez committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    21d9258 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    83e97c6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4cd9276 View commit details
    Browse the repository at this point in the history
  6. Update ui tests

    GuillaumeGomez committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    f647c06 View commit details
    Browse the repository at this point in the history
  7. Plugins deprecation: don’t suggest simply removing the attribute

    Building Servo with a recent Nightly produces:
    
    ```rust
    warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See rust-lang#29597
      --> components/script/lib.rs:14:1
       |
    14 | #![plugin(script_plugins)]
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
       |
       = note: `#[warn(deprecated)]` on by default
    ```
    
    First, linking to rust-lang#29597 is not ideal
    since there is pretty much no discussion there of the deprecation
    and what can be used instead.
    This PR changes the link to the deprecation PR which does have more discussion.
    
    Second, the “remove this attribute” suggestion is rather unhelpful.
    Just because a feature is deprecated doesn’t mean that simply removing its use
    without a replacement is acceptable.
    
    In the case of custom lint, there is no replacement available.
    Prefixing a message with “help:” when telling users that they’re screwed
    honestly feels disrespectful.
    
    This PR also changes the message to be more factual.
    SimonSapin committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    71b0049 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a4d9492 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4e6efe4 View commit details
    Browse the repository at this point in the history
  10. Update triagebot.toml

    Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
    nikomatsakis and Mark-Simulacrum committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    5487994 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c0b7e76 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Configuration menu
    Copy the full SHA
    d0eaf60 View commit details
    Browse the repository at this point in the history
  2. Make TokenStream::from_iter less general and more efficient.

    The current code has this impl:
    ```
    impl<T: Into<TokenStream>> iter::FromIterator<T> for TokenStream
    ```
    If given an `IntoIterator<Item = TokenTree>`, it will convert each individual
    `TokenTree` to a `TokenStream` (at the cost of two allocations: a `Vec`
    and an `Lrc`). It will then merge those `TokenStream`s into a single
    `TokenStream`. This is inefficient.
    
    This commit changes the impl to this less general one:
    ```
    impl iter::FromIterator<TokenTree> for TokenStream
    ```
    It collects the `TokenTree`s into a single `Vec` first and then converts that
    to a `TokenStream` by wrapping it in a single `Lrc`. The previous generality
    was unnecessary; no other code needs changing.
    
    This change speeds up several benchmarks by up to 4%.
    nnethercote committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    a6eef29 View commit details
    Browse the repository at this point in the history
  3. Change Lit::tokens() to Lit::token_tree().

    Because most of the call sites have an easier time working with a
    `TokenTree` instead of a `TokenStream`.
    nnethercote committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    212ae58 View commit details
    Browse the repository at this point in the history
  4. Change MetaItem::tokens() to MetaItem::token_trees_and_joints().

    Likewise for `NestedMetaItem::tokens()`. Also, add
    `MetaItemKind::token_trees_and_joints()`, which `MetaItemKind::tokens()`
    now calls.
    
    This avoids some unnecessary `TokenTree` to `TokenStream` conversions,
    and removes the need for the clumsy
    `TokenStream::append_to_tree_and_joint_vec()`.
    nnethercote committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    e4ec4a6 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#64925 - ehuss:document-json, r=Mark-Simulacrum

    Document JSON message output.
    
    This documents the JSON messages in the rustc book.
    tmandry committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    2d536c0 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#65201 - tmiasko:no-bindings, r=rkruppe

    Disable Go and OCaml bindings when building LLVM
    
    Instead of instaling OCaml bindings in a location where installation
    will not fail, don't build them in the first place.
    tmandry committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    2e23a16 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#65334 - GuillaumeGomez:long-err-explanation…

    …-E0575, r=kinnison
    
    Add long error explanation for E0575
    
    Part of rust-lang#61137.
    tmandry committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    cdaa16d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#65417 - weiznich:more_coherence_tests, r=ni…

    …komatsakis
    
    Add more coherence tests
    
    I've wrote the missing test cases listed in [this google doc](https://docs.google.com/spreadsheets/d/1WlroTEXE6qxxGvEOhICkUpqguYZP9YOZEvnmEtSNtM0/edit#gid=0)
    
    > The other thing that might be useful is to rename the existing tests so they all fit the new naming scheme we were using.
    
    I'm not entirely sure how to do this. If everything from the google sheet is covered could I just remove the remaining tests in `src/test/ui/coherence` or is there something in there that should remain?
    
    cc rust-lang#63599
    
    r? @nikomatsakis
    tmandry committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    84b49ee View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#65455 - nnethercote:avoid-unnecessary-Token…

    …Tree-to-TokenStream-conversions, r=petrochenkov
    
    Avoid unnecessary `TokenTree` to `TokenStream` conversions
    
    A `TokenStream` contains any number of `TokenTrees`. Therefore, a single `TokenTree` can be promoted to a `TokenStream`. But doing so costs two allocations: one for the single-element `Vec`, and one for the `Lrc`. (An `IsJoint` value also must be added; the default is `NonJoint`.)
    
    The current code converts `TokenTree`s to `TokenStream`s unnecessarily in a few places. This PR removes some of these unnecessary conversions, both simplifying the code and speeding it up.
    
    r? @petrochenkov
    tmandry committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    49b5f0a View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#65472 - Zoxc:sharded-dep-graph-2, r=nikomat…

    …sakis
    
    Use a sharded dep node to dep node index map
    
    Split out from rust-lang#61845 and based on rust-lang#63756.
    
    r? @nikomatsakis
    tmandry committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    acb52ab View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#65480 - nnethercote:rm-iterate_until_fixed_…

    …size, r=nikomatsakis
    
    Speed up `LexicalResolve::expansion()`
    
    A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425.
    
    r? @nikomatsakis
    tmandry committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    7cc5c5a View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#65493 - GuillaumeGomez:long-err-explanation…

    …-E0584, r=kinnison
    
    Add long error explanation for E0584
    
    Part of rust-lang#61137.
    
    r? @kinnison
    tmandry committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    c203b1e View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#65496 - tspiteri:euc-div-panic, r=KodrAus

    properly document panics in div_euclid and rem_euclid
    
    For signed numbers, document that `div_euclid` and `rem_euclid` panic not just when `rhs` is 0, but also when the division overflows.
    
    For unsigned numbers, document that `div_euclid` and `rem_euclid` panic when `rhs` is 0.
    tmandry committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    554d46f View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#65498 - SimonSapin:plugin-help, r=Centril

    Plugins deprecation: don’t suggest simply removing the attribute
    
    Building Servo with a recent Nightly produces:
    
    ```rust
    warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See rust-lang#29597
      --> components/script/lib.rs:14:1
       |
    14 | #![plugin(script_plugins)]
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
       |
       = note: `#[warn(deprecated)]` on by default
    ```
    
    First, linking to rust-lang#29597 is not ideal since there is pretty much no discussion there of the deprecation and what can be used instead. This PR changes the link to the deprecation PR which does have more discussion.
    
    Second, the “remove this attribute” suggestion is rather unhelpful. Just because a feature is deprecated doesn’t mean that simply removing its use without a replacement is acceptable.
    
    In the case of custom lint, there is no replacement available. Prefixing a message with “help:” when telling users that they’re screwed honestly feels disrespectful.
    
    This PR also changes the message to be more factual.
    tmandry committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    5289625 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#65508 - rust-lang:llvm-icebreakers-ping-1, …

    …r=simulacrum
    
    add option to ping llvm ice-breakers to triagebot
    tmandry committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    f1ab6f3 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#65513 - RalfJung:fmt, r=Mark-Simulacrum

    reorder fmt docs for more clarity
    
    I adjusted these docs in rust-lang#65332 but wasn't happy with the result when seeing it in rustdoc. So this reorders the subsections in the "Formatting Parameters" section to be more logical (subsections that reference `width` come after the `width` subsection) and they also all have examples now.
    tmandry committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    624d2ce View commit details
    Browse the repository at this point in the history