Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to "associated functions" instead of "static methods" #65542

Merged
merged 5 commits into from
Oct 19, 2019

Conversation

estebank
Copy link
Contributor

Fix #59782.

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2019
@estebank
Copy link
Contributor Author

cc @Centril @petrochenkov

src/librustc_resolve/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_resolve/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_resolve/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_resolve/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_resolve/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_resolve/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_resolve/error_codes.rs Outdated Show resolved Hide resolved
src/libsyntax_ext/deriving/generic/mod.rs Outdated Show resolved Hide resolved
@estebank
Copy link
Contributor Author

@Centril can you take a look at the new wording?

@Centril
Copy link
Contributor

Centril commented Oct 19, 2019

r? @Centril @bors r+

@bors
Copy link
Contributor

bors commented Oct 19, 2019

📌 Commit 2b76c8b has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 19, 2019
…tril

Refer to "associated functions" instead of "static methods"

Fix rust-lang#59782.
Centril added a commit to Centril/rust that referenced this pull request Oct 19, 2019
…tril

Refer to "associated functions" instead of "static methods"

Fix rust-lang#59782.
Centril added a commit to Centril/rust that referenced this pull request Oct 19, 2019
…tril

Refer to "associated functions" instead of "static methods"

Fix rust-lang#59782.
bors added a commit that referenced this pull request Oct 19, 2019
Rollup of 6 pull requests

Successful merges:

 - #65174 (Fix zero-size uninitialized boxes)
 - #65252 (expand: Simplify expansion of derives)
 - #65485 (Suppress ICE when validators disagree on `LiveDrop`s in presence of `&mut`)
 - #65542 (Refer to "associated functions" instead of "static methods")
 - #65545 (More symbol cleanups)
 - #65576 (Don't add `argc` and `argv` arguments to `main` on WASI.)

Failed merges:

r? @ghost
@bors bors merged commit 2b76c8b into rust-lang:master Oct 19, 2019
@estebank estebank deleted the kill-static-methods branch November 9, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E0424 The self keyword was used in a static method.
6 participants