Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated proc_macro doesn't trigger warning on build library #65484

Closed
wants to merge 0 commits into from
Closed

Deprecated proc_macro doesn't trigger warning on build library #65484

wants to merge 0 commits into from

Conversation

XiangQingW
Copy link
Contributor

Fix #65189

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2019
@XiangQingW XiangQingW mentioned this pull request Oct 17, 2019
Merged
petrochenkov
petrochenkov reviewed Oct 17, 2019
View reviewed changes
src/libsyntax/ext/build.rs Outdated
nested_words: Vec<ast::NestedMetaItem>)
-> ast::MetaItem {
attr::mk_list_item(Ident::new(w, sp), nested_words)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The libsyntax/ext/build.rs is kind of deprecated, so it's better to avoid extending it, but rather use attr::mk_nested_word_item and attr::mk_list_item directly in the proc macro harness.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I'd love to change it.

@petrochenkov
Copy link
Contributor

This needs a test.
To test this you can copy test/ui/proc-macro/auxiliary/attributes-on-definitions.rs into test/ui/proc-macro and remove unnecessary parts.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2019
@bors
Copy link
Contributor

bors commented Oct 17, 2019

☔ The latest upstream changes (presumably #65495) made this pull request unmergeable. Please resolve the merge conflicts.

@joelpalmer
Copy link

Ping from Triage: Hi @XiangQingW, any updates?

@XiangQingW
Copy link
Contributor Author

XiangQingW commented Oct 21, 2019 •
edited
Loading

Ping from Triage: Hi @XiangQingW, any updates?

Yes, I'm working on this. I mess up with conflict and create a new pr ##65666.

@XiangQingW XiangQingW closed this Oct 21, 2019
@petrochenkov petrochenkov mentioned this pull request Oct 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecated proc_macro trigger warning on build library
5 participants
@XiangQingW @rust-highfive @petrochenkov @bors @joelpalmer