Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more info in debug traces for gcu merging #65175

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

andjo403
Copy link
Contributor

@andjo403 andjo403 commented Oct 6, 2019

to help in investigation of CGU partitioning problems e.g #64913

@rust-highfive
Copy link
Collaborator

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2019
@zackmdavis
Copy link
Member

Part of me was about to say, "Do we actually need this in master, if it was specifically for debugging this-and-such problem?" But if it's useful for the next person to look at this code, yes, sure; thanks.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 7, 2019

📌 Commit 50932ea has been approved by zackmdavis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 8, 2019
add more info in debug traces for gcu merging

to help in investigation of CGU partitioning problems e.g rust-lang#64913
Centril added a commit to Centril/rust that referenced this pull request Oct 9, 2019
add more info in debug traces for gcu merging

to help in investigation of CGU partitioning problems e.g rust-lang#64913
bors added a commit that referenced this pull request Oct 9, 2019
Rollup of 6 pull requests

Successful merges:

 - #64656 (Implement (HashMap) Entry::insert as per #60142)
 - #64986 (Function pointers as const generic arguments)
 - #65037 (`#[track_caller]` feature gate (RFC 2091 1/N))
 - #65166 (Suggest to add `move` keyword for generator capture)
 - #65175 (add more info in debug traces for gcu merging)
 - #65220 (Update LLVM for Emscripten exception handling support)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Oct 9, 2019
add more info in debug traces for gcu merging

to help in investigation of CGU partitioning problems e.g rust-lang#64913
bors added a commit that referenced this pull request Oct 9, 2019
Rollup of 4 pull requests

Successful merges:

 - #64656 (Implement (HashMap) Entry::insert as per #60142)
 - #65037 (`#[track_caller]` feature gate (RFC 2091 1/N))
 - #65166 (Suggest to add `move` keyword for generator capture)
 - #65175 (add more info in debug traces for gcu merging)

Failed merges:

r? @ghost
@bors bors merged commit 50932ea into rust-lang:master Oct 9, 2019
@andjo403 andjo403 deleted the partitioning branch October 9, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants