-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve wording in documentation of MaybeUninit #64837
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
This is not a typo. The use of "at" is intentional here. |
@Centril For what it's worth I dropped a quick question in the Rust chat about this, and I wasn't the only one to think the current sentence sounds strange. |
"The variable has type ("at type X" is jargon from type theory. I don't think "as" is clearer but we can rewrite the sentence to not need it at all.) |
I see. I was not aware of that terminology - thanks for clarifying. I expect that to be true for most people who consult the documentation though. |
Thanks. That wording is indeed clearer. |
:) Can you squash the commits and adjust the line wrapping as well? Should be good to go after that. |
This comment has been minimized.
This comment has been minimized.
Done. I hope it's ok now. |
@bors r+ rollup |
📌 Commit fd505d7 has been approved by |
Thanks, LGTM as well. :) |
Improve wording in documentation of MaybeUninit Changes > variables are properly initialized **at** their respective type into > variables are properly initialized **as** their respective type
Rollup of 10 pull requests Successful merges: - #64131 (data_structures: Add deterministic FxHashMap and FxHashSet wrappers) - #64387 (Fix redundant semicolon lint interaction with proc macro attributes) - #64678 (added more context for duplicate lang item errors (fixes #60561)) - #64763 (Add E0734 and its long explanation) - #64793 (Fix format macro expansions spans to be macro-generated) - #64837 (Improve wording in documentation of MaybeUninit) - #64852 (Print ParamTy span when accessing a field (#52082)) - #64875 (Upgrade async/await to "used" keywords.) - #64876 (Fix typo in intrinsics op safety) - #64880 (Slice docs: fix typo) Failed merges: r? @ghost
Changes
into