Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remark that tool MAINTAINERS must be members of the rust-lang org #64114

Closed
wants to merge 1 commit into from

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 3, 2019

I did not check if this is actually the case for the people currently listed there.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Sep 3, 2019

Cc @pietroalbini @kennytm

@Centril
Copy link
Contributor

Centril commented Sep 3, 2019

r? @pietroalbini

@pietroalbini
Copy link
Member

It's not technically right. Org membership alone doesn't allow assigning yourself to an issue, but you need to have at least explicit read access to the repository you're being assigned to.

@pietroalbini pietroalbini added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Sep 3, 2019

@pietroalbini and this applies not just when assigning yourself but also when being assigned by someone else?

@pietroalbini
Copy link
Member

@RalfJung yeah, at the moment the requirements for being assigned to an issue is "being listed on the Collaborators page of the settings or having previously commented on the issue". The latter doesn't apply here though.

@pietroalbini
Copy link
Member

Included the message in #64119. Closing this.

@RalfJung RalfJung deleted the tool-maintainers branch September 3, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants