Harden param_attrs test wrt. usage of a proc macro #[attr]
#64031
Conversation
rust-highfive
added
the
S-waiting-on-review
| use proc_macro::TokenStream; | ||
|
|
||
| #[proc_macro_attribute] | ||
| pub fn id(_: TokenStream, input: TokenStream) -> TokenStream { input } |
There was a problem hiding this comment.
We have auxiliary/test-macros.rs that defines all the utility macros like this, you can use #[identity_attr] from there.
There was a problem hiding this comment.
I'd have to move the test, right?
There was a problem hiding this comment.
Ah, ok then.
(We need a way to use a crate from the root auxiliary directory in all subdirectories to avoid duplication.)
|
( |
|
(Yeah, fair point. I suppose the test can serve as accident prevention for possibly weird changes but those would be unlikely. I'll leave it to Niko to decide whether they feel this would be beneficial. I think it need not block stabilization in either case.) |
|
@bors rollup r+ |
|
📌 Commit 5187a3e has been approved by |
bors
added
S-waiting-on-bors
|
Seems good to test a "user-provided" proc macro regardless |
… r=nikomatsakis Harden `param_attrs` test wrt. usage of a proc macro `#[attr]` The `param-attrs-builtin-attrs.rs` test file uses the `#[test]` attribute which should cover this but `#[test]` isn't a proc macro attribute so we add another test to be on the safe side. This intends to address rust-lang#64010 (comment). r? @nikomatsakis cc @c410-f3r @petrochenkov cc rust-lang#60406
… r=nikomatsakis Harden `param_attrs` test wrt. usage of a proc macro `#[attr]` The `param-attrs-builtin-attrs.rs` test file uses the `#[test]` attribute which should cover this but `#[test]` isn't a proc macro attribute so we add another test to be on the safe side. This intends to address rust-lang#64010 (comment). r? @nikomatsakis cc @c410-f3r @petrochenkov cc rust-lang#60406
Rollup of 15 pull requests Successful merges: - #62860 (Stabilize checked_duration_since for 1.38.0) - #63549 (Rev::rposition counts from the wrong end) - #63985 (Stabilize pin_into_inner in 1.39.0) - #64005 (Add a `Place::is_indirect` method to determine whether a `Place` contains a `Deref` projection) - #64031 (Harden `param_attrs` test wrt. usage of a proc macro `#[attr]`) - #64038 (Check impl trait substs when checking for recursive types) - #64043 (Add some more tests for underscore imports) - #64092 (Update xLTO compatibility table in rustc book.) - #64110 (Refer to "`self` type" instead of "receiver type") - #64120 (Move path parsing earlier) - #64123 (Added warning around code with reference to uninit bytes) - #64128 (unused_parens: account for or-patterns and `&(mut x)`) - #64141 (Minimize uses of `LocalInternedString`) - #64142 (Fix doc links in `std::cmp` module) - #64148 (fix a few typos in comments) Failed merges: r? @ghost
The
param-attrs-builtin-attrs.rstest file uses the#[test]attribute which should cover this but#[test]isn't a proc macro attribute so we add another test to be on the safe side. This intends to address #64010 (comment).r? @nikomatsakis
cc @c410-f3r @petrochenkov
cc #60406