Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dataflow to propagate Qualifs during const-qualification #63860

Closed
wants to merge 8 commits into from
Closed

Use dataflow to propagate Qualifs during const-qualification #63860

wants to merge 8 commits into from

Commits on Sep 8, 2019

  1. Add a getter for the current state to the old dataflow results cursor

    @ecstatic-morse
    ecstatic-morse committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    1e0dfac View commit details
    Browse the repository at this point in the history

  2. Define Qualif indices via macro

    @ecstatic-morse
    ecstatic-morse committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    4160021 View commit details
    Browse the repository at this point in the history

  3. Define for_each_qualif macro

    @ecstatic-morse
    ecstatic-morse committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    72e3f72 View commit details
    Browse the repository at this point in the history

  4. Use in_*_initially methods to initialize qualifs

    @ecstatic-morse
    ecstatic-morse committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    eb2535c View commit details
    Browse the repository at this point in the history

  5. Extract qualifs per local from ConstCx 

    To do dataflow-based qualification, we need to pass a reference to the
dataflow state directly to the `Qualif::in_*` methods. As such, we
move the `PerQualif<BitSet<Local>>` that holds the qualification state
for each local to `Checker` itself and use a macro (`get_qualif`) to
extract the correct `BitSet` when querying the qualifications for each
local.
    @ecstatic-morse
    ecstatic-morse committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    bf44689 View commit details
    Browse the repository at this point in the history

  6. Add generic dataflow impl

    @ecstatic-morse
    ecstatic-morse committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    159b9c5 View commit details
    Browse the repository at this point in the history

  7. Use dataflow for const qualification

    @ecstatic-morse
    ecstatic-morse committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    808bede View commit details
    Browse the repository at this point in the history

  8. Implement a non-dataflow, temp-only Qualif resolver

    @ecstatic-morse
    ecstatic-morse committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    d94a901 View commit details
    Browse the repository at this point in the history