Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installed compiler dependencies #63630

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Conversation

andjo403
Copy link
Contributor

As llvm have updated the minimum toolchain
https://reviews.llvm.org/D66188

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2019
@nikic
Copy link
Contributor

nikic commented Aug 16, 2019

The bump only happened for LLVM 10 (while we're on LLVM 9), so technically we still support older compiler versions at this point in time.

@andjo403
Copy link
Contributor Author

but to get it to work you need to set the allow-old-toolchain in the config.toml for llvm to receive LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN shall we add that to the description then?

@JohnCSimon
Copy link
Member

Ping from triage -
Hello, this PR has sat idle for eight days, what else needs to happen to resolve this?
@nikic @andjo403 @nikomatsakis

Thank you.

@andjo403
Copy link
Contributor Author

maybe I shall point to the https://reviews.llvm.org/D57264 that is in the llvm version used and due to that commit there is an compile error if the LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN option is not set and as that is not described in the readme I think update the compiler version is a good solution when llvm 10 also removes that possibility anyway.

@nikomatsakis
Copy link
Contributor

I think it makes sense to list the more modern dependencies as the default, and perhaps add a "subbullet" or something saying "you can use the older versions if you set LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN". (IIUC, that env variable is needed to use the older versions?)

@andjo403
Copy link
Contributor Author

added a description in new chapter "Building rustc with older host toolchains"

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2019
@JohnCSimon
Copy link
Member

Ping from triage -
Hi! @andjo403 , can you please address the change request from @nikomatsakis?

Thank you.

there is a soft-error for older toolchains
from https://reviews.llvm.org/D57264 in preparation for the
hard error in https://reviews.llvm.org/D66188
@andjo403
Copy link
Contributor Author

update the text according to the comments but also removed the range of compilers that was listed before due to the higher version listed did not need the option to be set

@nikomatsakis
Copy link
Contributor

@bors r+ rollup

Thanks @andjo403

@bors
Copy link
Contributor

bors commented Sep 18, 2019

📌 Commit 166719a has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 18, 2019
Update installed compiler dependencies

As llvm have updated the minimum toolchain
https://reviews.llvm.org/D66188
Centril added a commit to Centril/rust that referenced this pull request Sep 19, 2019
Update installed compiler dependencies

As llvm have updated the minimum toolchain
https://reviews.llvm.org/D66188
Centril added a commit to Centril/rust that referenced this pull request Sep 19, 2019
Update installed compiler dependencies

As llvm have updated the minimum toolchain
https://reviews.llvm.org/D66188
bors added a commit that referenced this pull request Sep 19, 2019
Rollup of 5 pull requests

Successful merges:

 - #63630 (Update installed compiler dependencies)
 - #64536 (Update Cargo)
 - #64554 (Polonius: more `ui` test suite fixes)
 - #64566 (A more generic interface for dataflow analysis)
 - #64591 (Fix a minor grammar nit, update UI tests)

Failed merges:

r? @ghost
@bors bors merged commit 166719a into rust-lang:master Sep 19, 2019
@andjo403 andjo403 deleted the bump_compiler branch September 19, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants