Remove meaningless comments in src/test #63411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow items to be accessible through private modules and fields when a macro can access them. * Don't mark type-private items as reachable. * Never make items exported/public via macros
They were reachable through opaque macros defined in `core`
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com> Co-Authored-By: Oliver Middleton <olliemail27@gmail.com>
Merge recent changes into master
ty::Instance is small and Copy, we should not be adding additional indirection.
This update includes the ability to warn on deprecated config keys. It's important to be able to warn the user whenever they're using an old configuration rather than giving them a cryptic "unknown configuration error" cc rust-lang/vscode-rust#639 Since we removed a config value in the current nightly, it'd be very good if this change can make also make it before cutting the next release.
Add #[repr(transparent)] for several types In some functions, types mentioned in this PR are transmuted into their inner value. Example for `PathBuf`: https://github.com/rust-lang/rust/blob/master/src/libstd/path.rs#L1132. This PR adds `#[repr(transparent)]` to those types, so their correct behavior doesn't depend on compiler details. (As far as I understand, currently that line, converting `PathBuf` to `Vec<u8>`, is UB).
Lint on some incorrect uses of mem::zeroed / mem::uninitialized Cc #62825 and https://internals.rust-lang.org/t/make-mem-uninitialized-and-mem-zeroed-panic-for-some-types-where-0-is-a-niche/10605 This does not yet handle `NonNull`/`NonZero*`, but it is a start. I also improved some doc issues I hit on the way, and added a useful helper to `TyS`. EDIT: I added the relnotes label mostly as a proposal -- I think this is worth mentioning, but leave the decision up to the release team.
rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE This matches `RUSTC_LOG`. Both affect only rustc, not any Rust program.
Derive Debug for CrateInfo
Add an example to show how to insert item to a sorted vec Closes #61684 cc #61742 r? @Mark-Simulacrum, @jonas-schievink
…Gomez rustdoc: general cleanup Almost all commits stand alone; but all commits can be reviewed individually.
Rollup of 8 pull requests Successful merges: - #61969 (Add #[repr(transparent)] for several types) - #63346 (Lint on some incorrect uses of mem::zeroed / mem::uninitialized) - #63433 (Miri shouldn't look at types) - #63440 (rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE) - #63441 (Derive Debug for CrateInfo) - #63442 (Add an example to show how to insert item to a sorted vec) - #63453 (rustdoc: general cleanup) - #63464 (Copy ty::Instance instead of passing by reference) Failed merges: r? @ghost
Update RLS This update includes the ability to warn on deprecated config keys. It's important to be able to warn the user whenever they're using an old configuration rather than giving them a cryptic "unknown configuration error" cc rust-lang/vscode-rust#639 Since we removed a config value in the current nightly, it'd be very good if this change can make also make it before cutting the next release.
libsyntax: Refactor `parser.rs` into reasonably sized logical units
Here we split `parser.rs` (~7.9 KLOC) into more reasonably sized files (all < 1.8 KLOC):
- `./src/libsyntax/parse/`
- `parser.rs`
- `parser/`
- `pat.rs`
- `expr.rs`
- `stmt.rs`
- `ty.rs`
- `path.rs`
- `generics.rs`
- `item.rs`
- `module.rs`
Closes #60015.
r? @petrochenkov
|
Think I might have made a mistake trying to rebase there. Would it be better for me to open a new branch from master and cherry-pick my commits onto that? |
|
@sd234678 Yeah that will probably go faster. ^^ |
|
Moved to #63487 |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
…s-in-src/test-2, r=Centril Remove meaningless comments in src/test Moved from rust-lang#63411
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 17, 2019
…s-in-src/test-2, r=Centril Remove meaningless comments in src/test Moved from rust-lang#63411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @Centril's comment on #63347