Fix some issues with unwrap_usize instead of assert_usize
#61380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This was referenced May 30, 2019
This comment has been minimized.
This comment has been minimized.
varkor
force-pushed
the
expected-usize-got-param
branch
from
0555a85
to
d2127e0
Compare
This comment has been minimized.
This comment has been minimized.
varkor
force-pushed
the
expected-usize-got-param
branch
from
132a909
to
6ba655d
Compare
Centril
reviewed
Jun 1, 2019
eddyb
reviewed
Jun 1, 2019
eddyb
reviewed
Jun 1, 2019
eddyb
reviewed
Jun 1, 2019
varkor
force-pushed
the
expected-usize-got-param
branch
from
73b67c2
to
e82cd95
Compare
|
I've removed the unnecessary guards in the rebase. |
eddyb
approved these changes
Jun 2, 2019
|
@bors r+ |
|
📌 Commit e82cd95 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 2, 2019
…eddyb Fix some issues with `unwrap_usize` instead of `assert_usize` Fixes rust-lang#61337. Fixes rust-lang#61341. Fixes rust-lang#61422. r? @eddyb
bors
added a commit
that referenced
this pull request
Jun 2, 2019
Rollup of 6 pull requests Successful merges: - #61380 (Fix some issues with `unwrap_usize` instead of `assert_usize`) - #61423 (codegen: change `$6d$` to `$u6d$`) - #61438 (Point at individual type args on arg count mismatch) - #61441 (Tweak wording when encountering `fn` call in pattern) - #61451 (Fix missing semicolon in doc) - #61458 (Fix typo in AsRef doc) Failed merges: r? @ghost
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61337.
Fixes #61341.
Fixes #61422.
r? @eddyb