-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch. #60985
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ |
📌 Commit a775d11 has been approved by |
Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch. Moving on to steps 9 and 10 of the llvm bugfix [guide](https://rust-lang.github.io/rustc-guide/codegen/updating-llvm.html#bugfix-updates), now that Rust's copy of LLVM was [updated](rust-lang/llvm-project#13). This PR closes issue rust-lang#59077. Nightlies following this PR should have working msp430 codegen again :D. Thanks for the prompt response even though it took me a while to get this "simple" PR done!
⌛ Testing commit a775d11 with merge 2d7bfa706fd54ba5ce36f9c0ef6c453afc479032... |
@bors retry |
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch. Moving on to steps 9 and 10 of the llvm bugfix [guide](https://rust-lang.github.io/rustc-guide/codegen/updating-llvm.html#bugfix-updates), now that Rust's copy of LLVM was [updated](rust-lang/llvm-project#13). This PR closes issue #59077. Nightlies following this PR should have working msp430 codegen again :D. Thanks for the prompt response even though it took me a while to get this "simple" PR done!
☀️ Test successful - checks-travis, status-appveyor |
Moving on to steps 9 and 10 of the llvm bugfix guide, now that Rust's copy of LLVM was updated.
This PR closes issue #59077. Nightlies following this PR should have working msp430 codegen again :D.
Thanks for the prompt response even though it took me a while to get this "simple" PR done!