Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librustc: Make labels take '. #6084

Closed
wants to merge 13 commits into from

Conversation

pcwalton
Copy link
Contributor

@pcwalton pcwalton closed this Apr 30, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 9, 2020
UI tests cleanup

`@matthiaskrgr` noticed some `run-pass` annotations in some crash tests that were added in rust-lang#3922. At that moment they seemed to be necessary to make the tests fail in case of an ICE, but they do not seem to be needed anymore. To test this I forced an ICE in a file with and without annotations, with and without stderr files, and the ICE makes the test fail every time.

In addition, I've applied a suggestion from `@ehuss` and `@jyn514` to add `emit=metadata` to the rustc flags for the UI tests. In my machine this improved the run time from ~17 to ~12 seconds.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants