Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miri now supports entropy, but is still slow #60018

Merged
merged 2 commits into from
Apr 17, 2019

Conversation

RalfJung
Copy link
Member

Adjust the cfg and their comments in the test suites accordingly.

@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Apr 16, 2019

@bors r+ rollup

r? @oli-obk

@bors
Copy link
Contributor

bors commented Apr 16, 2019

📌 Commit 9b21324 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2019
@rust-highfive rust-highfive assigned oli-obk and unassigned sfackler Apr 16, 2019
@RalfJung
Copy link
Member Author

@oli-obk I enabled sort_unstable in Miri as well, tweaking it so that it doesn't try to sort large arrays there.

@oli-obk
Copy link
Contributor

oli-obk commented Apr 17, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 17, 2019

📌 Commit d55e4b7 has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Apr 17, 2019
Miri now supports entropy, but is still slow

Adjust the `cfg` and their comments in the test suites accordingly.
bors added a commit that referenced this pull request Apr 17, 2019
Rollup of 5 pull requests

Successful merges:

 - #59128 (Emit ansi color codes in the `rendered` field of json diagnostics)
 - #59646 (const fn: Improve wording)
 - #59986 (Miri: refactor new allocation tagging)
 - #60003 (LLD is not supported on Darwin)
 - #60018 (Miri now supports entropy, but is still slow)

Failed merges:

r? @ghost
@bors bors merged commit d55e4b7 into rust-lang:master Apr 17, 2019
@RalfJung RalfJung deleted the miri-test-libstd branch April 18, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants