Eliminate `FnBox` usages from libstd. #59818

crlf0710 · 2019-04-09T17:09:13Z

No description provided.

rust-highfive · 2019-04-09T17:09:16Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-04-09T17:25:03Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0310c248:start=1554829907492182540,finish=1554829908503481143,duration=1011298603
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
$ export CI_JOB_NAME=$TRAVIS_JOB_NAME
$ export IMAGE=x86_64-gnu-llvm-6.0
$ export RUST_BACKTRACE=1
$ bash -c 'echo $BASH_VERSION'
---

[00:04:17] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:17] tidy error: /checkout/src/libstd/thread/mod.rs:490: line longer than 100 chars
[00:04:19] some tidy checks failed
[00:04:19] 
[00:04:19] 
[00:04:19] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:19] 
[00:04:19] 
[00:04:19] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:19] Build completed unsuccessfully in 0:00:44
[00:04:19] Build completed unsuccessfully in 0:00:44
[00:04:19] make: *** [tidy] Error 1
[00:04:19] Makefile:67: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:06e91f9b
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Apr  9 17:16:18 UTC 2019
---
travis_time:end:03c10982:start=1554830179430154468,finish=1554830179434743806,duration=4589338
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:04098c7d
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:150af540
travis_time:start:150af540
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0aa5c792
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

cramertj · 2019-04-09T18:50:46Z

src/libstd/thread/mod.rs

@@ -488,7 +487,7 @@ impl Builder {
            // returning.
            native: Some(imp::Thread::new(
                stack_size,
-                mem::transmute::<Box<dyn FnBox() + 'a>, Box<dyn FnBox() + 'static>>(Box::new(main))
+                mem::transmute::<Box<dyn FnOnce() + 'a>, Box<dyn FnOnce() + 'static>>(Box::new(main))


tidy is mad about the line length here

cramertj · 2019-04-09T18:51:04Z

r=me when travis is happy

Centril · 2019-04-09T23:54:42Z

r? @cramertj

crlf0710 · 2019-04-10T01:44:07Z

Ran rustfmt on this mod, and reverted most of the format changes :)

crlf0710 · 2019-04-11T02:17:40Z

bors r=@cramertj

cramertj · 2019-04-11T02:45:25Z

@bors r+

bors · 2019-04-11T02:45:27Z

📌 Commit 6635fbe has been approved by cramertj

…cramertj Eliminate `FnBox` usages from libstd.

@ghost

Rollup of 18 pull requests Successful merges: - rust-lang#59612 (Use normal newtype_index macro for MIR dataflows) - rust-lang#59675 (Stabilize the `alloc` crate.) - rust-lang#59708 (Mark variables captured by reference as mutable correctly) - rust-lang#59735 (remove lookup_char_pos_adj) - rust-lang#59747 (Copy book.toml unstable book generator) - rust-lang#59796 (Retire `IsNotConst` naming) - rust-lang#59804 (Clean up jobserver integration) - rust-lang#59818 (Eliminate `FnBox` usages from libstd.) - rust-lang#59830 (Fix links on keyword docs.) - rust-lang#59835 (Re-export NonZero signed variant in std) - rust-lang#59852 (std: Add `{read,write}_vectored` for more types) - rust-lang#59855 (Fix attributes position in type declaration) - rust-lang#59858 (Make duplicate matcher bindings a hard error) - rust-lang#59879 (Use SecRandomCopyBytes instead of /dev/urandom on MacOS) - rust-lang#59899 (In `-Zprint-type-size` output, sort enum variants by size.) - rust-lang#59912 (MaybeUninit: remove deprecated functions) - rust-lang#59925 (Fix paste error in split_ascii_whitespace docs.) - rust-lang#59930 (Exclude some copies of old book editions from search engines) Failed merges: r? @ghost

@ghost

Rollup of 18 pull requests Successful merges: - #59612 (Use normal newtype_index macro for MIR dataflows) - #59675 (Stabilize the `alloc` crate.) - #59708 (Mark variables captured by reference as mutable correctly) - #59735 (remove lookup_char_pos_adj) - #59747 (Copy book.toml unstable book generator) - #59796 (Retire `IsNotConst` naming) - #59804 (Clean up jobserver integration) - #59818 (Eliminate `FnBox` usages from libstd.) - #59830 (Fix links on keyword docs.) - #59835 (Re-export NonZero signed variant in std) - #59852 (std: Add `{read,write}_vectored` for more types) - #59855 (Fix attributes position in type declaration) - #59858 (Make duplicate matcher bindings a hard error) - #59879 (Use SecRandomCopyBytes instead of /dev/urandom on MacOS) - #59899 (In `-Zprint-type-size` output, sort enum variants by size.) - #59912 (MaybeUninit: remove deprecated functions) - #59925 (Fix paste error in split_ascii_whitespace docs.) - #59930 (Exclude some copies of old book editions from search engines) Failed merges: r? @ghost

…cramertj Eliminate `FnBox` usages from libstd.

@ghost

Rollup of 16 pull requests Successful merges: - #59675 (Stabilize the `alloc` crate.) - #59708 (Mark variables captured by reference as mutable correctly) - #59735 (remove lookup_char_pos_adj) - #59747 (Copy book.toml unstable book generator) - #59796 (Retire `IsNotConst` naming) - #59804 (Clean up jobserver integration) - #59818 (Eliminate `FnBox` usages from libstd.) - #59830 (Fix links on keyword docs.) - #59835 (Re-export NonZero signed variant in std) - #59852 (std: Add `{read,write}_vectored` for more types) - #59855 (Fix attributes position in type declaration) - #59858 (Make duplicate matcher bindings a hard error) - #59899 (In `-Zprint-type-size` output, sort enum variants by size.) - #59912 (MaybeUninit: remove deprecated functions) - #59925 (Fix paste error in split_ascii_whitespace docs.) - #59930 (Exclude some copies of old book editions from search engines) Failed merges: r? @ghost

rust-highfive assigned withoutboats Apr 9, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 9, 2019

cramertj reviewed Apr 9, 2019

View reviewed changes

rust-highfive assigned cramertj and unassigned withoutboats Apr 9, 2019

Eliminate FnBox usages from libstd.

6635fbe

crlf0710 force-pushed the eliminate_libstd_fnbox branch from 700a976 to 6635fbe Compare April 10, 2019 01:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2019

Centril added a commit to Centril/rust that referenced this pull request Apr 12, 2019

Rollup merge of rust-lang#59818 - crlf0710:eliminate_libstd_fnbox, r=…

66548ae

…cramertj Eliminate `FnBox` usages from libstd.

Centril mentioned this pull request Apr 12, 2019

Rollup of 17 pull requests #59921

Closed

Centril added a commit to Centril/rust that referenced this pull request Apr 13, 2019

Rollup merge of rust-lang#59818 - crlf0710:eliminate_libstd_fnbox, r=…

f8a2d48

…cramertj Eliminate `FnBox` usages from libstd.

Centril mentioned this pull request Apr 13, 2019

Rollup of 18 pull requests #59937

Closed

Centril added a commit to Centril/rust that referenced this pull request Apr 13, 2019

Rollup merge of rust-lang#59818 - crlf0710:eliminate_libstd_fnbox, r=…

70b22be

…cramertj Eliminate `FnBox` usages from libstd.

Centril mentioned this pull request Apr 13, 2019

Rollup of 16 pull requests #59941

Closed

Centril added a commit to Centril/rust that referenced this pull request Apr 13, 2019

Rollup merge of rust-lang#59818 - crlf0710:eliminate_libstd_fnbox, r=…

8ad17ec

…cramertj Eliminate `FnBox` usages from libstd.

Centril mentioned this pull request Apr 13, 2019

Rollup of 16 pull requests #59949

Merged

bors merged commit 6635fbe into rust-lang:master Apr 14, 2019

crlf0710 deleted the eliminate_libstd_fnbox branch April 14, 2019 01:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eliminate `FnBox` usages from libstd. #59818

Eliminate `FnBox` usages from libstd. #59818

crlf0710 commented Apr 9, 2019

rust-highfive commented Apr 9, 2019

rust-highfive commented Apr 9, 2019

cramertj Apr 9, 2019

cramertj commented Apr 9, 2019

Centril commented Apr 9, 2019

crlf0710 commented Apr 10, 2019

crlf0710 commented Apr 11, 2019

cramertj commented Apr 11, 2019

bors commented Apr 11, 2019

Eliminate FnBox usages from libstd. #59818

Eliminate FnBox usages from libstd. #59818

Conversation

crlf0710 commented Apr 9, 2019

rust-highfive commented Apr 9, 2019

rust-highfive commented Apr 9, 2019

cramertj Apr 9, 2019

Choose a reason for hiding this comment

cramertj commented Apr 9, 2019

Centril commented Apr 9, 2019

crlf0710 commented Apr 10, 2019

crlf0710 commented Apr 11, 2019

cramertj commented Apr 11, 2019

bors commented Apr 11, 2019

Eliminate `FnBox` usages from libstd. #59818

Eliminate `FnBox` usages from libstd. #59818