-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the existing LLVM GitInfo for checking rebuilds #59566
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Hmm, except "dev" builds ignore git, which isn't what we want for LLVM... Lines 649 to 650 in fc8581d
|
I'm not sure, but perhaps we could add an argument to GitInfo new or something along those lines that would usually be the config.ignore_git but for LLVM just true. |
I just pushed a commit which roughly does that -- passing |
Looks good to me! Bumping priority since this fixes a regression. @bors r+ p=1 |
📌 Commit 49b65e6 has been approved by |
Use the existing LLVM GitInfo for checking rebuilds Fixes #59565
☀️ Test successful - checks-travis, status-appveyor |
Fixes #59565