-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 17 pull requests #59466
Rollup of 17 pull requests #59466
Commits on Feb 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 36bcbc3 - Browse repository at this point
Copy the full SHA 36bcbc3View commit details
Commits on Feb 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ce30d4e - Browse repository at this point
Copy the full SHA ce30d4eView commit details
Commits on Feb 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 912ad68 - Browse repository at this point
Copy the full SHA 912ad68View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad240ea - Browse repository at this point
Copy the full SHA ad240eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7330525 - Browse repository at this point
Copy the full SHA 7330525View commit details
Commits on Mar 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8740d5d - Browse repository at this point
Copy the full SHA 8740d5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce933f7 - Browse repository at this point
Copy the full SHA ce933f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbe34cc - Browse repository at this point
Copy the full SHA fbe34ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3fb6f8 - Browse repository at this point
Copy the full SHA e3fb6f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 525a043 - Browse repository at this point
Copy the full SHA 525a043View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d3840b - Browse repository at this point
Copy the full SHA 6d3840bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4faa9b - Browse repository at this point
Copy the full SHA b4faa9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a3241a - Browse repository at this point
Copy the full SHA 4a3241aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ad91f7 - Browse repository at this point
Copy the full SHA 0ad91f7View commit details
Commits on Mar 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c1ec29a - Browse repository at this point
Copy the full SHA c1ec29aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fad370 - Browse repository at this point
Copy the full SHA 7fad370View commit details
Commits on Mar 22, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b34a71b - Browse repository at this point
Copy the full SHA b34a71bView commit details
Commits on Mar 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ac3290e - Browse repository at this point
Copy the full SHA ac3290eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f7b320 - Browse repository at this point
Copy the full SHA 2f7b320View commit details -
Configuration menu - View commit details
-
Copy full SHA for e929d19 - Browse repository at this point
Copy the full SHA e929d19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b38294 - Browse repository at this point
Copy the full SHA 4b38294View commit details
Commits on Mar 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c709a10 - Browse repository at this point
Copy the full SHA c709a10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e156c2 - Browse repository at this point
Copy the full SHA 7e156c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32bc4a5 - Browse repository at this point
Copy the full SHA 32bc4a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00d8fa3 - Browse repository at this point
Copy the full SHA 00d8fa3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91b7423 - Browse repository at this point
Copy the full SHA 91b7423View commit details
Commits on Mar 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 630d5a4 - Browse repository at this point
Copy the full SHA 630d5a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ad77b0 - Browse repository at this point
Copy the full SHA 6ad77b0View commit details -
adjust MaybeUninit API to discussions
uninitialized -> uninit into_initialized -> assume_init read_initialized -> read set -> write
Configuration menu - View commit details
-
Copy full SHA for 0e0383a - Browse repository at this point
Copy the full SHA 0e0383aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 853ae8d - Browse repository at this point
Copy the full SHA 853ae8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4093bec - Browse repository at this point
Copy the full SHA 4093becView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7ddb83 - Browse repository at this point
Copy the full SHA c7ddb83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bb3694 - Browse repository at this point
Copy the full SHA 1bb3694View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d1cc72 - Browse repository at this point
Copy the full SHA 8d1cc72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24a0cae - Browse repository at this point
Copy the full SHA 24a0caeView commit details -
fix: Make incremental artifact deletion more robust
Should fix the intermittent errors reported in rust-lang#57958 cc rust-lang#48614
Configuration menu - View commit details
-
Copy full SHA for a365287 - Browse repository at this point
Copy the full SHA a365287View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8733b2a - Browse repository at this point
Copy the full SHA 8733b2aView commit details
Commits on Mar 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 892f7c4 - Browse repository at this point
Copy the full SHA 892f7c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14f3f6c - Browse repository at this point
Copy the full SHA 14f3f6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf1068b - Browse repository at this point
Copy the full SHA bf1068bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7945eff - Browse repository at this point
Copy the full SHA 7945effView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05d59fe - Browse repository at this point
Copy the full SHA 05d59feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b9c589 - Browse repository at this point
Copy the full SHA 0b9c589View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce1c5e0 - Browse repository at this point
Copy the full SHA ce1c5e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2368aa8 - Browse repository at this point
Copy the full SHA 2368aa8View commit details -
Include id in Thread's Debug implementation
Since Rust 1.19.0, id is a stable method, so there is no reason to not include it in Debug implementation.
Configuration menu - View commit details
-
Copy full SHA for ba21e0b - Browse repository at this point
Copy the full SHA ba21e0bView commit details -
Rollup merge of rust-lang#57293 - Zoxc:incr-passes3, r=michaelwoerister
Make some lints incremental Blocked on rust-lang#57253 r? @michaelwoerister
Configuration menu - View commit details
-
Copy full SHA for 6a3b639 - Browse repository at this point
Copy the full SHA 6a3b639View commit details -
Rollup merge of rust-lang#57565 - petrochenkov:turbowarn, r=Centril
syntax: Remove warning for unnecessary path disambiguators `rustfmt` is now stable and it removes unnecessary turbofishes, so removing the warning as discussed in rust-lang#43540 (where it was introduced). One hardcoded warning less. Closes rust-lang#58055 r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for 9bfc4d3 - Browse repository at this point
Copy the full SHA 9bfc4d3View commit details -
Rollup merge of rust-lang#58253 - taiki-e:librustc_driver-2018, r=pet…
…rochenkov librustc_driver => 2018 Transitions `librustc_driver` to Rust 2018; cc rust-lang#58099 r? @Centril
Configuration menu - View commit details
-
Copy full SHA for 34f0297 - Browse repository at this point
Copy the full SHA 34f0297View commit details -
Rollup merge of rust-lang#58717 - hellow554:nonzero_parse, r=Amanieu
Add FromStr impl for NonZero types This is a WIP implementation because I do have some questions regarding the solution. Somebody should ping the lang team on this I guess. Please see the annotations on the code for more details. Closes rust-lang#58604
Configuration menu - View commit details
-
Copy full SHA for 44a7b9c - Browse repository at this point
Copy the full SHA 44a7b9cView commit details -
Rollup merge of rust-lang#58837 - Centril:librustc_interface_2018, r=…
…petrochenkov librustc_interface => 2018 r? @oli-obk This will likely produce an ICE for some reason... so super-WIP.
Configuration menu - View commit details
-
Copy full SHA for 0be9d16 - Browse repository at this point
Copy the full SHA 0be9d16View commit details -
Rollup merge of rust-lang#59268 - estebank:from-string, r=QuietMisdre…
…avus Add suggestion to use `&*var` when `&str: From<String>` is expected Fix rust-lang#53879.
Configuration menu - View commit details
-
Copy full SHA for 47083fb - Browse repository at this point
Copy the full SHA 47083fbView commit details -
Rollup merge of rust-lang#59283 - SimonSapin:branchless-ascii-case, r…
…=joshtriplett Make ASCII case conversions more than 4× faster Reformatted output of `./x.py bench src/libcore --test-args ascii` below. The `libcore` benchmark calls `[u8]::make_ascii_lowercase`. `lookup` has code (effectively) identical to that before this PR, and ~~`branchless`~~ `mask_shifted_bool_match_range` after this PR. ~~See [code comments](rust-lang@ce933f7#diff-01076f91a26400b2db49663d787c2576R3796) in `u8::to_ascii_uppercase` in `src/libcore/num/mod.rs` for an explanation of the branchless algorithm.~~ **Update:** the algorithm was simplified while keeping the performance. See `branchless` v.s. `mask_shifted_bool_match_range` benchmarks. Credits to @raphlinus for the idea in https://twitter.com/raphlinus/status/1107654782544736261, which extends this algorithm to “fake SIMD” on `u32` to convert four bytes at a time. The `fake_simd_u32` benchmarks implements this with [`let (before, aligned, after) = bytes.align_to_mut::<u32>()`](https://doc.rust-lang.org/std/primitive.slice.html#method.align_to_mut). Note however that this is buggy when addition carries/overflows into the next byte (which does not happen if the input is known to be ASCII). This could be fixed (to optimize `[u8]::make_ascii_lowercase` and `[u8]::make_ascii_uppercase` in `src/libcore/slice/mod.rs`) either with some more bitwise trickery that I didn’t quite figure out, or by using “real” SIMD intrinsics for byte-wise addition. I did not pursue this however because the current (incorrect) fake SIMD algorithm is only marginally faster than the one-byte-at-a-time branchless algorithm. This is because LLVM auto-vectorizes the latter, as can be seen on https://rust.godbolt.org/z/anKtbR. Benchmark results on Linux x64 with Intel i7-7700K: (updated from rust-lang#59283 (comment)) ```rust 6830 bytes string: alloc_only ... bench: 112 ns/iter (+/- 0) = 62410 MB/s black_box_read_each_byte ... bench: 1,733 ns/iter (+/- 8) = 4033 MB/s lookup_table ... bench: 1,766 ns/iter (+/- 11) = 3958 MB/s branch_and_subtract ... bench: 417 ns/iter (+/- 1) = 16762 MB/s branch_and_mask ... bench: 401 ns/iter (+/- 1) = 17431 MB/s branchless ... bench: 365 ns/iter (+/- 0) = 19150 MB/s libcore ... bench: 367 ns/iter (+/- 1) = 19046 MB/s fake_simd_u32 ... bench: 361 ns/iter (+/- 2) = 19362 MB/s fake_simd_u64 ... bench: 361 ns/iter (+/- 1) = 19362 MB/s mask_mult_bool_branchy_lookup_table ... bench: 6,309 ns/iter (+/- 19) = 1107 MB/s mask_mult_bool_lookup_table ... bench: 4,183 ns/iter (+/- 29) = 1671 MB/s mask_mult_bool_match_range ... bench: 339 ns/iter (+/- 0) = 20619 MB/s mask_shifted_bool_match_range ... bench: 339 ns/iter (+/- 1) = 20619 MB/s 32 bytes string: alloc_only ... bench: 15 ns/iter (+/- 0) = 2133 MB/s black_box_read_each_byte ... bench: 29 ns/iter (+/- 0) = 1103 MB/s lookup_table ... bench: 24 ns/iter (+/- 4) = 1333 MB/s branch_and_subtract ... bench: 16 ns/iter (+/- 0) = 2000 MB/s branch_and_mask ... bench: 16 ns/iter (+/- 0) = 2000 MB/s branchless ... bench: 16 ns/iter (+/- 0) = 2000 MB/s libcore ... bench: 15 ns/iter (+/- 0) = 2133 MB/s fake_simd_u32 ... bench: 17 ns/iter (+/- 0) = 1882 MB/s fake_simd_u64 ... bench: 16 ns/iter (+/- 0) = 2000 MB/s mask_mult_bool_branchy_lookup_table ... bench: 42 ns/iter (+/- 0) = 761 MB/s mask_mult_bool_lookup_table ... bench: 35 ns/iter (+/- 0) = 914 MB/s mask_mult_bool_match_range ... bench: 16 ns/iter (+/- 0) = 2000 MB/s mask_shifted_bool_match_range ... bench: 16 ns/iter (+/- 0) = 2000 MB/s 7 bytes string: alloc_only ... bench: 14 ns/iter (+/- 0) = 500 MB/s black_box_read_each_byte ... bench: 22 ns/iter (+/- 0) = 318 MB/s lookup_table ... bench: 16 ns/iter (+/- 0) = 437 MB/s branch_and_subtract ... bench: 16 ns/iter (+/- 0) = 437 MB/s branch_and_mask ... bench: 16 ns/iter (+/- 0) = 437 MB/s branchless ... bench: 19 ns/iter (+/- 0) = 368 MB/s libcore ... bench: 20 ns/iter (+/- 0) = 350 MB/s fake_simd_u32 ... bench: 18 ns/iter (+/- 0) = 388 MB/s fake_simd_u64 ... bench: 21 ns/iter (+/- 0) = 333 MB/s mask_mult_bool_branchy_lookup_table ... bench: 20 ns/iter (+/- 0) = 350 MB/s mask_mult_bool_lookup_table ... bench: 19 ns/iter (+/- 0) = 368 MB/s mask_mult_bool_match_range ... bench: 19 ns/iter (+/- 0) = 368 MB/s mask_shifted_bool_match_range ... bench: 19 ns/iter (+/- 0) = 368 MB/s ```
Configuration menu - View commit details
-
Copy full SHA for 51f4fcd - Browse repository at this point
Copy the full SHA 51f4fcdView commit details -
Rollup merge of rust-lang#59284 - RalfJung:maybe-uninit, r=sfackler
adjust MaybeUninit API to discussions uninitialized -> uninit into_initialized -> assume_init read_initialized -> read set -> write
Configuration menu - View commit details
-
Copy full SHA for 5562519 - Browse repository at this point
Copy the full SHA 5562519View commit details -
Rollup merge of rust-lang#59372 - euclio:rename-trim, r=rkruppe
add rustfix-able suggestions to trim_{left,right} deprecations Fixes rust-lang#53802 (technically already fixed by rust-lang#58002, but that issue is about these methods).
Configuration menu - View commit details
-
Copy full SHA for 9b259c6 - Browse repository at this point
Copy the full SHA 9b259c6View commit details -
Rollup merge of rust-lang#59393 - czipperz:refactor_tuple_comparison_…
…tests, r=shepmaster Refactor tuple comparison tests
Configuration menu - View commit details
-
Copy full SHA for 961b86b - Browse repository at this point
Copy the full SHA 961b86bView commit details -
Rollup merge of rust-lang#59421 - estebank:tuple-index-suffix, r=petr…
…ochenkov Reject integer suffix when tuple indexing Fix rust-lang#59418. r? @varkor
Configuration menu - View commit details
-
Copy full SHA for d3119e4 - Browse repository at this point
Copy the full SHA d3119e4View commit details -
Rollup merge of rust-lang#59430 - kenta7777:rename-evalcontext-to-int…
…erpretcx, r=oli-obk Renames `EvalContext` to `InterpretCx` This PR renames `EvalContext` to `InterpretCx` in `src/librustc_mir`. This PR is related to rust-lang#54395 .
Configuration menu - View commit details
-
Copy full SHA for 81201e2 - Browse repository at this point
Copy the full SHA 81201e2View commit details -
Rollup merge of rust-lang#59439 - Centril:generalize-assign-to-bool-d…
…iagnostic, r=oli-obk Generalize diagnostic for `x = y` where `bool` is the expected type Extracted out of rust-lang#59288. Currently we special case a diagnostic for `if x = y { ...` since the expected type is `bool` in this case and we instead suggest `if x == y`. This PR generalizes this such that given an expression of form `x = y` (`ExprKind::Assign(..)`) where the expected type is `bool`, we emit a suggestion `x == y`. r? @oli-obk Let's do a perf run to make sure this was not the source of regressions in rust-lang#59288.
Configuration menu - View commit details
-
Copy full SHA for d42e5eb - Browse repository at this point
Copy the full SHA d42e5ebView commit details -
Rollup merge of rust-lang#59449 - Marwes:issue_57958, r=michaelwoerister
fix: Make incremental artifact deletion more robust Should fix the intermittent errors reported in rust-lang#57958 cc rust-lang#48614
Configuration menu - View commit details
-
Copy full SHA for a4b4253 - Browse repository at this point
Copy the full SHA a4b4253View commit details -
Rollup merge of rust-lang#59451 - TimDiekmann:patch-1, r=sfackler
Add `Default` to `std::alloc::System` `System` is a unit struct, thus, it can be constructed without any additional information. Therefore `Default` is a noop. However, in generic code, a `T: Default` may happen as in ```rust #[derive(Default)] struct Foo<A> { allocator: A } ``` Does this need a feature gate? Should I also add `PartialEq/Eq/PartialOrd/Ord/Hash`?
Configuration menu - View commit details
-
Copy full SHA for d04b1ec - Browse repository at this point
Copy the full SHA d04b1ecView commit details -
Rollup merge of rust-lang#59459 - JohnTitor:add-tests, r=Centril
Add some tests close rust-lang#52977 It seems that there are no tests for this issue, so I opened this PR. off-topic: I noticed [this test](https://github.com/rust-lang/rust/blob/master/src/test/ui/existential_types/nested_existential_types.rs)'s indents are bad, could I include commit to fix this, or should I separate? r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for d2757d0 - Browse repository at this point
Copy the full SHA d2757d0View commit details -
Rollup merge of rust-lang#59460 - xfix:include-id-in-thread-debug, r=…
…Amanieu Include id in Thread's Debug implementation Since Rust 1.19.0, `id` is a stable method, so there is no reason to not include it in Debug implementation.
Configuration menu - View commit details
-
Copy full SHA for 3f372a1 - Browse repository at this point
Copy the full SHA 3f372a1View commit details