Code

Refactor ppaux out of existence.#58140

Code

Merged

bors merged 70 commits intorust-lang:masterrust-lang/rust:masterfrom eddyb:advent-of-printeddyb/rust:advent-of-printCopy head branch name to clipboardMar 15, 2019

+3,407-2,933

Commits

Commits on Mar 15, 2019

• rustc: remove unnecessary extern_prelude logic from ty::item_path.

  eddyb

  committed
  228d6f4

  Copy full SHA for 228d6f4

• rustc: start moving util::ppaux to ty::print.

  eddyb

  committed
  382d24e

  Copy full SHA for 382d24e

• rustc: add a 'tcx parameter to Print.

  eddyb

  committed
  297546e

  Copy full SHA for 297546e

• rustc: uniformize all lift expect messages to "could not lift for printing".

  eddyb

  committed
  372b1a5

  Copy full SHA for 372b1a5

• rustc: don't support tcx.lift returning None in ppaux.

  eddyb

  committed
  852fc6d

  Copy full SHA for 852fc6d

• rustc: don't support missing TLS TyCtxt in ty::print.

  eddyb

  committed
  c684814

  Copy full SHA for c684814

• rustc: rename PrintContext to PrintCx.

  eddyb

  committed
  5f3841c

  Copy full SHA for 5f3841c

• rustc: keep a TyCtxt in PrintCx and use it instead of ty::tls.

  eddyb

  committed
  0b3ab40

  Copy full SHA for 0b3ab40

• rustc: remove fmt::{Debug,Display} from ty::TyKind.

  eddyb

  committed
  01fa283

  Copy full SHA for 01fa283

• rustc: implement fmt::{Debug,Display} on Ty instead of TyS.

  eddyb

  committed
  3bad9f7

  Copy full SHA for 3bad9f7

• rustc: tie the 'tcx between Print and PrintCx in ty::print.

  eddyb

  committed
  eb525b0

  Copy full SHA for eb525b0

• rustc: use define_print! to implement fmt::{Display,Debug} for Kind.

  eddyb

  committed
  939c69c

  Copy full SHA for 939c69c

• rustc: rewrite PrintCx::parameterized to be much simpler and more general.

  eddyb

  committed
  fbbc7e9

  Copy full SHA for fbbc7e9

• rustc: support impl's in PrintCx::parameterized.

  eddyb

  committed
  1c2a3c5

  Copy full SHA for 1c2a3c5

• rustc_codegen_utils: revert some symbol_names refactors (while keeping the functional changes).

  eddyb

  committed
  7505bb6

  Copy full SHA for 7505bb6

• rustc: rewrite ty::item_path to be more functional than mutation-oriented.

  eddyb

  committed
  7d211e5

  Copy full SHA for 7d211e5

• rustc: remove ty::item_path::RootMode by moving local logic into the printer.

  eddyb

  committed
  387cacf

  Copy full SHA for 387cacf

• rustc: always rely on '_ to be not printed by ty::Region itself.

  eddyb

  committed
  329b8ca

  Copy full SHA for 329b8ca

• rustc: add a ty::RegionKind::display_outputs_anything method to avoid printing to a string.

  eddyb

  committed
  732b71a

  Copy full SHA for 732b71a

• rustc: move the formatter into ty::print::PrintCx.

  eddyb

  committed
  08d2744

  Copy full SHA for 08d2744

• rustc: explicitly pass the namespace to PrintCx::parameterized.

  eddyb

  committed
  2386168

  Copy full SHA for 2386168

• rustc: move the FORCE_IMPL_FILENAME_LINE handling into LocalPathPrinter.

  eddyb

  committed
  ed2be6f

  Copy full SHA for ed2be6f

• rustc: pass Option<&Substs> and Namespace around in ty::item_path.

  eddyb

  committed
  3e1cef7

  Copy full SHA for 3e1cef7

• rustc_mir: adjust the type_length_limit diagnostic to be more useful.

  eddyb

  committed
  6ca6c1a

  Copy full SHA for 6ca6c1a

• rustc: remove TyCtxt::parent_def_id in favor of TyCtxt::parent.

  eddyb

  committed
  f1af5a7

  Copy full SHA for f1af5a7

• rustc: rename item_path to def_path (except the module in ty).

  eddyb

  committed
  e0c75ff

  Copy full SHA for e0c75ff

• rustc: move the contents of ty::item_path to ty::print.

  eddyb

  committed
  9f8aaa0

  Copy full SHA for 9f8aaa0

• rustc: integrate LocalPathPrinter's behavior into FmtPrinter.

  eddyb

  committed
  b0fbca9

  Copy full SHA for b0fbca9

• rustc: merge PrintCx::parameterized and def_path printing.

  eddyb

  committed
  a15bfc6

  Copy full SHA for a15bfc6

• rustc: move <...>-less impl path special-case to pretty_path_qualified.

  eddyb

  committed
  aec5a48

  Copy full SHA for aec5a48

• rustc: move the FORCE_IMPL_FILENAME_LINE hack into print_def_path.

  eddyb

  committed
  39fd54a

  Copy full SHA for 39fd54a

• rustc: move ...::<impl ...> printing into pretty_path_qualified.

  eddyb

  committed
  df6650f

  Copy full SHA for df6650f

• rustc: assert ty::print::FORCE_ABSOLUTE isn't needed anymore.

  eddyb

  committed
  66cc029

  Copy full SHA for 66cc029

• rustc: remove ty::print::FORCE_ABSOLUTE altogether.

  eddyb

  committed
  36f64f1

  Copy full SHA for 36f64f1

• rustc: replace node_path_str with uses of def_path_str.

  eddyb

  committed
  27ddf2c

  Copy full SHA for 27ddf2c

• rustc: make ppaux' print macro use only one closure.

  eddyb

  committed
  387ea61

  Copy full SHA for 387ea61

• rustc: rename ppaux' print macro to just p and make its cx input implicit.

  eddyb

  committed
  972af5e

  Copy full SHA for 972af5e

• rustc: uniformize ty::print's error handling by requiring Result.

  eddyb

  committed
  5616ca8

  Copy full SHA for 5616ca8

• rustc: split off most of ty::print::PrintCx's fields into a separate struct.

  eddyb

  committed
  37e9185

  Copy full SHA for 37e9185

• rustc: remove the closure from ppaux's p! macro (by making ? implicit).

  eddyb

  committed
  ab5d6fb

  Copy full SHA for ab5d6fb

• rustc: pass ty::print::PrintCx by value.

  eddyb

  committed
  7c4eece

  Copy full SHA for 7c4eece

• rustc: don't keep RegionHighlightMode in a thread-local.

  eddyb

  committed
  cafd83d

  Copy full SHA for cafd83d

• rustc: centralize region printing in ty::RegionKind's Print impl.

  eddyb

  committed
  fc914aa

  Copy full SHA for fc914aa

• rustc: support overriding region printing in ty::print::Printer.

  eddyb

  committed
  88d96b2

  Copy full SHA for 88d96b2

• rustc: support overriding type printing in ty::print::Printer.

  eddyb

  committed
  35e5123

  Copy full SHA for 35e5123

• rustc: introduce a ty::print::PrettyPrinter helper for printing "<...>".

  eddyb

  committed
  ab26b26

  Copy full SHA for ab26b26

• rustc: don't pass Namespace explicitly, but rather track it in FmtPrinter.

  eddyb

  committed
  5211e37

  Copy full SHA for 5211e37

• rustc_codegen_utils: print all nominal types as paths, in symbol names.

  eddyb

  committed
  6d67d68

  Copy full SHA for 6d67d68

• rustc: move ty/print.rs to ty/print/mod.rs.

  eddyb

  committed
  26f1807

  Copy full SHA for 26f1807

• rustc: split out the pretty-printing parts of ty::print into a separate module.

  eddyb

  committed
  55871aa

  Copy full SHA for 55871aa

• rustc: remove fields from ty::print::PrintConfig available from tcx.

  eddyb

  committed
  800ddb3

  Copy full SHA for 800ddb3

• rustc: make util::ppaux private.

  eddyb

  committed
  d0a1bf5

  Copy full SHA for d0a1bf5

• rustc: disconnect all the Debug functionality from ty::print.

  eddyb

  committed
  9c42485

  Copy full SHA for 9c42485

• rustc: move Debug impls from ppaux to ty::structural_impls.

  eddyb

  committed
  fb53bb9

  Copy full SHA for fb53bb9

• rustc: remove obsolete hacks from ppaux, relating to normalization under HRTB.

  eddyb

  committed
  030cdc9

  Copy full SHA for 030cdc9

• rustc: streamline the Print/fmt::Display impls in ppaux and move them to ty::print::pretty.

  eddyb

  committed
  1a0f3a2

  Copy full SHA for 1a0f3a2

• rustc: move ty::print::PrintConfig's fields to FmtPrinter.

  eddyb

  committed
  381fa7a

  Copy full SHA for 381fa7a

• rustc: always hide defaulted generic args, even in verbose mode.

  eddyb

  committed
  72690d2

  Copy full SHA for 72690d2

• rustc: print elided regions as '_ instead of nothing, and use a separate check when optional.

  eddyb

  committed
  4deaa69

  Copy full SHA for 4deaa69

• rustc: make pretty_path_generic_args' task as simple as possible.

  eddyb

  committed
  ffa00d4

  Copy full SHA for ffa00d4

• rustc: don't thread existential projections through path_generic_args.

  eddyb

  committed
  c0c485c

  Copy full SHA for c0c485c

• rustc: remove the ability for pretty-printers to override nesting.

  eddyb

  committed
  2a65682

  Copy full SHA for 2a65682

• rustc: remove PrintCx from ty::Print and rely on printers carrying TyCtxt.

  eddyb

  committed
  52b4f2d

  Copy full SHA for 52b4f2d

• rustc: let ty::print::pretty's p! macro call arbitrary methods.

  eddyb

  committed
  9df7c3f

  Copy full SHA for 9df7c3f

• rustc: slice substs in ty::print instead of passing the full ones.

  eddyb

  committed
  8619ede

  Copy full SHA for 8619ede

• rustc: provide DisambiguatedDefPathData in ty::print.

  eddyb

  committed
  a54a41c

  Copy full SHA for a54a41c

• rustc: print ExistentialProjection with spaces around =, e.g. dyn Foo<A = X>.

  eddyb

  committed
  22d6c55

  Copy full SHA for 22d6c55

• we can now print on entering/leaving the topmost frame, and make sure it stays that way

  

  RalfJung

  authored and

  eddyb

  committed
  4653ae1

  Copy full SHA for 4653ae1

• Fix rebase fallout and address some review comments.

  eddyb

  committed
  0ee059d

  Copy full SHA for 0ee059d

• rustbuild: remove obsolete fulldeps behavior from src/test/pretty tests, and enable them by default.

  eddyb

  committed
  dbf19c3

  Copy full SHA for dbf19c3