Combine all builtin early lints #57726

Zoxc · 2019-01-18T08:39:07Z

This also adds a -Z no-interleave-lints option to allow benchmarking lints.

Zoxc · 2019-01-18T08:41:39Z

src/librustc_driver/driver.rs

@@ -1131,7 +1135,7 @@ where
    });

    time(sess, "early lint checks", || {
-        lint::check_ast_crate(sess, &krate, false)
+        lint::check_ast_crate(sess, &krate, false, rustc_lint::BuiltinCombinedEarlyLintPass::new())


This is not the same instance used to register the lints. I don't think that matters for the lints in rustc though.

Let's continue forward with this under the assumption that it will be ok.

estebank · 2019-01-18T19:27:55Z

@Zoxc you'll need to fix your tests.

…nts. Add a -Z no-interleave-lints option to allow benchmarking lints

estebank · 2019-01-24T19:57:37Z

I'll review this soon.

estebank · 2019-01-25T19:30:31Z

src/librustc_lint/builtin.rs

@@ -60,6 +60,10 @@ declare_lint! {
 pub struct WhileTrue;

 impl LintPass for WhileTrue {


All of these look like they could use a macro.

estebank · 2019-01-25T19:31:39Z

This looks reasonable to me.

@bors r+

bors · 2019-01-25T19:31:40Z

📌 Commit 9b5535a has been approved by estebank

bors · 2019-01-26T12:21:11Z

⌛ Testing commit 9b5535a with merge ccd428b...

@estebank

Combine all builtin early lints This also adds a -Z no-interleave-lints option to allow benchmarking lints. r? @estebank

bors · 2019-01-26T15:06:07Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: estebank
Pushing ccd428b to master...

rust-highfive · 2019-01-26T15:07:11Z

📣 Toolstate changed by #57726!

Tested on commit ccd428b.
Direct link to PR: #57726

💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @nrc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @nrc @Xanewok, @rust-lang/infra).

@Manishearth

Tested on commit rust-lang/rust@ccd428b. Direct link to PR: <rust-lang/rust#57726> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 rls on windows: test-pass → build-fail (cc @nrc @Xanewok, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @nrc @Xanewok, @rust-lang/infra).

rustup rustup rust-lang/rust#57907 and rust-lang/rust#57726 Fixes #3708

Changes: ```` wildcard_match_arm: Update lint count. wildcard_match_arm: add nesting issue to known. wildcard_match_arm: lint only enum matches. wildcard_match_arm: update ui test stderr wildcard_match_arm: format test. wilcard_match_arm: run rustfmt. wildcard_match_arm: add lint properly. wildcard_match_arm: rename function. wildcard_match_arm: add simple ui test. wildcard_match_arm: expand lint scope. Change match_wild lint name to WILDCARD_MATCH_ARM. Add match_wild lint (rust-lang#3649). fetch_prs_between: add .sh file ending cargo fmt Update various docs Use built-in entry_fn detection over self-built cargo fmt Reorganize conditionals: Run faster checks first Maybe fix ICE? Add initial version of const_fn lint Fix `unit_arg` false positive Rustfmt Check hypothetically failing conversion Remove tests for deprecated items Update more changed iterator paths Atomics constants are now handled by the deprecation lint Update changed iterator paths Update const slice processing update test stderr run cargo fmt rustup rust-lang#57907 Fix documentation for `slow_vector_initialization` rustup rust-lang#57726 Remove unsafe_vector_initialization from added lints Prevent incorrect cast_lossless suggestion in const_fn Incorporate review suggestions Fix dogfood tests on Appveyor test(versioncheck): Use .no_deps() test(versioncheck): Fix version equality check chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1 dependencies: update itertools from 0.7 to 0.8 Add script to fetch GitHub PRs between two commits gitattributes: Treat .fixed files as rust files Update changelog with all changes since 0.0.212 Fix `expect_fun_call` lint suggestions ````

@oli-obk

submodules: update clippy from f175352 to 6ce78d1 Should fix clippy toolstate Changes: ```` wildcard_match_arm: Update lint count. wildcard_match_arm: add nesting issue to known. wildcard_match_arm: lint only enum matches. wildcard_match_arm: update ui test stderr wildcard_match_arm: format test. wilcard_match_arm: run rustfmt. wildcard_match_arm: add lint properly. wildcard_match_arm: rename function. wildcard_match_arm: add simple ui test. wildcard_match_arm: expand lint scope. Change match_wild lint name to WILDCARD_MATCH_ARM. Add match_wild lint (#3649). fetch_prs_between: add .sh file ending cargo fmt Update various docs Use built-in entry_fn detection over self-built cargo fmt Reorganize conditionals: Run faster checks first Maybe fix ICE? Add initial version of const_fn lint Fix `unit_arg` false positive Rustfmt Check hypothetically failing conversion Remove tests for deprecated items Update more changed iterator paths Atomics constants are now handled by the deprecation lint Update changed iterator paths Update const slice processing update test stderr run cargo fmt rustup #57907 Fix documentation for `slow_vector_initialization` rustup #57726 Remove unsafe_vector_initialization from added lints Prevent incorrect cast_lossless suggestion in const_fn Incorporate review suggestions Fix dogfood tests on Appveyor test(versioncheck): Use .no_deps() test(versioncheck): Fix version equality check chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1 dependencies: update itertools from 0.7 to 0.8 Add script to fetch GitHub PRs between two commits gitattributes: Treat .fixed files as rust files Update changelog with all changes since 0.0.212 Fix `expect_fun_call` lint suggestions ```` r? @oli-obk

Changes: ```` wildcard_match_arm: Update lint count. wildcard_match_arm: add nesting issue to known. wildcard_match_arm: lint only enum matches. wildcard_match_arm: update ui test stderr wildcard_match_arm: format test. wilcard_match_arm: run rustfmt. wildcard_match_arm: add lint properly. wildcard_match_arm: rename function. wildcard_match_arm: add simple ui test. wildcard_match_arm: expand lint scope. Change match_wild lint name to WILDCARD_MATCH_ARM. Add match_wild lint (rust-lang#3649). fetch_prs_between: add .sh file ending cargo fmt Update various docs Use built-in entry_fn detection over self-built cargo fmt Reorganize conditionals: Run faster checks first Maybe fix ICE? Add initial version of const_fn lint Fix `unit_arg` false positive Rustfmt Check hypothetically failing conversion Remove tests for deprecated items Update more changed iterator paths Atomics constants are now handled by the deprecation lint Update changed iterator paths Update const slice processing update test stderr run cargo fmt rustup rust-lang/rust#57907 Fix documentation for `slow_vector_initialization` rustup rust-lang/rust#57726 Remove unsafe_vector_initialization from added lints Prevent incorrect cast_lossless suggestion in const_fn Incorporate review suggestions Fix dogfood tests on Appveyor test(versioncheck): Use .no_deps() test(versioncheck): Fix version equality check chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1 dependencies: update itertools from 0.7 to 0.8 Add script to fetch GitHub PRs between two commits gitattributes: Treat .fixed files as rust files Update changelog with all changes since 0.0.212 Fix `expect_fun_call` lint suggestions ````

Clean up some comments on lint implementation This updates some doc comments that have gotten very out of date. Some of these macros were removed or renamed in rust-lang#57726 and rust-lang#104863 and others. Manual emitting of lints was significantly reworked when the `Diagnostic` infrastructure was added. Rather than try to replicate the high-level documentation, I added pointers to the rustc-dev-guide. I linkified some types so that if they are renamed/removed without updating the docs, it will break CI.

Rollup merge of rust-lang#132221 - ehuss:lint-docs, r=compiler-errors Clean up some comments on lint implementation This updates some doc comments that have gotten very out of date. Some of these macros were removed or renamed in rust-lang#57726 and rust-lang#104863 and others. Manual emitting of lints was significantly reworked when the `Diagnostic` infrastructure was added. Rather than try to replicate the high-level documentation, I added pointers to the rustc-dev-guide. I linkified some types so that if they are renamed/removed without updating the docs, it will break CI.

rust-highfive assigned estebank Jan 18, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2019

Zoxc commented Jan 18, 2019

View reviewed changes

Zoxc force-pushed the combine-early-lints branch from 3041cf5 to cc755b7 Compare January 18, 2019 09:12

This comment has been minimized.

Sign in to view

Zoxc force-pushed the combine-early-lints branch from cc755b7 to 5d3ad6c Compare January 18, 2019 09:56

Zoxc force-pushed the combine-early-lints branch from 5d3ad6c to 72743e4 Compare January 19, 2019 03:59

Combine all builtin early lints and use a separate walk for plugin li…

beb0c74

…nts. Add a -Z no-interleave-lints option to allow benchmarking lints

Zoxc force-pushed the combine-early-lints branch from 72743e4 to beb0c74 Compare January 19, 2019 04:01

This comment has been minimized.

Sign in to view

Fix lints in tests

9b5535a

Zoxc force-pushed the combine-early-lints branch from 77ea610 to 9b5535a Compare January 19, 2019 07:10

estebank reviewed Jan 25, 2019

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2019

bors added a commit that referenced this pull request Jan 26, 2019

Auto merge of #57726 - Zoxc:combine-early-lints, r=estebank

ccd428b

Combine all builtin early lints This also adds a -Z no-interleave-lints option to allow benchmarking lints. r? @estebank

bors merged commit 9b5535a into rust-lang:master Jan 26, 2019

Zoxc deleted the combine-early-lints branch January 26, 2019 15:13

This was referenced Jan 26, 2019

overhaul unused doc comments lint #57882

Merged

Rollup of 9 pull requests #57912

Closed

matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Jan 26, 2019

rustup rust-lang/rust#57726

8e80cb0

matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Jan 26, 2019

rustup rust-lang/rust#57726

4a7b3b7

matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Jan 27, 2019

rustup rust-lang/rust#57726

a7b0a6d

matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Jan 27, 2019

rustup rust-lang/rust#57726

e9e0a7e

h-michael mentioned this pull request Jan 27, 2019

Build failling bacause of LintPass trait chainging rust-lang/rust-clippy#3707

Closed

phansch mentioned this pull request Jan 27, 2019

Clippy nightly build broken rust-lang/rust-clippy#3708

Closed

matthiaskrgr mentioned this pull request Jan 27, 2019

rustup rust-lang/rust-clippy#3705

Merged

bors added a commit to rust-lang/rust-clippy that referenced this pull request Jan 27, 2019

Auto merge of #3705 - matthiaskrgr:rustup, r=phansch

13421e3

rustup rustup rust-lang/rust#57907 and rust-lang/rust#57726 Fixes #3708

phansch mentioned this pull request Jan 28, 2019

Duplicate warnings after rustup fix rust-lang/rust-clippy#3710

Closed

g-bartoszek pushed a commit to g-bartoszek/rust-clippy that referenced this pull request Feb 5, 2019

rustup rust-lang/rust#57726

c997ab6

g-bartoszek pushed a commit to g-bartoszek/rust-clippy that referenced this pull request Feb 7, 2019

rustup rust-lang/rust#57726

9160f61

Noratrieb mentioned this pull request Nov 25, 2022

Reduce macro usage for lints #104863

Merged

ehuss mentioned this pull request Oct 27, 2024

Clean up some comments on lint implementation #132221

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Combine all builtin early lints #57726

Combine all builtin early lints #57726

Zoxc commented Jan 18, 2019

Zoxc Jan 18, 2019

estebank Jan 25, 2019

This comment has been minimized.

estebank commented Jan 18, 2019

This comment has been minimized.

This comment has been minimized.

estebank commented Jan 24, 2019

estebank Jan 25, 2019

estebank commented Jan 25, 2019

bors commented Jan 25, 2019

bors commented Jan 26, 2019

bors commented Jan 26, 2019

rust-highfive commented Jan 26, 2019

		@@ -60,6 +60,10 @@ declare_lint! {
		pub struct WhileTrue;

		impl LintPass for WhileTrue {

Combine all builtin early lints #57726

Combine all builtin early lints #57726

Conversation

Zoxc commented Jan 18, 2019

Zoxc Jan 18, 2019

Choose a reason for hiding this comment

estebank Jan 25, 2019

Choose a reason for hiding this comment

This comment has been minimized.

estebank commented Jan 18, 2019

This comment has been minimized.

This comment has been minimized.

estebank commented Jan 24, 2019

estebank Jan 25, 2019

Choose a reason for hiding this comment

estebank commented Jan 25, 2019

bors commented Jan 25, 2019

bors commented Jan 26, 2019

bors commented Jan 26, 2019

rust-highfive commented Jan 26, 2019