clone: managed boxes need to clone by shallow copy #5763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikomatsakis: r? I had to fix a broken test, and added some docstrings |
|
This should not have the trait bound. There's no need to T to implement Clone if the copy is shallow. |
Performing a deep copy isn't ever desired for a persistent data structure, and it requires a more complex implementation to do correctly. A deep copy needs to check for cycles to avoid an infinite loop.
|
@metajack: good point, fixed |
bors
added a commit
that referenced
this pull request
Apr 8, 2013
Performing a deep copy isn't ever desired for a persistent data structure, and it requires a more complex implementation to do correctly. A deep copy needs to check for cycles to avoid an infinite loop.
nikomatsakis
added a commit
to nikomatsakis/rust
that referenced
this pull request
Aug 7, 2014
…e `'b:'a`, meaning `'b outlives 'a`. Syntax currently does nothing but is needed for full fix to rust-lang#5763. To use this syntax, the issue_5763_bootstrap feature guard is required.
bors
added a commit
that referenced
this pull request
Aug 7, 2014
…kfelix Introduce syntax for lifetime bounds like `'b:'a`, meaning `'b outlives 'a`. Syntax currently does nothing but is needed for full fix to #5763. To use this syntax, the issue_5763_bootstrap feature guard is required.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2020
Rustup changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performing a deep copy isn't ever desired for a persistent data
structure, and it requires a more complex implementation to do
correctly. A deep copy needs to check for cycles to avoid an infinite
loop.