Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize transpose_result in 1.33 #57567

Merged
merged 1 commit into from
Jan 13, 2019
Merged

Stabilize transpose_result in 1.33 #57567

merged 1 commit into from
Jan 13, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jan 13, 2019

fixes #47338.

FCP completed: #47338 (comment)

r? @alexreg

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2019
@Centril
Copy link
Contributor Author

Centril commented Jan 13, 2019

@bors delegate=alexreg

@bors p=1

@bors
Copy link
Contributor

bors commented Jan 13, 2019

✌️ @alexreg can now approve this pull request

alexreg
alexreg previously requested changes Jan 13, 2019
View reviewed changes
src/libcore/option.rs Outdated Show resolved Hide resolved
src/libcore/result.rs Outdated Show resolved Hide resolved
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril Centril force-pushed the stabilize-transpose branch from 1dad774 to 338d238 Compare January 13, 2019 03:48
@alexreg
Copy link
Contributor

alexreg commented Jan 13, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Jan 13, 2019

📌 Commit 338d238e79d2e38f15adf5b2b034d54bf53e72ce has been approved by alexreg

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril Centril added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Jan 13, 2019
@Centril Centril force-pushed the stabilize-transpose branch from 338d238 to 6d7a4a6 Compare January 13, 2019 05:15
@Centril
Copy link
Contributor Author

Centril commented Jan 13, 2019

@bors r=alexreg

@bors
Copy link
Contributor

bors commented Jan 13, 2019

📌 Commit 6d7a4a6 has been approved by alexreg

@bors
Copy link
Contributor

bors commented Jan 13, 2019

⌛ Testing commit 6d7a4a6 with merge 1c561d9...

bors added a commit that referenced this pull request Jan 13, 2019
@bors
Auto merge of #57567 - Centril:stabilize-transpose, r=alexreg
1c561d9 
Stabilize `transpose_result` in 1.33

fixes #47338.

FCP completed: #47338 (comment)

r? @alexreg
@bors
Copy link
Contributor

bors commented Jan 13, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexreg
Pushing 1c561d9 to master...

@bors bors merged commit 6d7a4a6 into rust-lang:master Jan 13, 2019
@Centril Centril deleted the stabilize-transpose branch January 13, 2019 17:08
@clarfonthey
Copy link
Contributor

Was the discussion in the tracking issue taken into account when stabilising? There was discrepancy on the name that wasn't resolved.

@Centril
Copy link
Contributor Author

Centril commented Jan 14, 2019

@clarcharr I read the discussion but was personally not convinced that it should stop stabilization; however, I'm not on the libs team. The FCP completed, so no one in the libs team found the bikeshed sufficiently important to raise a concern. If you think it's important enough, talk to a libs member and convince them to backport a name change to beta.

@pnkfelix pnkfelix mentioned this pull request Jan 28, 2019
Closed
@Centril Centril added this to the 1.33 milestone Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexreg alexreg alexreg left review comments

Assignees

@alexreg alexreg

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.

Tracking Issue for Result<Option> and Option<Result> Conversion
5 participants
@Centril @bors @rust-highfive @alexreg @clarfonthey