provide suggestion for invalid boolean cast #57481
Merged
+47
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, don't suggest comparing to zero for non-numeric expressions.
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @estebank |
|
r=me once travis' green. |
estebank
approved these changes
Jan 9, 2019
|
@bors try |
|
⌛ Trying commit 565c39d with merge 9cd4bcc576081414006da5952afa37b99bd1691b... |
|
☀️ Test successful - checks-travis |
|
@bors r+ |
|
📌 Commit 565c39d has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 565c39d with merge d15431f258a694d436dd7add818c1dabd2b9b607... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 14, 2019
…bank provide suggestion for invalid boolean cast Also, don't suggest comparing to zero for non-numeric expressions.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 14, 2019
…bank provide suggestion for invalid boolean cast Also, don't suggest comparing to zero for non-numeric expressions.
bors
added a commit
that referenced
this pull request
Jan 14, 2019
Rollup of 8 pull requests Successful merges: - #57043 (Fix poor worst case performance of set intersection) - #57480 (Clean up and fix a bug in query plumbing) - #57481 (provide suggestion for invalid boolean cast) - #57540 (Modify some parser diagnostics to continue evaluating beyond the parser) - #57570 (Querify local `plugin_registrar_fn` and `proc_macro_decls_static`) - #57572 (Unaccept `extern_in_paths`) - #57585 (Recover from item trailing semicolon) - #57589 (Add a debug_assert to Vec::set_len) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, don't suggest comparing to zero for non-numeric expressions.