-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cargo.lock to use the latest compiler_builtins
#57414
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors: r+ rollup |
📌 Commit 77ff018279e7e246613cbc3de0683845eb5deab3 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@alexcrichton that failure looks above my pay grade :/ |
You'll just need to run |
@bors: r+ |
📌 Commit 81e4582c3dd877d50dd3d7a923e2c7346a4eb329 has been approved by |
☔ The latest upstream changes (presumably #57303) made this pull request unmergeable. Please resolve the merge conflicts. |
I think I did a rebase properly? Anyone I ask about the subject of rebaseing either laughs or cries, but never seems to give a whole answer, so I don't actually know. |
@Lokathor If you are in custom branch, use: git rebase master to rebase on master branch. Or longer: git rebase master <custom-branch> Or you need to rebase interactively git rebase -i master <custom-branch> Note that you should use git push -f after rebasing to force push the new changes to remote, otherwise remote will reject it. |
ho ho, I think you mean
|
I've been told that if I do a squash then it will safely get rid of the changes that I didn't make (all that stuff being changed that isn't |
Looks like git made a mess of this. Creating a new PR. |
…chton Update Cargo.lock to use the latest `compiler_builtins` A very tiny PR per the request of @alexcrichton : rust-lang/compiler-builtins#267 (comment) Rewrite of #57414 cc @Lokathor r? @alexcrichton
A very tiny PR per the request of @alexcrichton : rust-lang/compiler-builtins#267 (comment)