Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make std::cmp::Ord documentation specify what it means to agree with ParitalEq #57204

Merged
merged 2 commits into from
Dec 30, 2018
Merged

Make std::cmp::Ord documentation specify what it means to agree with ParitalEq #57204

merged 2 commits into from
Dec 30, 2018

Conversation

czipperz
Copy link
Contributor

Resolves #57157

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2018
@Centril
Copy link
Contributor

Centril commented Dec 29, 2018

r? @sfackler

sfackler
sfackler reviewed Dec 30, 2018
View reviewed changes
src/libcore/cmp.rs Outdated
/// implementing others.
/// Implementations of `PartialEq`, `PartialOrd`, and `Ord` *must*
/// agree with each other. That is, `a.cmp(b) == Ordering::Equal` if
/// and only if `a == b`. It's easy to accidentally make them disagree
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, a.partial_cmp(b) == Some(a.cmp(b)).

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2018
@sfackler
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 30, 2018

📌 Commit 445dadc has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 30, 2018
@bors
Copy link
Contributor

bors commented Dec 30, 2018

⌛ Testing commit 445dadc with merge 3ce6f6e...

bors added a commit that referenced this pull request Dec 30, 2018
@bors
Auto merge of #57204 - czipperz:ord_docs_must_agree, r=sfackler
3ce6f6e 
Make std::cmp::Ord documentation specify what it means to agree with ParitalEq

Resolves #57157
@bors
Copy link
Contributor

bors commented Dec 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 3ce6f6e to master...

@bors bors merged commit 445dadc into rust-lang:master Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfackler sfackler sfackler left review comments

Assignees

@sfackler sfackler

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@czipperz @rust-highfive @Centril @sfackler @bors @withoutboats