-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add io
and arch
modules to std::os::fortanix_sgx
#57119
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,3 +65,5 @@ pub mod usercalls { | |
pub mod mem { | ||
pub use sys::abi::mem::*; | ||
} | ||
|
||
pub use sys::ext::{io, arch}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
//! SGX-specific access to architectural features. | ||
//! | ||
//! The functionality in this module is further documented in the Intel | ||
//! Software Developer's Manual, Volume 3, Chapter 40. | ||
#![unstable(feature = "sgx_platform", issue = "56975")] | ||
|
||
use mem::MaybeUninit; | ||
|
||
/// Wrapper struct to force 16-byte alignment. | ||
#[repr(align(16))] | ||
#[unstable(feature = "sgx_platform", issue = "56975")] | ||
pub struct Align16<T>(pub T); | ||
|
||
/// Wrapper struct to force 128-byte alignment. | ||
#[repr(align(128))] | ||
#[unstable(feature = "sgx_platform", issue = "56975")] | ||
pub struct Align128<T>(pub T); | ||
|
||
/// Wrapper struct to force 512-byte alignment. | ||
#[repr(align(512))] | ||
#[unstable(feature = "sgx_platform", issue = "56975")] | ||
pub struct Align512<T>(pub T); | ||
|
||
const ENCLU_EREPORT: u32 = 0; | ||
const ENCLU_EGETKEY: u32 = 1; | ||
|
||
/// Call the `EGETKEY` instruction to obtain a 128-bit secret key. | ||
#[unstable(feature = "sgx_platform", issue = "56975")] | ||
pub fn egetkey(request: &Align512<[u8; 512]>) -> Result<Align16<[u8; 16]>, u32> { | ||
unsafe { | ||
let mut out = MaybeUninit::uninitialized(); | ||
let error; | ||
|
||
asm!( | ||
"enclu" | ||
: "={eax}"(error) | ||
: "{eax}"(ENCLU_EGETKEY), | ||
"{rbx}"(request), | ||
"{rcx}"(out.get_mut()) | ||
: "flags" | ||
); | ||
|
||
match error { | ||
0 => Ok(out.into_inner()), | ||
err => Err(err), | ||
} | ||
} | ||
} | ||
|
||
/// Call the `EREPORT` instruction. | ||
/// | ||
/// This creates a cryptographic report describing the contents of the current | ||
/// enclave. The report may be verified by the enclave described in | ||
/// `targetinfo`. | ||
#[unstable(feature = "sgx_platform", issue = "56975")] | ||
pub fn ereport( | ||
targetinfo: &Align512<[u8; 512]>, | ||
reportdata: &Align128<[u8; 64]>, | ||
) -> Align512<[u8; 432]> { | ||
unsafe { | ||
let mut report = MaybeUninit::uninitialized(); | ||
|
||
asm!( | ||
"enclu" | ||
: /* no output registers */ | ||
: "{eax}"(ENCLU_EREPORT), | ||
"{rbx}"(targetinfo), | ||
"{rcx}"(reportdata), | ||
"{rdx}"(report.get_mut()) | ||
); | ||
|
||
report.into_inner() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,119 @@ | ||
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
//! SGX-specific extensions to general I/O primitives | ||
//! | ||
//! SGX file descriptors behave differently from Unix file descriptors. See the | ||
//! description of [`TryIntoRawFd`](trait.TryIntoRawFd.html) for more details. | ||
#![unstable(feature = "sgx_platform", issue = "56975")] | ||
|
||
pub use sys::abi::usercalls::raw::Fd as RawFd; | ||
use net; | ||
use sys::{self, AsInner, FromInner, IntoInner, TryIntoInner}; | ||
|
||
/// A trait to extract the raw SGX file descriptor from an underlying | ||
/// object. | ||
#[unstable(feature = "sgx_platform", issue = "56975")] | ||
pub trait AsRawFd { | ||
/// Extracts the raw file descriptor. | ||
/// | ||
/// This method does **not** pass ownership of the raw file descriptor | ||
/// to the caller. The descriptor is only guaranteed to be valid while | ||
/// the original object has not yet been destroyed. | ||
#[unstable(feature = "sgx_platform", issue = "56975")] | ||
fn as_raw_fd(&self) -> RawFd; | ||
} | ||
|
||
/// A trait to express the ability to construct an object from a raw file | ||
/// descriptor. | ||
#[unstable(feature = "sgx_platform", issue = "56975")] | ||
pub trait FromRawFd { | ||
/// Constructs a new instance of `Self` from the given raw file | ||
/// descriptor. | ||
/// | ||
/// This function **consumes ownership** of the specified file | ||
/// descriptor. The returned object will take responsibility for closing | ||
/// it when the object goes out of scope. | ||
/// | ||
/// This function is also unsafe as the primitives currently returned | ||
/// have the contract that they are the sole owner of the file | ||
/// descriptor they are wrapping. Usage of this function could | ||
/// accidentally allow violating this contract which can cause memory | ||
/// unsafety in code that relies on it being true. | ||
#[unstable(feature = "sgx_platform", issue = "56975")] | ||
unsafe fn from_raw_fd(fd: RawFd) -> Self; | ||
} | ||
|
||
/// A trait to express the ability to consume an object and acquire ownership of | ||
/// its raw file descriptor. | ||
#[unstable(feature = "sgx_platform", issue = "56975")] | ||
pub trait TryIntoRawFd: Sized { | ||
/// Consumes this object, returning the raw underlying file descriptor, if | ||
/// this object is not cloned. | ||
/// | ||
/// This function **transfers ownership** of the underlying file descriptor | ||
/// to the caller. Callers are then the unique owners of the file descriptor | ||
/// and must close the descriptor once it's no longer needed. | ||
/// | ||
/// Unlike other platforms, on SGX, the file descriptor is shared between | ||
/// all clones of an object. To avoid race conditions, this function will | ||
/// only return `Ok` when called on the final clone. | ||
#[unstable(feature = "sgx_platform", issue = "56975")] | ||
fn try_into_raw_fd(self) -> Result<RawFd, Self>; | ||
} | ||
|
||
impl AsRawFd for net::TcpStream { | ||
fn as_raw_fd(&self) -> RawFd { *self.as_inner().as_inner().as_inner().as_inner() } | ||
} | ||
|
||
impl AsRawFd for net::TcpListener { | ||
fn as_raw_fd(&self) -> RawFd { *self.as_inner().as_inner().as_inner().as_inner() } | ||
} | ||
|
||
impl FromRawFd for net::TcpStream { | ||
unsafe fn from_raw_fd(fd: RawFd) -> net::TcpStream { | ||
let fd = sys::fd::FileDesc::from_inner(fd); | ||
let socket = sys::net::Socket::from_inner(fd); | ||
net::TcpStream::from_inner(sys::net::TcpStream::from_inner((socket, None))) | ||
} | ||
} | ||
|
||
impl FromRawFd for net::TcpListener { | ||
unsafe fn from_raw_fd(fd: RawFd) -> net::TcpListener { | ||
let fd = sys::fd::FileDesc::from_inner(fd); | ||
let socket = sys::net::Socket::from_inner(fd); | ||
net::TcpListener::from_inner(sys::net::TcpListener::from_inner(socket)) | ||
} | ||
} | ||
|
||
impl TryIntoRawFd for net::TcpStream { | ||
fn try_into_raw_fd(self) -> Result<RawFd, Self> { | ||
let (socket, peer_addr) = self.into_inner().into_inner(); | ||
match socket.try_into_inner() { | ||
Ok(fd) => Ok(fd.into_inner()), | ||
Err(socket) => { | ||
let sys = sys::net::TcpStream::from_inner((socket, peer_addr)); | ||
Err(net::TcpStream::from_inner(sys)) | ||
} | ||
} | ||
} | ||
} | ||
|
||
impl TryIntoRawFd for net::TcpListener { | ||
fn try_into_raw_fd(self) -> Result<RawFd, Self> { | ||
match self.into_inner().into_inner().try_into_inner() { | ||
Ok(fd) => Ok(fd.into_inner()), | ||
Err(socket) => { | ||
let sys = sys::net::TcpListener::from_inner(socket); | ||
Err(net::TcpListener::from_inner(sys)) | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
#![unstable(feature = "sgx_platform", issue = "56975")] | ||
|
||
pub mod arch; | ||
pub mod io; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to use more meaningful structs here, rather than
Align16<[u8; 16]>
? For instance, astruct Key
with the appropriate alignment and contents?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the PR description:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see! I didn't realize those were the types you meant.
We do need a better solution for bitfields, in-tree.
In the meantime, would you please add a comment to these types, explicitly saying to consider a more type-safe version before stabilizing? That way it doesn't get lost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about I'll add a note on the tracking issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jethrogb Alright, that works.