Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QueryResult #57031

Closed
wants to merge 1 commit into from
Closed

Remove QueryResult #57031

wants to merge 1 commit into from

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Dec 21, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2018
@michaelwoerister
Copy link
Member

Looks good!
@bors r+

@bors
Copy link
Contributor

bors commented Dec 21, 2018

📌 Commit 86e63ba has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2018
@Mark-Simulacrum
Copy link
Member

@Zoxc Is there a chance some commentary can be added or a link to a discussion posted? This appears to change behavior unless I'm misunderstanding when a query panics; is that intentional and fine?

Centril added a commit to Centril/rust that referenced this pull request Dec 22, 2018
@Zoxc
Copy link
Contributor Author

Zoxc commented Dec 24, 2018

@bors r-

I think not having this could result error messages being duplicating due to queries possibly executing twice with parallel queries. I think we'll have to wait until we no longer return using panics to do this.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 24, 2018
@Zoxc
Copy link
Contributor Author

Zoxc commented Dec 24, 2018

For example: We have two queries running in parallel, A and B. A emits an error message then exits early using a panic. We'll have to wait for B to complete before continuing unwinding, but B could itself call A which would cause the error message to be emitted again before B also will be unwound.

@Zoxc Zoxc closed this Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants