Refactor core::iter module #56932
Merged
Refactor core::iter module #56932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
rust-highfive
added
the
S-waiting-on-review
clarfonthey
force-pushed
the
iter_refactor
branch
7 times, most recently
from
63dcfa3 to
46ec648
Compare
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
iter_refactor
branch
2 times, most recently
from
6ecb30d to
5ea4df3
Compare
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
iter_refactor
branch
from
5ea4df3 to
3ef4a33
Compare
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
iter_refactor
branch
2 times, most recently
from
64dc651 to
674d5b2
Compare
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
iter_refactor
branch
from
674d5b2 to
33948e4
Compare
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
iter_refactor
branch
from
33948e4 to
6afd55b
Compare
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
iter_refactor
branch
5 times, most recently
from
f3f6f6d to
a7f5ef3
Compare
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
iter_refactor
branch
from
a7f5ef3 to
c7105d3
Compare
clarfonthey
force-pushed
the
iter_refactor
branch
from
fdaa15c to
02bda7a
Compare
|
This is ready to merge! If @bluss isn't available to review, maybe someone else could? |
|
r? @Centril |
|
There are some other tweaks like moving @bors r+ p=1 |
|
📌 Commit 02bda7a has been approved by |
bors
added
S-waiting-on-bors
|
Thank you so much @Centril! I agree with you on |
bors
added a commit
that referenced
this pull request
Jan 27, 2019
Refactor core::iter module A while back, I refactored `core::ops` in #42523 because the module had become a giant mess and was difficult to modify. Now, I'm doing the same with the `core::iter` module. Like the `core::ops` refactor, things have been split up into multiple commits to make rebasing easier, and so that you can follow changes. Although the diffs are hard to decipher, the only actual code changes I've made in the first few commits are to modify exports and imports. I save all of the actual code refactoring, e.g. modifying what methods are called, for the end.
|
☀️ Test successful - checks-travis, status-appveyor |
Centril
pushed a commit
to Centril/rust
that referenced
this pull request
Dec 22, 2019
The contents of this file have been moved in rust-lang#56932 (520e8b0) and the file should have been removed as well.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 22, 2019
…-DPC Remove iter_private.rs The contents of this file have been moved in rust-lang#56932 (520e8b0) and the file should have been removed as well.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 22, 2019
…-DPC Remove iter_private.rs The contents of this file have been moved in rust-lang#56932 (520e8b0) and the file should have been removed as well.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 22, 2019
…-DPC Remove iter_private.rs The contents of this file have been moved in rust-lang#56932 (520e8b0) and the file should have been removed as well.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 22, 2019
…-DPC Remove iter_private.rs The contents of this file have been moved in rust-lang#56932 (520e8b0) and the file should have been removed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back, I refactored
core::opsin #42523 because the module had become a giant mess and was difficult to modify. Now, I'm doing the same with thecore::itermodule.Like the
core::opsrefactor, things have been split up into multiple commits to make rebasing easier, and so that you can follow changes. Although the diffs are hard to decipher, the only actual code changes I've made in the first few commits are to modify exports and imports. I save all of the actual code refactoring, e.g. modifying what methods are called, for the end.